IO-2999 IO Test Report Server Migration

Signed-off-by: Allan Carr <allan.carr@thinkimex.com>

client/.env.development.imex

@@ -9,6 +9,6 @@ VITE_APP_CLOUDINARY_THUMB_TRANSFORMATIONS=c_fill,h_250,w_250
 VITE_APP_FIREBASE_PUBLIC_VAPID_KEY='BG3tzU7L2BXlGZ_3VLK4PNaRceoEXEnmHfxcVbRMF5o5g05ejslhVPki9kBM9cBBT-08Ad9kN3HSpS6JmrWD6h4'
 VITE_APP_STRIPE_PUBLIC_KEY=pk_test_51GqB4TJl3nQjrZ0wCQWAxAhlNF8jKe0tipIa6ExBaxwJGitwvFsIZUEua4dUzaMIAuXp4qwYHXx7lgjyQSwP0Pe900vzm38C7g
 VITE_APP_AXIOS_BASE_API_URL=/api/
-VITE_APP_REPORTS_SERVER_URL=https://reports3.test.imex.online
+VITE_APP_REPORTS_SERVER_URL=https://reports.test.imex.online
 VITE_APP_SPLIT_API=ts615lqgnmk84thn72uk18uu5pgce6e0l4rc
 VITE_APP_INSTANCE=IMEX

client/.env.development.rome

@@ -10,7 +10,7 @@ VITE_APP_CLOUDINARY_THUMB_TRANSFORMATIONS=c_fill,h_250,w_250
 VITE_APP_FIREBASE_PUBLIC_VAPID_KEY='BP1B7ZTYpn-KMt6nOxlld6aS8Skt3Q7ZLEqP0hAvGHxG4UojPYiXZ6kPlzZkUC5jH-EcWXomTLtmadAIxurfcHo'
 VITE_APP_STRIPE_PUBLIC_KEY=pk_test_51GqB4TJl3nQjrZ0wCQWAxAhlNF8jKe0tipIa6ExBaxwJGitwvFsIZUEua4dUzaMIAuXp4qwYHXx7lgjyQSwP0Pe900vzm38C7g
 VITE_APP_AXIOS_BASE_API_URL=/api/
-VITE_APP_REPORTS_SERVER_URL=https://reports3.test.imex.online
+VITE_APP_REPORTS_SERVER_URL=https://reports.test.romeonline.io
 VITE_APP_SPLIT_API=ts615lqgnmk84thn72uk18uu5pgce6e0l4rc
 VITE_APP_COUNTRY=USA
 VITE_APP_INSTANCE=ROME

client/.env.test.imex

@@ -9,7 +9,7 @@ VITE_APP_CLOUDINARY_THUMB_TRANSFORMATIONS=c_fill,h_250,w_250
 VITE_APP_FIREBASE_PUBLIC_VAPID_KEY='BN2GcDPjipR5MTEosO5dT4CfQ3cmrdBIsI4juoOQrRijn_5aRiHlwj1mlq0W145mOusx6xynEKl_tvYJhpCc9lo'
 VITE_APP_STRIPE_PUBLIC_KEY=pk_test_51GqB4TJl3nQjrZ0wCQWAxAhlNF8jKe0tipIa6ExBaxwJGitwvFsIZUEua4dUzaMIAuXp4qwYHXx7lgjyQSwP0Pe900vzm38C7g
 VITE_APP_AXIOS_BASE_API_URL=https://api.test.imex.online/
-VITE_APP_REPORTS_SERVER_URL=https://reports3.test.imex.online
+VITE_APP_REPORTS_SERVER_URL=https://reports.test.imex.online
 VITE_APP_IS_TEST=true
 VITE_APP_SPLIT_API=ts615lqgnmk84thn72uk18uu5pgce6e0l4rc
 VITE_APP_INSTANCE=IMEX

client/src/App/App.jsx

@@ -48,8 +48,6 @@ export function App({ bodyshop, checkUserSession, currentUser, online, setOnline
   const { t } = useTranslation();
   const navigate = useNavigate();
 
-  const scenarioNotificationsOn = client?.getTreatment("Realtime_Notifications_UI") === "on";
-
   useEffect(() => {
     if (!navigator.onLine) {
       setOnline(false);
@@ -203,12 +201,7 @@ export function App({ bodyshop, checkUserSession, currentUser, online, setOnline
             path="/manage/*"
             element={
               <ErrorBoundary>
-                <SocketProvider
-                  bodyshop={bodyshop}
-                  navigate={navigate}
-                  currentUser={currentUser}
-                  scenarioNotificationsOn={scenarioNotificationsOn}
-                >
+                <SocketProvider bodyshop={bodyshop} navigate={navigate} currentUser={currentUser}>
                   <PrivateRoute isAuthorized={currentUser.authorized} />
                 </SocketProvider>
               </ErrorBoundary>
@@ -220,12 +213,7 @@ export function App({ bodyshop, checkUserSession, currentUser, online, setOnline
             path="/tech/*"
             element={
               <ErrorBoundary>
-                <SocketProvider
-                  bodyshop={bodyshop}
-                  navigate={navigate}
-                  currentUser={currentUser}
-                  scenarioNotificationsOn={scenarioNotificationsOn}
-                >
+                <SocketProvider bodyshop={bodyshop} navigate={navigate} currentUser={currentUser}>
                   <PrivateRoute isAuthorized={currentUser.authorized} />
                 </SocketProvider>
               </ErrorBoundary>

client/src/components/header/header.component.jsx

@@ -1,15 +1,3 @@
-import { Badge, Layout, Menu, Spin } from "antd";
-import { useTranslation } from "react-i18next";
-import { useEffect, useRef, useState } from "react";
-import { connect } from "react-redux";
-import { createStructuredSelector } from "reselect";
-import { Link } from "react-router-dom";
-import { useQuery } from "@apollo/client";
-import { useSocket } from "../../contexts/SocketIO/useSocket.jsx";
-import { useSplitTreatments } from "@splitsoftware/splitio-react";
-import NotificationCenterContainer from "../notification-center/notification-center.container.jsx";
-import LockWrapper from "../lock-wrapper/lock-wrapper.component";
-import { HasFeatureAccess } from "../feature-wrapper/feature-wrapper.component";
 import {
   BankFilled,
   BarChartOutlined,
@@ -38,19 +26,31 @@ import {
   UnorderedListOutlined,
   UserOutlined
 } from "@ant-design/icons";
+import { useQuery } from "@apollo/client";
+import { useSplitTreatments } from "@splitsoftware/splitio-react";
+import { Badge, Layout, Menu, Spin } from "antd";
+import { useEffect, useRef, useState } from "react";
+import { useTranslation } from "react-i18next";
 import { BsKanban } from "react-icons/bs";
 import { FaCalendarAlt, FaCarCrash, FaCreditCard, FaFileInvoiceDollar, FaTasks } from "react-icons/fa";
 import { FiLogOut } from "react-icons/fi";
 import { GiPayMoney, GiPlayerTime, GiSettingsKnobs } from "react-icons/gi";
 import { IoBusinessOutline } from "react-icons/io5";
 import { RiSurveyLine } from "react-icons/ri";
+import { connect } from "react-redux";
+import { Link } from "react-router-dom";
+import { createStructuredSelector } from "reselect";
+import { useSocket } from "../../contexts/SocketIO/useSocket.jsx";
 import { GET_UNREAD_COUNT } from "../../graphql/notifications.queries.js";
 import { selectRecentItems, selectSelectedHeader } from "../../redux/application/application.selectors";
 import { setModalContext } from "../../redux/modals/modals.actions";
 import { signOutStart } from "../../redux/user/user.actions";
 import { selectBodyshop, selectCurrentUser } from "../../redux/user/user.selectors";
-import InstanceRenderManager from "../../utils/instanceRenderMgr";
 import day from "../../utils/day.js";
+import InstanceRenderManager from "../../utils/instanceRenderMgr";
+import { HasFeatureAccess } from "../feature-wrapper/feature-wrapper.component";
+import LockWrapper from "../lock-wrapper/lock-wrapper.component";
+import NotificationCenterContainer from "../notification-center/notification-center.container.jsx";
 
 // Redux mappings
 const mapStateToProps = createStructuredSelector({
@@ -208,25 +208,14 @@ function Header({
       key: "allpayments",
       id: "header-accounting-allpayments",
       icon: <BankFilled />,
-      label: (
-        <Link to="/manage/payments">
-          <LockWrapper featureName="payments" bodyshop={bodyshop}>
-            {t("menus.header.allpayments")}
-          </LockWrapper>
-        </Link>
-      )
+      label: <Link to="/manage/payments">{t("menus.header.allpayments")}</Link>
     },
     {
       key: "enterpayments",
       id: "header-accounting-enterpayments",
       icon: <FaCreditCard />,
-      label: (
-        <LockWrapper featureName="payments" bodyshop={bodyshop}>
-          {t("menus.header.enterpayment")}
-        </LockWrapper>
-      ),
+      label: t("menus.header.enterpayment"),
       onClick: () =>
-        HasFeatureAccess({ featureName: "payments", bodyshop }) &&
         setPaymentContext({
           actions: {},
           context: null

client/src/components/jobs-detail-header-actions/jobs-detail-header-actions.component.jsx

@@ -28,11 +28,11 @@ import { HasFeatureAccess } from "../feature-wrapper/feature-wrapper.component";
 import FormDateTimePickerComponent from "../form-date-time-picker/form-date-time-picker.component";
 import LockerWrapperComponent from "../lock-wrapper/lock-wrapper.component";
 import RbacWrapper from "../rbac-wrapper/rbac-wrapper.component";
+import ShareToTeamsButton from "../share-to-teams/share-to-teams.component.jsx";
 import AddToProduction from "./jobs-detail-header-actions.addtoproduction.util";
 import DuplicateJob from "./jobs-detail-header-actions.duplicate.util";
 import JobsDetailHeaderActionsToggleProduction from "./jobs-detail-header-actions.toggle-production";
 import { useNotification } from "../../contexts/Notifications/notificationContext.jsx";
-import ShareToTeamsButton from "../share-to-teams/share-to-teams.component.jsx";
 
 const mapStateToProps = createStructuredSelector({
   bodyshop: selectBodyshop,
@@ -775,15 +775,14 @@ export function JobsDetailHeaderActions({
     key: "enterpayments",
     id: "job-actions-enterpayments",
     disabled: !job.converted,
-    label: <LockerWrapperComponent featureName="payments">{t("menus.header.enterpayment")}</LockerWrapperComponent>,
+    label: t("menus.header.enterpayment"),
     onClick: () => {
       logImEXEvent("job_header_enter_payment");
 
-      HasFeatureAccess({ featureName: "payments", bodyshop }) &&
-        setPaymentContext({
-          actions: {},
-          context: { jobid: job.id }
-        });
+      setPaymentContext({
+        actions: {},
+        context: { jobid: job.id }
+      });
     }
   });
 

client/src/contexts/SocketIO/useSocket.jsx

@@ -14,6 +14,7 @@ import {
 } from "../../graphql/notifications.queries.js";
 import { useMutation } from "@apollo/client";
 import { useTranslation } from "react-i18next";
+import { useSplitTreatments } from "@splitsoftware/splitio-react";
 
 const SocketContext = createContext(null);
 
@@ -25,11 +26,10 @@ const INITIAL_NOTIFICATIONS = 10;
  * @param bodyshop
  * @param navigate
  * @param currentUser
- * @param scenarioNotificationsOn
  * @returns {JSX.Element}
  * @constructor
  */
-const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNotificationsOn }) => {
+const SocketProvider = ({ children, bodyshop, navigate, currentUser }) => {
   const socketRef = useRef(null);
   const [clientId, setClientId] = useState(null);
   const [isConnected, setIsConnected] = useState(false);
@@ -37,6 +37,14 @@ const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNot
   const userAssociationId = bodyshop?.associations?.[0]?.id;
   const { t } = useTranslation();
 
+  const {
+    treatments: { Realtime_Notifications_UI }
+  } = useSplitTreatments({
+    attributes: {},
+    names: ["Realtime_Notifications_UI"],
+    splitKey: bodyshop?.imexshopid
+  });
+
   const [markNotificationRead] = useMutation(MARK_NOTIFICATION_READ, {
     update: (cache, { data: { update_notifications } }) => {
       const timestamp = new Date().toISOString();
@@ -209,7 +217,7 @@ const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNot
 
       const handleNotification = (data) => {
         // Scenario Notifications have been disabled, bail.
-        if (!scenarioNotificationsOn) {
+        if (Realtime_Notifications_UI?.treatment !== "on") {
           return;
         }
 
@@ -329,7 +337,7 @@ const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNot
 
       const handleSyncNotificationRead = ({ notificationId, timestamp }) => {
         // Scenario Notifications have been disabled, bail.
-        if (!scenarioNotificationsOn) {
+        if (Realtime_Notifications_UI?.treatment !== "on") {
           return;
         }
 
@@ -371,7 +379,7 @@ const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNot
 
       const handleSyncAllNotificationsRead = ({ timestamp }) => {
         // Scenario Notifications have been disabled, bail.
-        if (!scenarioNotificationsOn) {
+        if (Realtime_Notifications_UI?.treatment !== "on") {
           return;
         }
 
@@ -462,7 +470,7 @@ const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNot
     markAllNotificationsRead,
     navigate,
     currentUser,
-    scenarioNotificationsOn,
+    Realtime_Notifications_UI,
     t
   ]);
 
@@ -474,7 +482,7 @@ const SocketProvider = ({ children, bodyshop, navigate, currentUser, scenarioNot
         isConnected,
         markNotificationRead,
         markAllNotificationsRead,
-        scenarioNotificationsOn
+        scenarioNotificationsOn: Realtime_Notifications_UI?.treatment === "on"
       }}
     >
       {children}

client/src/pages/payments-all/payments-all.container.page.jsx

@@ -1,6 +1,6 @@
 import { useQuery } from "@apollo/client";
 import queryString from "query-string";
-import React, { useEffect } from "react";
+import { useEffect } from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
 import { useLocation } from "react-router-dom";
@@ -10,23 +10,17 @@ import PaymentsListPaginated from "../../components/payments-list-paginated/paym
 import RbacWrapper from "../../components/rbac-wrapper/rbac-wrapper.component";
 import { QUERY_ALL_PAYMENTS_PAGINATED } from "../../graphql/payments.queries";
 import { setBreadcrumbs, setSelectedHeader } from "../../redux/application/application.actions";
-import { selectBodyshop } from "../../redux/user/user.selectors";
 import { pageLimit } from "../../utils/config";
-import FeatureWrapperComponent from "../../components/feature-wrapper/feature-wrapper.component";
 import InstanceRenderManager from "../../utils/instanceRenderMgr";
-import UpsellComponent, { upsellEnum } from "../../components/upsell/upsell.component";
-import { Card } from "antd";
 
-const mapStateToProps = createStructuredSelector({
-  bodyshop: selectBodyshop
-});
+const mapStateToProps = createStructuredSelector({});
 
 const mapDispatchToProps = (dispatch) => ({
   setBreadcrumbs: (breadcrumbs) => dispatch(setBreadcrumbs(breadcrumbs)),
   setSelectedHeader: (key) => dispatch(setSelectedHeader(key))
 });
 
-export function AllJobs({ bodyshop, setBreadcrumbs, setSelectedHeader }) {
+export function AllJobs({ setBreadcrumbs, setSelectedHeader }) {
   const searchParams = queryString.parse(useLocation().search);
   const { page, sortcolumn, sortorder, searchObj } = searchParams;
 
@@ -60,25 +54,15 @@ export function AllJobs({ bodyshop, setBreadcrumbs, setSelectedHeader }) {
 
   if (error) return <AlertComponent message={error.message} type="error" />;
   return (
-    <FeatureWrapperComponent
-      featureName="payments"
-      noauth={
-        <Card>
-          <UpsellComponent upsell={upsellEnum().payments.general} />
-        </Card>
-      }
-      z
-    >
-      <RbacWrapper action="payments:list">
-        <PaymentsListPaginated
-          refetch={refetch}
-          loading={loading}
-          searchParams={searchParams}
-          total={data ? data.payments_aggregate.aggregate.count : 0}
-          payments={data ? data.payments : []}
-        />
-      </RbacWrapper>
-    </FeatureWrapperComponent>
+    <RbacWrapper action="payments:list">
+      <PaymentsListPaginated
+        refetch={refetch}
+        loading={loading}
+        searchParams={searchParams}
+        total={data ? data.payments_aggregate.aggregate.count : 0}
+        payments={data ? data.payments : []}
+      />
+    </RbacWrapper>
   );
 }
 

server.js

@@ -22,7 +22,7 @@ const cookieParser = require("cookie-parser");
 const { Server } = require("socket.io");
 const { createAdapter } = require("@socket.io/redis-adapter");
 const { instrument } = require("@socket.io/admin-ui");
-const { isString, isEmpty } = require("lodash");
+const { isString, isEmpty, isFunction } = require("lodash");
 
 const logger = require("./server/utils/logger");
 const { applyRedisHelpers } = require("./server/utils/redisHelpers");
@@ -393,7 +393,9 @@ const main = async () => {
 
   const StatusReporter = StartStatusReporter();
   registerCleanupTask(async () => {
-    StatusReporter.end();
+    if (isFunction(StatusReporter?.end)) {
+      StatusReporter.end();
+    }
   });
 
   try {

server/notifications/queues/appQueue.js

@@ -2,6 +2,7 @@ const { Queue, Worker } = require("bullmq");
 const { INSERT_NOTIFICATIONS_MUTATION } = require("../../graphql-client/queries");
 const { registerCleanupTask } = require("../../utils/cleanupManager");
 const getBullMQPrefix = require("../../utils/getBullMQPrefix");
+const devDebugLogger = require("../../utils/devDebugLogger");
 const graphQLClient = require("../../graphql-client/graphql-client").client;
 
 // Base time-related constant in minutes, sourced from environment variable or defaulting to 1
@@ -49,7 +50,7 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
     const prefix = getBullMQPrefix();
     const devKey = process.env?.NODE_ENV === "production" ? "prod" : "dev";
 
-    logger.logger.debug(`Initializing Notifications Queues with prefix: ${prefix}`);
+    devDebugLogger(`Initializing Notifications Queues with prefix: ${prefix}`);
 
     addQueue = new Queue("notificationsAdd", {
       prefix,
@@ -67,7 +68,7 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
       "notificationsAdd",
       async (job) => {
         const { jobId, key, variables, recipients, body, jobRoNumber } = job.data;
-        logger.logger.debug(`Adding notifications for jobId ${jobId}`);
+        devDebugLogger(`Adding notifications for jobId ${jobId}`);
 
         const redisKeyPrefix = `app:${devKey}:notifications:${jobId}`;
         const notification = { key, variables, body, jobRoNumber, timestamp: Date.now() };
@@ -79,12 +80,12 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
           const notifications = existingNotifications ? JSON.parse(existingNotifications) : [];
           notifications.push(notification);
           await pubClient.set(userKey, JSON.stringify(notifications), "EX", NOTIFICATION_STORAGE_EXPIRATION / 1000);
-          logger.logger.debug(`Stored notification for ${user} under ${userKey}: ${JSON.stringify(notifications)}`);
+          devDebugLogger(`Stored notification for ${user} under ${userKey}: ${JSON.stringify(notifications)}`);
         }
 
         const consolidateKey = `app:${devKey}:consolidate:${jobId}`;
         const flagSet = await pubClient.setnx(consolidateKey, "pending");
-        logger.logger.debug(`Consolidation flag set for jobId ${jobId}: ${flagSet}`);
+        devDebugLogger(`Consolidation flag set for jobId ${jobId}: ${flagSet}`);
 
         if (flagSet) {
           await consolidateQueue.add(
@@ -97,10 +98,10 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
               backoff: LOCK_EXPIRATION
             }
           );
-          logger.logger.debug(`Scheduled consolidation for jobId ${jobId}`);
+          devDebugLogger(`Scheduled consolidation for jobId ${jobId}`);
           await pubClient.expire(consolidateKey, CONSOLIDATION_FLAG_EXPIRATION / 1000);
         } else {
-          logger.logger.debug(`Consolidation already scheduled for jobId ${jobId}`);
+          devDebugLogger(`Consolidation already scheduled for jobId ${jobId}`);
         }
       },
       {
@@ -114,24 +115,24 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
       "notificationsConsolidate",
       async (job) => {
         const { jobId, recipients } = job.data;
-        logger.logger.debug(`Consolidating notifications for jobId ${jobId}`);
+        devDebugLogger(`Consolidating notifications for jobId ${jobId}`);
 
         const redisKeyPrefix = `app:${devKey}:notifications:${jobId}`;
         const lockKey = `lock:${devKey}:consolidate:${jobId}`;
 
         const lockAcquired = await pubClient.set(lockKey, "locked", "NX", "EX", LOCK_EXPIRATION / 1000);
-        logger.logger.debug(`Lock acquisition for jobId ${jobId}: ${lockAcquired}`);
+        devDebugLogger(`Lock acquisition for jobId ${jobId}: ${lockAcquired}`);
 
         if (lockAcquired) {
           try {
             const allNotifications = {};
             const uniqueUsers = [...new Set(recipients.map((r) => r.user))];
-            logger.logger.debug(`Unique users for jobId ${jobId}: ${uniqueUsers}`);
+            devDebugLogger(`Unique users for jobId ${jobId}: ${uniqueUsers}`);
 
             for (const user of uniqueUsers) {
               const userKey = `${redisKeyPrefix}:${user}`;
               const notifications = await pubClient.get(userKey);
-              logger.logger.debug(`Retrieved notifications for ${user}: ${notifications}`);
+              devDebugLogger(`Retrieved notifications for ${user}: ${notifications}`);
 
               if (notifications) {
                 const parsedNotifications = JSON.parse(notifications);
@@ -141,13 +142,13 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
                   allNotifications[user][bodyShopId] = parsedNotifications;
                 }
                 await pubClient.del(userKey);
-                logger.logger.debug(`Deleted Redis key ${userKey}`);
+                devDebugLogger(`Deleted Redis key ${userKey}`);
               } else {
-                logger.logger.debug(`No notifications found for ${user} under ${userKey}`);
+                devDebugLogger(`No notifications found for ${user} under ${userKey}`);
               }
             }
 
-            logger.logger.debug(`Consolidated notifications: ${JSON.stringify(allNotifications)}`);
+            devDebugLogger(`Consolidated notifications: ${JSON.stringify(allNotifications)}`);
 
             // Insert notifications into the database and collect IDs
             const notificationInserts = [];
@@ -174,7 +175,7 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
               const insertResponse = await graphQLClient.request(INSERT_NOTIFICATIONS_MUTATION, {
                 objects: notificationInserts
               });
-              logger.logger.debug(
+              devDebugLogger(
                 `Inserted ${insertResponse.insert_notifications.affected_rows} notifications for jobId ${jobId}`
               );
 
@@ -208,11 +209,11 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
                       associationId
                     });
                   });
-                  logger.logger.debug(
+                  devDebugLogger(
                     `Sent ${notifications.length} consolidated notifications to ${user} for jobId ${jobId} with notificationId ${notificationId}`
                   );
                 } else {
-                  logger.logger.debug(`No socket IDs found for ${user} in bodyShopId ${bodyShopId}`);
+                  devDebugLogger(`No socket IDs found for ${user} in bodyShopId ${bodyShopId}`);
                 }
               }
             }
@@ -228,7 +229,7 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
             await pubClient.del(lockKey);
           }
         } else {
-          logger.logger.debug(`Skipped consolidation for jobId ${jobId} - lock held by another worker`);
+          devDebugLogger(`Skipped consolidation for jobId ${jobId} - lock held by another worker`);
         }
       },
       {
@@ -239,8 +240,9 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
       }
     );
 
-    addWorker.on("completed", (job) => logger.logger.debug(`Add job ${job.id} completed`));
-    consolidateWorker.on("completed", (job) => logger.logger.debug(`Consolidate job ${job.id} completed`));
+    addWorker.on("completed", (job) => devDebugLogger(`Add job ${job.id} completed`));
+    consolidateWorker.on("completed", (job) => devDebugLogger(`Consolidate job ${job.id} completed`));
+
     addWorker.on("failed", (job, err) =>
       logger.log(`app-queue-notification-error`, "ERROR", "notifications", "api", {
         message: err?.message,
@@ -256,9 +258,9 @@ const loadAppQueue = async ({ pubClient, logger, redisHelpers, ioRedis }) => {
 
     // Register cleanup task instead of direct process listeners
     const shutdown = async () => {
-      logger.logger.debug("Closing app queue workers...");
+      devDebugLogger("Closing app queue workers...");
       await Promise.all([addWorker.close(), consolidateWorker.close()]);
-      logger.logger.debug("App queue workers closed");
+      devDebugLogger("App queue workers closed");
     };
 
     registerCleanupTask(shutdown);
@@ -288,7 +290,7 @@ const dispatchAppsToQueue = async ({ appsToDispatch, logger }) => {
       { jobId, bodyShopId, key, variables, recipients, body, jobRoNumber },
       { jobId: `${jobId}:${Date.now()}` }
     );
-    logger.logger.debug(`Added notification to queue for jobId ${jobId} with ${recipients.length} recipients`);
+    devDebugLogger(`Added notification to queue for jobId ${jobId} with ${recipients.length} recipients`);
   }
 };
 

server/notifications/queues/emailQueue.js

@@ -4,6 +4,7 @@ const generateEmailTemplate = require("../../email/generateTemplate");
 const { InstanceEndpoints } = require("../../utils/instanceMgr");
 const { registerCleanupTask } = require("../../utils/cleanupManager");
 const getBullMQPrefix = require("../../utils/getBullMQPrefix");
+const devDebugLogger = require("../../utils/devDebugLogger");
 
 const EMAIL_CONSOLIDATION_DELAY_IN_MINS = (() => {
   const envValue = process.env?.EMAIL_CONSOLIDATION_DELAY_IN_MINS;
@@ -38,7 +39,7 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
     const prefix = getBullMQPrefix();
     const devKey = process.env?.NODE_ENV === "production" ? "prod" : "dev";
 
-    logger.logger.debug(`Initializing Email Notification Queues with prefix: ${prefix}`);
+    devDebugLogger(`Initializing Email Notification Queues with prefix: ${prefix}`);
 
     // Queue for adding email notifications
     emailAddQueue = new Queue("emailAdd", {
@@ -59,7 +60,7 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
       "emailAdd",
       async (job) => {
         const { jobId, jobRoNumber, bodyShopName, body, recipients } = job.data;
-        logger.logger.debug(`Adding email notifications for jobId ${jobId}`);
+        devDebugLogger(`Adding email notifications for jobId ${jobId}`);
 
         const redisKeyPrefix = `email:${devKey}:notifications:${jobId}`;
 
@@ -73,7 +74,7 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
           await pubClient.hsetnx(detailsKey, "lastName", lastName || "");
           await pubClient.expire(detailsKey, NOTIFICATION_EXPIRATION / 1000);
           await pubClient.sadd(`email:${devKey}:recipients:${jobId}`, user);
-          logger.logger.debug(`Stored message for ${user} under ${userKey}: ${body}`);
+          devDebugLogger(`Stored message for ${user} under ${userKey}: ${body}`);
         }
 
         const consolidateKey = `email:${devKey}:consolidate:${jobId}`;
@@ -89,10 +90,10 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
               backoff: LOCK_EXPIRATION
             }
           );
-          logger.logger.debug(`Scheduled email consolidation for jobId ${jobId}`);
+          devDebugLogger(`Scheduled email consolidation for jobId ${jobId}`);
           await pubClient.expire(consolidateKey, CONSOLIDATION_KEY_EXPIRATION / 1000);
         } else {
-          logger.logger.debug(`Email consolidation already scheduled for jobId ${jobId}`);
+          devDebugLogger(`Email consolidation already scheduled for jobId ${jobId}`);
         }
       },
       {
@@ -107,7 +108,7 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
       "emailConsolidate",
       async (job) => {
         const { jobId, jobRoNumber, bodyShopName } = job.data;
-        logger.logger.debug(`Consolidating emails for jobId ${jobId}`);
+        devDebugLogger(`Consolidating emails for jobId ${jobId}`);
 
         const lockKey = `lock:${devKey}:emailConsolidate:${jobId}`;
         const lockAcquired = await pubClient.set(lockKey, "locked", "NX", "EX", LOCK_EXPIRATION / 1000);
@@ -141,7 +142,7 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
                   type: "html",
                   html: emailBody
                 });
-                logger.logger.debug(
+                devDebugLogger(
                   `Sent consolidated email to ${recipient} for jobId ${jobId} with ${messages.length} updates`
                 );
                 await pubClient.del(userKey);
@@ -160,7 +161,7 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
             await pubClient.del(lockKey);
           }
         } else {
-          logger.logger.debug(`Skipped email consolidation for jobId ${jobId} - lock held by another worker`);
+          devDebugLogger(`Skipped email consolidation for jobId ${jobId} - lock held by another worker`);
         }
       },
       {
@@ -172,8 +173,9 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
     );
 
     // Event handlers for workers
-    emailAddWorker.on("completed", (job) => logger.logger.debug(`Email add job ${job.id} completed`));
-    emailConsolidateWorker.on("completed", (job) => logger.logger.debug(`Email consolidate job ${job.id} completed`));
+    emailAddWorker.on("completed", (job) => devDebugLogger(`Email add job ${job.id} completed`));
+    emailConsolidateWorker.on("completed", (job) => devDebugLogger(`Email consolidate job ${job.id} completed`));
+
     emailAddWorker.on("failed", (job, err) =>
       logger.log(`add-email-queue-failed`, "ERROR", "notifications", "api", {
         message: err?.message,
@@ -189,9 +191,9 @@ const loadEmailQueue = async ({ pubClient, logger }) => {
 
     // Register cleanup task instead of direct process listeners
     const shutdown = async () => {
-      logger.logger.debug("Closing email queue workers...");
+      devDebugLogger("Closing email queue workers...");
       await Promise.all([emailAddWorker.close(), emailConsolidateWorker.close()]);
-      logger.logger.debug("Email queue workers closed");
+      devDebugLogger("Email queue workers closed");
     };
     registerCleanupTask(shutdown);
   }
@@ -239,7 +241,7 @@ const dispatchEmailsToQueue = async ({ emailsToDispatch, logger }) => {
       { jobId, jobRoNumber, bodyShopName, body, recipients },
       { jobId: `${jobId}:${Date.now()}` }
     );
-    logger.logger.debug(`Added email notification to queue for jobId ${jobId} with ${recipients.length} recipients`);
+    devDebugLogger(`Added email notification to queue for jobId ${jobId} with ${recipients.length} recipients`);
   }
 };
 

server/opensearch/os-handler.js

@@ -248,7 +248,8 @@ async function OpenSearchSearchHandler(req, res) {
                           "*ownr_fn^8",
                           "*ownr_co_nm^8",
                           "*ownr_ph1^8",
-                          "*ownr_ph2^8"
+                          "*ownr_ph2^8",
+                          "*comment^6"
                           //  "*"
                         ]
                       }

server/utils/devDebugLogger.js

@@ -0,0 +1,10 @@
+const logger = require("./logger");
+
+const devDebugLogger = (message, meta) => {
+  if (process.env?.NODE_ENV === "production") {
+    return;
+  }
+  logger.logger.debug(message, meta);
+};
+
+module.exports = devDebugLogger;

server/utils/redisHelpers.js

@@ -1,4 +1,5 @@
 const { GET_BODYSHOP_BY_ID } = require("../graphql-client/queries");
+const devDebugLogger = require("./devDebugLogger");
 const client = require("../graphql-client/graphql-client").client;
 
 const BODYSHOP_CACHE_TTL = 3600; // 1 hour
@@ -87,7 +88,7 @@ const applyRedisHelpers = ({ pubClient, app, logger }) => {
   const addUserSocketMapping = async (email, socketId, bodyshopId) => {
     const socketMappingKey = getUserSocketMappingKey(email);
     try {
-      logger.log(`Adding socket ${socketId} to user ${email} for bodyshop ${bodyshopId}`, "debug", "redis");
+      devDebugLogger(`Adding socket ${socketId} to user ${email} for bodyshop ${bodyshopId}`);
       // Save the mapping: socketId -> bodyshopId
       await pubClient.hset(socketMappingKey, socketId, bodyshopId);
       // Set TTL (24 hours) for the mapping hash
@@ -109,7 +110,7 @@ const applyRedisHelpers = ({ pubClient, app, logger }) => {
       const exists = await pubClient.exists(socketMappingKey);
       if (exists) {
         await pubClient.expire(socketMappingKey, 86400);
-        logger.log(`Refreshed TTL for ${email} socket mapping`, "debug", "redis");
+        devDebugLogger(`Refreshed TTL for ${email} socket mapping`);
       }
     } catch (error) {
       logger.log(`Error refreshing TTL for ${email}: ${error}`, "ERROR", "redis");
@@ -126,20 +127,16 @@ const applyRedisHelpers = ({ pubClient, app, logger }) => {
     const socketMappingKey = getUserSocketMappingKey(email);
 
     try {
-      logger.log(`Removing socket ${socketId} mapping for user ${email}`, "DEBUG", "redis");
+      devDebugLogger(`Removing socket ${socketId} mapping for user ${email}`);
       // Look up the bodyshopId associated with this socket
       const bodyshopId = await pubClient.hget(socketMappingKey, socketId);
       if (!bodyshopId) {
-        logger.log(`Socket ${socketId} not found for user ${email}`, "DEBUG", "redis");
+        devDebugLogger(`Socket ${socketId} not found for user ${email}`);
         return;
       }
       // Remove the socket mapping
       await pubClient.hdel(socketMappingKey, socketId);
-      logger.log(
-        `Removed socket ${socketId} (associated with bodyshop ${bodyshopId}) for user ${email}`,
-        "DEBUG",
-        "redis"
-      );
+      devDebugLogger(`Removed socket ${socketId} (associated with bodyshop ${bodyshopId}) for user ${email}`);
 
       // Refresh TTL if any socket mappings remain
       const remainingSockets = await pubClient.hlen(socketMappingKey);
@@ -227,7 +224,7 @@ const applyRedisHelpers = ({ pubClient, app, logger }) => {
       await pubClient.set(key, jsonData);
       await pubClient.expire(key, BODYSHOP_CACHE_TTL);
 
-      logger.log("bodyshop-cache-miss", "DEBUG", "redis", null, {
+      devDebugLogger("bodyshop-cache-miss", {
         bodyshopId,
         action: "Fetched from DB and cached"
       });
@@ -254,7 +251,7 @@ const applyRedisHelpers = ({ pubClient, app, logger }) => {
       if (!values) {
         // Invalidate cache by deleting the key
         await pubClient.del(key);
-        logger.log("bodyshop-cache-invalidate", "DEBUG", "api", "redis", {
+        devDebugLogger("bodyshop-cache-invalidate", {
           bodyshopId,
           action: "Cache invalidated"
         });
@@ -263,7 +260,7 @@ const applyRedisHelpers = ({ pubClient, app, logger }) => {
         const jsonData = JSON.stringify(values);
         await pubClient.set(key, jsonData);
         await pubClient.expire(key, BODYSHOP_CACHE_TTL);
-        logger.log("bodyshop-cache-update", "DEBUG", "api", "redis", {
+        devDebugLogger("bodyshop-cache-update", {
           bodyshopId,
           action: "Cache updated",
           values