IO-2517 Add same check within C/C form

client/src/components/courtesy-car-form/courtesy-car-form.component.jsx

@@ -214,10 +214,7 @@ export default function CourtesyCarCreateFormComponent({ form, saveLoading }) {
         >
           <CourtesyCarStatus />
         </Form.Item>
-        <Form.Item
-          label={t("courtesycars.fields.readiness")}
-          name="readiness"
-        >
+        <Form.Item label={t("courtesycars.fields.readiness")} name="readiness">
           <CourtesyCarReadiness />
         </Form.Item>
         <div>
@@ -234,8 +231,9 @@ export default function CourtesyCarCreateFormComponent({ form, saveLoading }) {
           >
             {() => {
               const nextservicekm = form.getFieldValue("nextservicekm");
-              const mileageOver =
-                nextservicekm && nextservicekm <= form.getFieldValue("mileage");
+              const mileageOver = nextservicekm
+                ? nextservicekm <= form.getFieldValue("mileage")
+                : false;
               if (mileageOver)
                 return (
                   <Space direction="vertical" style={{ color: "tomato" }}>

client/src/components/courtesy-cars-list/courtesy-cars-list.component.jsx

@@ -74,10 +74,11 @@ export default function CourtesyCarsList({ loading, courtesycars, refetch }) {
       render: (text, record) => {
         const { nextservicedate, nextservicekm, mileage } = record;
 
-        const mileageOver = nextservicekm <= mileage;
+        const mileageOver = nextservicekm ? nextservicekm <= mileage : false;
 
         const dueForService =
-          nextservicedate && moment(nextservicedate).isBefore(moment());
+          nextservicedate &&
+          moment(nextservicedate).endOf("day").isSameOrBefore(moment());
 
         return (
           <Space>

hasura/metadata/tables.yaml

@@ -2023,24 +2023,24 @@
                   - active:
                       _eq: true
         columns:
-          - created_at
-          - employeeid
-          - id
           - labor_rates
           - percentage
-          - teamid
+          - created_at
           - updated_at
+          - employeeid
+          - id
+          - teamid
   select_permissions:
     - role: user
       permission:
         columns:
-          - created_at
-          - employeeid
-          - id
           - labor_rates
           - percentage
-          - teamid
+          - created_at
           - updated_at
+          - employeeid
+          - id
+          - teamid
         filter:
           employee_team:
             bodyshop:
@@ -2055,13 +2055,13 @@
     - role: user
       permission:
         columns:
-          - created_at
-          - employeeid
-          - id
           - labor_rates
           - percentage
-          - teamid
+          - created_at
           - updated_at
+          - employeeid
+          - id
+          - teamid
         filter:
           employee_team:
             bodyshop:
@@ -2123,23 +2123,21 @@
                     _eq: true
         columns:
           - active
-          - bodyshopid
-          - created_at
-          - id
-          - max_load
           - name
+          - created_at
           - updated_at
+          - bodyshopid
+          - id
   select_permissions:
     - role: user
       permission:
         columns:
           - active
-          - bodyshopid
-          - created_at
-          - id
-          - max_load
           - name
+          - created_at
           - updated_at
+          - bodyshopid
+          - id
         filter:
           bodyshop:
             associations:
@@ -2155,7 +2153,6 @@
         columns:
           - active
           - bodyshopid
-          - max_load
           - name
           - updated_at
         filter:

hasura/migrations/1704401074280_alter_table_public_employee_team_members_add_column_max_load/down.sql

@@ -1,4 +0,0 @@
--- Could not auto-generate a down migration.
--- Please write an appropriate down migration for the SQL below:
--- alter table "public"."employee_team_members" add column "max_load" numeric
---  not null default '10000';

hasura/migrations/1704401074280_alter_table_public_employee_team_members_add_column_max_load/up.sql

@@ -1,2 +0,0 @@
-alter table "public"."employee_team_members" add column "max_load" numeric
- not null default '10000';

hasura/migrations/1704403786392_alter_table_public_employee_team_members_drop_column_max_load/down.sql

@@ -1,3 +0,0 @@
-alter table "public"."employee_team_members" alter column "max_load" set default '10000'::numeric;
-alter table "public"."employee_team_members" alter column "max_load" drop not null;
-alter table "public"."employee_team_members" add column "max_load" numeric;

hasura/migrations/1704403786392_alter_table_public_employee_team_members_drop_column_max_load/up.sql

@@ -1 +0,0 @@
-alter table "public"."employee_team_members" drop column "max_load" cascade;

hasura/migrations/1704403846373_alter_table_public_employee_teams_add_column_max_load/down.sql

@@ -1,4 +0,0 @@
--- Could not auto-generate a down migration.
--- Please write an appropriate down migration for the SQL below:
--- alter table "public"."employee_teams" add column "max_load" numeric
---  not null default '10000';

hasura/migrations/1704403846373_alter_table_public_employee_teams_add_column_max_load/up.sql

@@ -1,2 +0,0 @@
-alter table "public"."employee_teams" add column "max_load" numeric
- not null default '10000';