IO-3166-Global-Notifications-Part-2: checkpoint, Modify additional strings as per Allan, Refactor builder down to prevent duplicate logic, comment out supplement imported.

client/src/utils/jobNotificationScenarios.js

@@ -1,10 +1,13 @@
+/** Notification Scenarios
+ * @description This file contains the scenarios for job notifications.
+ * @type {string[]}
+ */
 const notificationScenarios = [
   "job-assigned-to-me",
   "bill-posted",
   "critical-parts-status-changed",
   "part-marked-back-ordered",
   "new-note-added",
-  "supplement-imported",
   "schedule-dates-changed",
   "tasks-updated-created",
   "new-media-added-reassigned",
@@ -14,6 +17,7 @@ const notificationScenarios = [
   "job-status-change",
   "payment-collected-completed",
   "alternate-transport-changed"
+  // "supplement-imported", // Disabled for now
 ];
 
 export { notificationScenarios };

server/notifications/scenarioParser.js

@@ -35,7 +35,6 @@ const scenarioParser = async (req, jobIdField) => {
   } = req;
 
   // Step 1: Validate we know what user committed the action that fired the parser
-  // console.log("Step 1");
 
   const hasuraUserRole = event?.session_variables?.["x-hasura-role"];
   const hasuraUserId = event?.session_variables?.["x-hasura-user-id"];
@@ -52,7 +51,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 2: Extract just the jobId using the provided jobIdField
-  // console.log("Step 2");
 
   let jobId = null;
   if (jobIdField) {
@@ -70,7 +68,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 3: Query job watchers associated with the job ID using GraphQL
-  // console.log("Step 3");
 
   const watcherData = await gqlClient.request(queries.GET_JOB_WATCHERS, {
     jobid: jobId
@@ -96,7 +93,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 5: Perform the full event diff now that we know there are watchers
-  // console.log("Step 5");
 
   const eventData = await eventParser({
     newData: event.data.new,
@@ -107,7 +103,6 @@ const scenarioParser = async (req, jobIdField) => {
   });
 
   // Step 6: Extract body shop information from the job data
-  // console.log("Step 6");
 
   const bodyShopId = watcherData?.job?.bodyshop?.id;
   const bodyShopName = watcherData?.job?.bodyshop?.shopname;
@@ -122,7 +117,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 7: Identify scenarios that match the event data and job context
-  // console.log("Step 7");
 
   const matchingScenarios = await getMatchingScenarios(
     {
@@ -155,7 +149,6 @@ const scenarioParser = async (req, jobIdField) => {
   };
 
   // Step 8: Query notification settings for the job watchers
-  // console.log("Step 8");
 
   const associationsData = await gqlClient.request(queries.GET_NOTIFICATION_ASSOCIATIONS, {
     emails: jobWatchers.map((x) => x.email),
@@ -173,7 +166,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 9: Filter scenario watchers based on their enabled notification methods
-  // console.log("Step 9");
 
   finalScenarioData.matchingScenarios = finalScenarioData.matchingScenarios.map((scenario) => ({
     ...scenario,
@@ -213,7 +205,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 10: Build and collect scenarios to dispatch notifications for
-  // console.log("Step 10");
 
   const scenariosToDispatch = [];
 
@@ -240,7 +231,6 @@ const scenarioParser = async (req, jobIdField) => {
     }
 
     // Step 11: Filter scenario fields to include only those that changed
-    // console.log("Step 11");
 
     const filteredScenarioFields =
       scenario.fields?.filter((field) => eventData.changedFieldNames.includes(field)) || [];
@@ -274,7 +264,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 12: Dispatch email notifications to the email queue
-  // console.log("Step 12");
 
   const emailsToDispatch = scenariosToDispatch.map((scenario) => scenario?.email);
   if (!isEmpty(emailsToDispatch)) {
@@ -287,7 +276,6 @@ const scenarioParser = async (req, jobIdField) => {
   }
 
   // Step 13: Dispatch app notifications to the app queue
-  // console.log("Step 13");
 
   const appsToDispatch = scenariosToDispatch.map((scenario) => scenario?.app);
   if (!isEmpty(appsToDispatch)) {