From bc3b7c062cd8ef6511b71965d6b343d9e460568b Mon Sep 17 00:00:00 2001 From: Patrick Fic Date: Wed, 1 Dec 2021 14:38:06 -0800 Subject: [PATCH] Add back NA line items & updated vehicle lists. --- electron/changelog.json | 4 ++-- electron/decoder/decoder.js | 26 +++++++++++++------------- src/ipc/suvs.json | 1 + src/ipc/trucks.json | 2 -- 4 files changed, 16 insertions(+), 17 deletions(-) diff --git a/electron/changelog.json b/electron/changelog.json index 55455cf..7b20cf1 100644 --- a/electron/changelog.json +++ b/electron/changelog.json @@ -81,7 +81,7 @@ }, "1.0.25": { "title": "Release Notes for 1.0.25", - "date": "11/08/2021", - "notes": "New Features: \n- Resolved age calculation issue for model year 2022 vehicles." + "date": "12/01/2021", + "notes": "New Features: \n- Updated Vehicle categorization lists.\n- Improved N/A/$0 line item detection and calculations." } } diff --git a/electron/decoder/decoder.js b/electron/decoder/decoder.js index 17c59cd..79fac55 100644 --- a/electron/decoder/decoder.js +++ b/electron/decoder/decoder.js @@ -360,19 +360,19 @@ async function DecodeLinFile(extensionlessFilePath) { // Appears you are calculating based on ‘N.A.’ part values in the Mitchell database. // Reminder – if Mitchell DB has $0.00 price updates can be tracked, if it has N.A. it cannot calculate RPS value. - // if ( - // (jobline.db_price === null || jobline.db_price === 0) && - // !!jobline.act_price && - // jobline.act_price > 0 - // ) { - // // log.info( - // // "DB Price null/lower than act price", - // // jobline.line_desc, - // // jobline.db_price, - // // jobline.act_price - // // ); - // jobline.db_price = jobline.act_price; - // } + if ( + (jobline.db_price === null || jobline.db_price === 0) && + !!jobline.act_price && + jobline.act_price > 0 + ) { + // log.info( + // "DB Price null/lower than act price", + // jobline.line_desc, + // jobline.db_price, + // jobline.act_price + // ); + jobline.db_price = jobline.act_price; + } //*****TODO LINE**** //Any PAL, Remanufactured, Recycled, Aftermarket, Used, diff --git a/src/ipc/suvs.json b/src/ipc/suvs.json index 8ff923a..0d5ab7c 100644 --- a/src/ipc/suvs.json +++ b/src/ipc/suvs.json @@ -20,6 +20,7 @@ "EXPLORER XLT", "FLEX", "FLEX SE", + "ECOSPORT", "CHEROKEE", "CHEROKEE CLASSIC", diff --git a/src/ipc/trucks.json b/src/ipc/trucks.json index b0a15cd..0c154c0 100644 --- a/src/ipc/trucks.json +++ b/src/ipc/trucks.json @@ -523,8 +523,6 @@ "SONOMA CREW CAB", "SONOMA EXT CAB", - "YUKON SLT", - "1500", "1500 Classic", "Pickup 1500",