Compare commits

...

13 Commits

Author SHA1 Message Date
Dave
c68feef0b5 feature/IO-3477-Set-Parts-Location: Done 2025-12-30 15:10:47 -05:00
Dave Richer
4a7bb07345 Merged in hotfix/missing-dms-migration (pull request #2738)
hotfix/missing-dms-migration - Add Back DMS_ID
2025-12-19 20:13:11 +00:00
Dave
01fec9fa79 hotfix/missing-dms-migration - Add Back DMS_ID 2025-12-19 15:12:24 -05:00
Dave Richer
2f88d613c3 Merged in release/2025-12-19-mini (pull request #2732)
Release/2025 12 19 mini - IO-3467 IO-3468 IO-3402 IO-3473
2025-12-19 19:14:30 +00:00
Dave Richer
c9467b3982 Merged in feature/IO-3402-Import-Add-Notifiers (pull request #2734)
feature/IO-3402-Import-Add-Notifiers - Fix Normalize
2025-12-19 19:12:04 +00:00
Dave
ca4c48bd5c release/2025-12-19-mini - Merge 2025-12-19 12:41:23 -05:00
Dave Richer
e5fd5c8bcb Merged in feature/IO-3468-sentry-exceptions (pull request #2731)
Feature/IO-3468 sentry exceptions
2025-12-19 17:39:23 +00:00
Dave Richer
46945a24a7 Merged in feature/IO-3467-report-center-filter-ui (pull request #2730)
IO-3467 Resolve UI on report center filter.
2025-12-19 17:35:47 +00:00
Dave Richer
be746500a6 Merged in feature/IO-3402-Import-Add-Notifiers (pull request #2729)
Feature/IO-3402 Import Add Notifiers
2025-12-19 17:35:12 +00:00
Dave
71c6d9fa94 IO-3473 trim user input 2025-12-19 12:07:30 -05:00
Dave
6d94ce7e5c feature/IO-3468-Senty-Exceptions - Fix unused import 2025-12-18 13:52:55 -05:00
Patrick Fic
182a8d59ab IO-3468 Add sentry exceptions & minor nul coalesce fixes. 2025-12-16 10:28:00 -08:00
Patrick Fic
f1847ef650 IO-3467 Resolve UI on report center filter. 2025-12-15 08:37:32 -08:00
15 changed files with 414 additions and 197 deletions

View File

@@ -9,10 +9,10 @@ import {
WarningFilled WarningFilled
} from "@ant-design/icons"; } from "@ant-design/icons";
import { PageHeader } from "@ant-design/pro-layout"; import { PageHeader } from "@ant-design/pro-layout";
import { useMutation } from "@apollo/client"; import { gql, useMutation } from "@apollo/client";
import { Button, Dropdown, Input, Space, Table, Tag } from "antd"; import { Button, Dropdown, Input, Modal, Select, Space, Table, Tag, Typography } from "antd";
import axios from "axios"; import axios from "axios";
import { useState } from "react"; import { useMemo, useState } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { connect } from "react-redux"; import { connect } from "react-redux";
import { createStructuredSelector } from "reselect"; import { createStructuredSelector } from "reselect";
@@ -47,6 +47,19 @@ import JobLinesExpander from "./job-lines-expander.component";
import JobLinesPartPriceChange from "./job-lines-part-price-change.component"; import JobLinesPartPriceChange from "./job-lines-part-price-change.component";
import JobLinesExpanderSimple from "./jobs-lines-expander-simple.component"; import JobLinesExpanderSimple from "./jobs-lines-expander-simple.component";
import { logImEXEvent } from "../../firebase/firebase.utils"; import { logImEXEvent } from "../../firebase/firebase.utils";
import { useNotification } from "../../contexts/Notifications/notificationContext.jsx";
const UPDATE_JOB_LINES_LOCATION_BULK = gql`
mutation UPDATE_JOB_LINES_LOCATION_BULK($ids: [uuid!]!, $location: String!) {
update_joblines(where: { id: { _in: $ids } }, _set: { location: $location }) {
affected_rows
returning {
id
location
}
}
}
`;
const mapStateToProps = createStructuredSelector({ const mapStateToProps = createStructuredSelector({
bodyshop: selectBodyshop, bodyshop: selectBodyshop,
@@ -83,6 +96,9 @@ export function JobLinesComponent({
isPartsEntry isPartsEntry
}) { }) {
const [deleteJobLine] = useMutation(DELETE_JOB_LINE_BY_PK); const [deleteJobLine] = useMutation(DELETE_JOB_LINE_BY_PK);
const [bulkUpdateLocations] = useMutation(UPDATE_JOB_LINES_LOCATION_BULK);
const notification = useNotification();
const { const {
treatments: { Enhanced_Payroll } treatments: { Enhanced_Payroll }
} = useSplitTreatments({ } = useSplitTreatments({
@@ -103,9 +119,83 @@ export function JobLinesComponent({
} }
}); });
// Bulk location modal state
const [bulkLocationOpen, setBulkLocationOpen] = useState(false);
const [bulkLocation, setBulkLocation] = useState(null);
const [bulkLocationSaving, setBulkLocationSaving] = useState(false);
const { t } = useTranslation(); const { t } = useTranslation();
const jobIsPrivate = bodyshop.md_ins_cos.find((c) => c.name === job.ins_co_nm)?.private; const jobIsPrivate = bodyshop.md_ins_cos.find((c) => c.name === job.ins_co_nm)?.private;
const selectedLineIds = useMemo(() => selectedLines.map((l) => l?.id).filter(Boolean), [selectedLines]);
const commonSelectedLocation = useMemo(() => {
const locs = selectedLines
.map((l) => (typeof l?.location === "string" ? l.location : ""))
.map((x) => x.trim())
.filter(Boolean);
if (locs.length === 0) return null;
const uniq = _.uniq(locs);
return uniq.length === 1 ? uniq[0] : null;
}, [selectedLines]);
const openBulkLocationModal = () => {
setBulkLocation(commonSelectedLocation);
setBulkLocationOpen(true);
logImEXEvent("joblines_bulk_location_open", { count: selectedLineIds.length });
};
const closeBulkLocationModal = () => {
setBulkLocationOpen(false);
setBulkLocation(null);
};
const saveBulkLocation = async () => {
if (selectedLineIds.length === 0) return;
setBulkLocationSaving(true);
try {
const locationToSave = (bulkLocation ?? "").toString();
const result = await bulkUpdateLocations({
variables: {
ids: selectedLineIds,
location: locationToSave
}
});
if (!result?.errors) {
// Keep UI selection consistent without waiting for refetch
setSelectedLines((prev) =>
prev.map((l) => (l && selectedLineIds.includes(l.id) ? { ...l, location: locationToSave } : l))
);
notification["success"]({ message: t("joblines.successes.saved") });
logImEXEvent("joblines_bulk_location_saved", {
count: selectedLineIds.length,
location: locationToSave
});
closeBulkLocationModal();
if (refetch) refetch();
} else {
notification["error"]({
message: t("joblines.errors.saving", { error: JSON.stringify(result.errors) })
});
}
} catch (error) {
notification["error"]({
message: t("joblines.errors.saving", { error: error?.message || String(error) })
});
} finally {
setBulkLocationSaving(false);
}
};
const columns = [ const columns = [
{ {
title: "#", title: "#",
@@ -171,46 +261,16 @@ export function JobLinesComponent({
? ["PAN", "PAC", "PAR", "PAL", "PAA", "PAM", "PAP", "PAS", "PASL", "PAG", "PAO"] ? ["PAN", "PAC", "PAR", "PAL", "PAA", "PAM", "PAP", "PAS", "PASL", "PAG", "PAO"]
: ["PAN", "PAC", "PAR", "PAL", "PAA", "PAM", "PAP", "PAS", "PASL", "PAG"] : ["PAN", "PAC", "PAR", "PAL", "PAA", "PAM", "PAP", "PAS", "PASL", "PAG"]
}, },
{ { text: t("joblines.fields.part_types.PAN"), value: ["PAN"] },
text: t("joblines.fields.part_types.PAN"), { text: t("joblines.fields.part_types.PAP"), value: ["PAP"] },
value: ["PAN"] { text: t("joblines.fields.part_types.PAL"), value: ["PAL"] },
}, { text: t("joblines.fields.part_types.PAA"), value: ["PAA"] },
{ { text: t("joblines.fields.part_types.PAG"), value: ["PAG"] },
text: t("joblines.fields.part_types.PAP"), { text: t("joblines.fields.part_types.PAS"), value: ["PAS"] },
value: ["PAP"] { text: t("joblines.fields.part_types.PASL"), value: ["PASL"] },
}, { text: t("joblines.fields.part_types.PAC"), value: ["PAC"] },
{ { text: t("joblines.fields.part_types.PAR"), value: ["PAR"] },
text: t("joblines.fields.part_types.PAL"), { text: t("joblines.fields.part_types.PAM"), value: ["PAM"] },
value: ["PAL"]
},
{
text: t("joblines.fields.part_types.PAA"),
value: ["PAA"]
},
{
text: t("joblines.fields.part_types.PAG"),
value: ["PAG"]
},
{
text: t("joblines.fields.part_types.PAS"),
value: ["PAS"]
},
{
text: t("joblines.fields.part_types.PASL"),
value: ["PASL"]
},
{
text: t("joblines.fields.part_types.PAC"),
value: ["PAC"]
},
{
text: t("joblines.fields.part_types.PAR"),
value: ["PAR"]
},
{
text: t("joblines.fields.part_types.PAM"),
value: ["PAM"]
},
...(isPartsEntry ...(isPartsEntry
? [ ? [
{ {
@@ -220,7 +280,6 @@ export function JobLinesComponent({
] ]
: []) : [])
], ],
onFilter: (value, record) => value.includes(record.part_type), onFilter: (value, record) => value.includes(record.part_type),
render: (text, record) => (record.part_type ? t(`joblines.fields.part_types.${record.part_type}`) : null) render: (text, record) => (record.part_type ? t(`joblines.fields.part_types.${record.part_type}`) : null)
}, },
@@ -246,7 +305,6 @@ export function JobLinesComponent({
title: t("joblines.fields.mod_lbr_ty"), title: t("joblines.fields.mod_lbr_ty"),
dataIndex: "mod_lbr_ty", dataIndex: "mod_lbr_ty",
key: "mod_lbr_ty", key: "mod_lbr_ty",
sorter: (a, b) => alphaSort(a.mod_lbr_ty, b.mod_lbr_ty), sorter: (a, b) => alphaSort(a.mod_lbr_ty, b.mod_lbr_ty),
sortOrder: state.sortedInfo.columnKey === "mod_lbr_ty" && state.sortedInfo.order, sortOrder: state.sortedInfo.columnKey === "mod_lbr_ty" && state.sortedInfo.order,
render: (text, record) => (record.mod_lbr_ty ? t(`joblines.fields.lbr_types.${record.mod_lbr_ty}`) : null) render: (text, record) => (record.mod_lbr_ty ? t(`joblines.fields.lbr_types.${record.mod_lbr_ty}`) : null)
@@ -255,7 +313,6 @@ export function JobLinesComponent({
title: t("joblines.fields.mod_lb_hrs"), title: t("joblines.fields.mod_lb_hrs"),
dataIndex: "mod_lb_hrs", dataIndex: "mod_lb_hrs",
key: "mod_lb_hrs", key: "mod_lb_hrs",
sorter: (a, b) => a.mod_lb_hrs - b.mod_lb_hrs, sorter: (a, b) => a.mod_lb_hrs - b.mod_lb_hrs,
sortOrder: state.sortedInfo.columnKey === "mod_lb_hrs" && state.sortedInfo.order sortOrder: state.sortedInfo.columnKey === "mod_lb_hrs" && state.sortedInfo.order
}, },
@@ -310,18 +367,12 @@ export function JobLinesComponent({
sorter: (a, b) => alphaSort(a.status, b.status), sorter: (a, b) => alphaSort(a.status, b.status),
sortOrder: state.sortedInfo.columnKey === "status" && state.sortedInfo.order, sortOrder: state.sortedInfo.columnKey === "status" && state.sortedInfo.order,
filteredValue: state.filteredInfo.status || null, filteredValue: state.filteredInfo.status || null,
filters: filters:
(jobLines && (jobLines &&
jobLines jobLines
.map((l) => l.status) .map((l) => l.status)
.filter(onlyUnique) .filter(onlyUnique)
.map((s) => { .map((s) => ({ text: s || t("dashboard.errors.status"), value: [s] }))) ||
return {
text: s || t("dashboard.errors.status"),
value: [s]
};
})) ||
[], [],
onFilter: (value, record) => value.includes(record.status), onFilter: (value, record) => value.includes(record.status),
render: (text, record) => <JobLineStatusPopup jobline={record} disabled={jobRO} /> render: (text, record) => <JobLineStatusPopup jobline={record} disabled={jobRO} />
@@ -376,9 +427,7 @@ export function JobLinesComponent({
}); });
} }
}); });
await axios.post("/job/totalsssu", { await axios.post("/job/totalsssu", { id: job.id });
id: job.id
});
if (refetch) refetch(); if (refetch) refetch();
}} }}
> >
@@ -448,6 +497,36 @@ export function JobLinesComponent({
return ( return (
<div> <div>
<PartsOrderModalContainer /> <PartsOrderModalContainer />
<Modal
open={bulkLocationOpen}
title={t("joblines.actions.updatelocation")}
onCancel={closeBulkLocationModal}
onOk={saveBulkLocation}
okButtonProps={{
disabled: jobRO || technician || selectedLineIds.length === 0,
loading: bulkLocationSaving
}}
destroyOnHidden
>
<Space direction="vertical" style={{ width: "100%" }}>
<Typography.Text type="secondary">
{t("general.labels.selected")}: {selectedLineIds.length}
</Typography.Text>
<Select
allowClear
placeholder={t("joblines.fields.location")}
value={bulkLocation}
style={{ width: "100%" }}
popupMatchSelectWidth={false}
onChange={(val) => setBulkLocation(val ?? null)}
options={(bodyshop?.md_parts_locations || []).map((loc) => ({ label: loc, value: loc }))}
/>
<Typography.Text type="secondary">{t("joblines.labels.bulk_location_help")}</Typography.Text>
</Space>
</Modal>
{!technician && ( {!technician && (
<PartsOrderDrawer <PartsOrderDrawer
job={job} job={job}
@@ -457,6 +536,7 @@ export function JobLinesComponent({
setTaskUpsertContext={setTaskUpsertContext} setTaskUpsertContext={setTaskUpsertContext}
/> />
)} )}
<PageHeader <PageHeader
title={t("jobs.labels.estimatelines")} title={t("jobs.labels.estimatelines")}
extra={ extra={
@@ -465,6 +545,16 @@ export function JobLinesComponent({
<SyncOutlined /> <SyncOutlined />
</Button> </Button>
{/* Bulk Update Location */}
<Button
id="job-lines-bulk-update-location-button"
disabled={jobRO || technician || selectedLineIds.length === 0}
onClick={openBulkLocationModal}
>
{t("joblines.actions.updatelocation")}
{selectedLineIds.length > 0 && ` (${selectedLineIds.length})`}
</Button>
{job.special_coverage_policy && ( {job.special_coverage_policy && (
<Tag color="tomato"> <Tag color="tomato">
<Space> <Space>
@@ -473,6 +563,7 @@ export function JobLinesComponent({
</Space> </Space>
</Tag> </Tag>
)} )}
{!isPartsEntry && ( {!isPartsEntry && (
<JobLineDispatchButton <JobLineDispatchButton
selectedLines={selectedLines} selectedLines={selectedLines}
@@ -481,9 +572,11 @@ export function JobLinesComponent({
disabled={technician} disabled={technician}
/> />
)} )}
{Enhanced_Payroll.treatment === "on" && ( {Enhanced_Payroll.treatment === "on" && (
<JobLineBulkAssignComponent selectedLines={selectedLines} setSelectedLines={setSelectedLines} job={job} /> <JobLineBulkAssignComponent selectedLines={selectedLines} setSelectedLines={setSelectedLines} job={job} />
)} )}
{!isPartsEntry && ( {!isPartsEntry && (
<Button <Button
disabled={(job && !job.converted) || (selectedLines.length > 0 ? false : true) || jobRO || technician} disabled={(job && !job.converted) || (selectedLines.length > 0 ? false : true) || jobRO || technician}
@@ -499,27 +592,20 @@ export function JobLinesComponent({
isinhouse: true, isinhouse: true,
date: dayjs(), date: dayjs(),
total: 0, total: 0,
billlines: selectedLines.map((p) => { billlines: selectedLines.map((p) => ({
return { joblineid: p.id,
joblineid: p.id, actual_price: p.act_price,
actual_price: p.act_price, actual_cost: 0,
actual_cost: 0, //p.act_price, line_desc: p.line_desc,
line_desc: p.line_desc, line_remarks: p.line_remarks,
line_remarks: p.line_remarks, part_type: p.part_type,
part_type: p.part_type, quantity: p.quantity || 1,
quantity: p.quantity || 1, applicable_taxes: { local: false, state: false, federal: false }
applicable_taxes: { }))
local: false,
state: false,
federal: false
}
};
})
} }
} }
}); });
//Clear out the selected lines. IO-785
setSelectedLines([]); setSelectedLines([]);
}} }}
> >
@@ -528,6 +614,7 @@ export function JobLinesComponent({
{selectedLines.length > 0 && ` (${selectedLines.length})`} {selectedLines.length > 0 && ` (${selectedLines.length})`}
</Button> </Button>
)} )}
<Button <Button
id="job-lines-order-parts-button" id="job-lines-order-parts-button"
disabled={(job && !job.converted) || (selectedLines.length > 0 ? false : true) || jobRO || technician} disabled={(job && !job.converted) || (selectedLines.length > 0 ? false : true) || jobRO || technician}
@@ -544,13 +631,13 @@ export function JobLinesComponent({
} }
}); });
//Clear out the selected lines. IO-785
setSelectedLines([]); setSelectedLines([]);
}} }}
> >
{t("parts.actions.order")} {t("parts.actions.order")}
{selectedLines.length > 0 && ` (${selectedLines.length})`} {selectedLines.length > 0 && ` (${selectedLines.length})`}
</Button> </Button>
{!isPartsEntry && ( {!isPartsEntry && (
<Button <Button
id="job-lines-filter-parts-only-button" id="job-lines-filter-parts-only-button"
@@ -567,9 +654,11 @@ export function JobLinesComponent({
<FilterFilled /> {t("jobs.actions.filterpartsonly")} <FilterFilled /> {t("jobs.actions.filterpartsonly")}
</Button> </Button>
)} )}
<Dropdown menu={markMenu} trigger={["click"]}> <Dropdown menu={markMenu} trigger={["click"]}>
<Button id="repair-data-mark-button">{t("jobs.actions.mark")}</Button> <Button id="repair-data-mark-button">{t("jobs.actions.mark")}</Button>
</Dropdown> </Dropdown>
{!isPartsEntry && ( {!isPartsEntry && (
<Button <Button
disabled={jobRO || technician} disabled={jobRO || technician}
@@ -583,9 +672,12 @@ export function JobLinesComponent({
{t("joblines.actions.new")} {t("joblines.actions.new")}
</Button> </Button>
)} )}
{!isPartsEntry && {!isPartsEntry &&
InstanceRenderManager({ rome: <JobSendPartPriceChangeComponent job={job} disabled={technician} /> })} InstanceRenderManager({ rome: <JobSendPartPriceChangeComponent job={job} disabled={technician} /> })}
<JobCreateIOU job={job} selectedJobLines={selectedLines} /> <JobCreateIOU job={job} selectedJobLines={selectedLines} />
<Input.Search <Input.Search
placeholder={t("general.labels.search")} placeholder={t("general.labels.search")}
onChange={(e) => { onChange={(e) => {
@@ -596,6 +688,7 @@ export function JobLinesComponent({
</Space> </Space>
} }
/> />
<Table <Table
columns={columns} columns={columns}
rowKey="id" rowKey="id"
@@ -603,9 +696,7 @@ export function JobLinesComponent({
pagination={false} pagination={false}
dataSource={jobLines} dataSource={jobLines}
onChange={handleTableChange} onChange={handleTableChange}
scroll={{ scroll={{ x: true }}
x: true
}}
expandable={{ expandable={{
expandedRowRender: (record) => expandedRowRender: (record) =>
isPartsEntry ? ( isPartsEntry ? (
@@ -614,7 +705,6 @@ export function JobLinesComponent({
<JobLinesExpander jobline={record} jobid={job.id} /> <JobLinesExpander jobline={record} jobid={job.id} />
), ),
rowExpandable: () => true, rowExpandable: () => true,
//expandRowByClick: true,
expandIcon: ({ expanded, onExpand, record }) => expandIcon: ({ expanded, onExpand, record }) =>
expanded ? ( expanded ? (
<MinusCircleTwoTone onClick={(e) => onExpand(record, e)} /> <MinusCircleTwoTone onClick={(e) => onExpand(record, e)} />
@@ -627,17 +717,15 @@ export function JobLinesComponent({
/> />
) )
}} }}
onRow={(record) => { onRow={(record) => ({
return { onDoubleClick: () => {
onDoubleClick: () => { logImEXEvent("joblines_double_click_select", {});
logImEXEvent("joblines_double_click_select", {}); const notMatchingLines = selectedLines.filter((i) => i.id !== record.id);
const notMatchingLines = selectedLines.filter((i) => i.id !== record.id); notMatchingLines.length !== selectedLines.length
notMatchingLines.length !== selectedLines.length ? setSelectedLines(notMatchingLines)
? setSelectedLines(notMatchingLines) : setSelectedLines([...selectedLines, record]);
: setSelectedLines([...selectedLines, record]); }
} // double click row })}
};
}}
rowSelection={{ rowSelection={{
selectedRowKeys: selectedLines.map((item) => item && item.id), selectedRowKeys: selectedLines.map((item) => item && item.id),
onSelectAll: (selected, selectedRows) => { onSelectAll: (selected, selectedRows) => {

View File

@@ -1,25 +1,23 @@
import { useMutation } from "@apollo/client"; import { useMutation } from "@apollo/client";
import { Select, Space } from "antd"; import { Select, Space, Tag } from "antd";
import { useEffect, useState } from "react"; import { useEffect, useMemo, useState } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { connect } from "react-redux"; import { connect } from "react-redux";
import { createStructuredSelector } from "reselect"; import { createStructuredSelector } from "reselect";
import { UPDATE_JOB_LINE } from "../../graphql/jobs-lines.queries"; import { UPDATE_JOB_LINE } from "../../graphql/jobs-lines.queries";
import { selectBodyshop } from "../../redux/user/user.selectors"; import { selectBodyshop } from "../../redux/user/user.selectors";
import LoadingSpinner from "../loading-spinner/loading-spinner.component";
import { useNotification } from "../../contexts/Notifications/notificationContext.jsx"; import { useNotification } from "../../contexts/Notifications/notificationContext.jsx";
const mapStateToProps = createStructuredSelector({ const mapStateToProps = createStructuredSelector({
//currentUser: selectCurrentUser
bodyshop: selectBodyshop bodyshop: selectBodyshop
}); });
const mapDispatchToProps = () => ({ const mapDispatchToProps = () => ({});
//setUserLanguage: language => dispatch(setUserLanguage(language))
}); const CLEAR_VALUE = "__CLEAR_LOCATION__";
export function JobLineLocationPopup({ bodyshop, jobline, disabled }) { export function JobLineLocationPopup({ bodyshop, jobline, disabled }) {
const [editing, setEditing] = useState(false); const [editing, setEditing] = useState(false);
const [loading, setLoading] = useState(false); const [saving, setSaving] = useState(false);
const [location, setLocation] = useState(jobline.location); const [location, setLocation] = useState(jobline.location);
const [updateJob] = useMutation(UPDATE_JOB_LINE); const [updateJob] = useMutation(UPDATE_JOB_LINE);
const { t } = useTranslation(); const { t } = useTranslation();
@@ -29,55 +27,78 @@ export function JobLineLocationPopup({ bodyshop, jobline, disabled }) {
if (editing) setLocation(jobline.location); if (editing) setLocation(jobline.location);
}, [editing, jobline.location]); }, [editing, jobline.location]);
const handleChange = (e) => { const options = useMemo(() => {
setLocation(e); const locs = bodyshop?.md_parts_locations || [];
}; return [
{ label: t("general.labels.none", "No location"), value: CLEAR_VALUE },
...locs.map((loc) => ({ label: loc, value: loc }))
];
}, [bodyshop?.md_parts_locations, t]);
const handleSave = async () => { const saveLocation = async (nextLocation) => {
setLoading(true); setSaving(true);
const result = await updateJob({
variables: { lineId: jobline.id, line: { location: location || "" } }
});
if (!result.errors) { try {
notification["success"]({ message: t("joblines.successes.saved") }); const result = await updateJob({
} else { variables: { lineId: jobline.id, line: { location: nextLocation || "" } }
notification["error"]({
message: t("joblines.errors.saving", {
error: JSON.stringify(result.errors)
})
}); });
if (!result.errors) {
notification["success"]({ message: t("joblines.successes.saved") });
} else {
notification["error"]({
message: t("joblines.errors.saving", {
error: JSON.stringify(result.errors)
})
});
}
} catch (error) {
notification["error"]({
message: t("joblines.errors.saving", { error: error?.message || String(error) })
});
} finally {
setSaving(false);
setEditing(false);
} }
setLoading(false);
setEditing(false);
}; };
if (editing) const handleChange = async (value) => {
const next = value === CLEAR_VALUE ? null : value;
setLocation(next);
await saveLocation(next);
};
if (editing) {
return ( return (
<div> <div style={{ width: "100%", display: "flex", alignItems: "center" }}>
<LoadingSpinner loading={loading}> <Select
<Select autoFocus
autoFocus size="small"
allowClear value={location ?? undefined}
popupMatchSelectWidth={100} loading={saving}
value={location} disabled={saving}
onClear={() => setLocation(null)} style={{ flex: 1, minWidth: 0 }}
onSelect={handleChange} popupMatchSelectWidth={false}
onBlur={handleSave} getPopupContainer={(triggerNode) => triggerNode.parentNode}
> onChange={handleChange}
{bodyshop.md_parts_locations.map((loc, idx) => ( onBlur={() => !saving && setEditing(false)}
<Select.Option key={idx} value={loc}> options={options}
{loc} />
</Select.Option>
))}
</Select>
</LoadingSpinner>
</div> </div>
); );
}
return ( return (
<div style={{ width: "100%", minHeight: "2rem", cursor: "pointer" }} onClick={() => !disabled && setEditing(true)}> <div
style={{ width: "100%", minHeight: "2rem", cursor: disabled ? "default" : "pointer" }}
onClick={() => !disabled && setEditing(true)}
>
<Space wrap> <Space wrap>
{jobline.location} {jobline.location ? (
<Tag>{jobline.location}</Tag>
) : (
<span style={{ opacity: 0.6 }}>{t("general.labels.none")}</span>
)}
{jobline.parts_dispatch_lines?.length > 0 && "-Disp"} {jobline.parts_dispatch_lines?.length > 0 && "-Disp"}
</Space> </Space>
</div> </div>

View File

@@ -609,7 +609,7 @@ export function JobsDetailHeaderActions({
<FormDateTimePickerComponent <FormDateTimePickerComponent
onBlur={() => { onBlur={() => {
const start = form.getFieldValue("start"); const start = form.getFieldValue("start");
form.setFieldsValue({ end: start.add(30, "minutes") }); form.setFieldsValue({ end: start?.add(30, "minutes") });
}} }}
/> />
</Form.Item> </Form.Item>

View File

@@ -144,7 +144,7 @@ export function ProductionListEmpAssignment({ insertAuditTrail, bodyshop, record
<Spin spinning={loading}> <Spin spinning={loading}>
{record[type] ? ( {record[type] ? (
<div> <div>
<span>{`${theEmployee.first_name || ""} ${theEmployee.last_name || ""}`}</span> <span>{`${theEmployee?.first_name || ""} ${theEmployee?.last_name || ""}`}</span>
<DeleteFilled style={iconStyle} onClick={() => handleRemove(type)} /> <DeleteFilled style={iconStyle} onClick={() => handleRemove(type)} />
</div> </div>
) : ( ) : (

View File

@@ -143,7 +143,7 @@ export function ReportCenterModalComponent({ reportCenterModal, bodyshop }) {
//TODO: Find a way to filter out / blur on demand. //TODO: Find a way to filter out / blur on demand.
return ( return (
<div> <div className="report-center-modal">
<Form onFinish={handleFinish} autoComplete={"off"} layout="vertical" form={form}> <Form onFinish={handleFinish} autoComplete={"off"} layout="vertical" form={form}>
<Input.Search onChange={(e) => setSearch(e.target.value)} value={search} /> <Input.Search onChange={(e) => setSearch(e.target.value)} value={search} />
<Form.Item name="defaultSorters" hidden /> <Form.Item name="defaultSorters" hidden />
@@ -163,13 +163,14 @@ export function ReportCenterModalComponent({ reportCenterModal, bodyshop }) {
{Object.keys(grouped) {Object.keys(grouped)
//.filter((key) => !groupExcludeKeyFilter.includes(key)) //.filter((key) => !groupExcludeKeyFilter.includes(key))
.map((key) => ( .map((key) => (
<Col md={8} sm={12} key={key}> <Col xs={24} sm={12} md={Object.keys(grouped).length === 1 ? 24 : 8} key={key}>
<Card.Grid <Card.Grid
style={{ style={{
width: "100%", width: "100%",
height: "100%", height: "100%",
maxHeight: "33vh", maxHeight: "33vh",
overflowY: "scroll" overflowY: "scroll",
minWidth: "200px"
}} }}
> >
<Typography.Title level={4}>{t(`reportcenter.labels.groups.${key}`)}</Typography.Title> <Typography.Title level={4}>{t(`reportcenter.labels.groups.${key}`)}</Typography.Title>
@@ -177,7 +178,7 @@ export function ReportCenterModalComponent({ reportCenterModal, bodyshop }) {
<BlurWrapperComponent <BlurWrapperComponent
featureName={groupExcludeKeyFilter.find((g) => g.key === key).featureName} featureName={groupExcludeKeyFilter.find((g) => g.key === key).featureName}
> >
<ul style={{ listStyleType: "none", columns: "2 auto" }}> <ul style={{ listStyleType: "none", columns: grouped[key].length > 4 ? "2 auto" : "1", padding: 0, margin: 0 }}>
{grouped[key].map((item) => ( {grouped[key].map((item) => (
<li key={item.key}> <li key={item.key}>
<Radio key={item.key} value={item.key}> <Radio key={item.key} value={item.key}>
@@ -188,7 +189,7 @@ export function ReportCenterModalComponent({ reportCenterModal, bodyshop }) {
</ul> </ul>
</BlurWrapperComponent> </BlurWrapperComponent>
) : ( ) : (
<ul style={{ listStyleType: "none", columns: "2 auto" }}> <ul style={{ listStyleType: "none", columns: grouped[key].length > 4 ? "2 auto" : "1", padding: 0, margin: 0 }}>
{grouped[key].map((item) => {grouped[key].map((item) =>
item.featureNameRestricted ? ( item.featureNameRestricted ? (
<li key={item.key}> <li key={item.key}>

View File

@@ -11,3 +11,38 @@
} }
} }
} }
// Report center modal fixes for column layout
.report-center-modal {
.ant-form-item .ant-radio-group {
width: 100%;
.ant-card-grid {
padding: 16px;
box-sizing: border-box;
ul {
width: 100%;
li {
margin-bottom: 8px;
break-inside: avoid;
page-break-inside: avoid;
.ant-radio-wrapper {
display: flex;
align-items: flex-start;
width: 100%;
span:not(.ant-radio) {
word-break: break-word;
overflow-wrap: break-word;
hyphens: auto;
flex: 1;
}
}
}
}
}
}
}

View File

@@ -5,7 +5,7 @@ import { getFirestore } from "@firebase/firestore";
import { getMessaging, getToken, onMessage } from "@firebase/messaging"; import { getMessaging, getToken, onMessage } from "@firebase/messaging";
import { store } from "../redux/store"; import { store } from "../redux/store";
//import * as amplitude from '@amplitude/analytics-browser'; //import * as amplitude from '@amplitude/analytics-browser';
import posthog from 'posthog-js' // import posthog from 'posthog-js'
const config = JSON.parse(import.meta.env.VITE_APP_FIREBASE_CONFIG); const config = JSON.parse(import.meta.env.VITE_APP_FIREBASE_CONFIG);
initializeApp(config); initializeApp(config);
@@ -74,7 +74,6 @@ onMessage(messaging, (payload) => {
export const logImEXEvent = (eventName, additionalParams, stateProp = null) => { export const logImEXEvent = (eventName, additionalParams, stateProp = null) => {
try { try {
const state = stateProp || store.getState(); const state = stateProp || store.getState();
const eventParams = { const eventParams = {
@@ -99,8 +98,7 @@ export const logImEXEvent = (eventName, additionalParams, stateProp = null) => {
// ); // );
logEvent(analytics, eventName, eventParams); logEvent(analytics, eventName, eventParams);
//amplitude.track(eventName, eventParams); //amplitude.track(eventName, eventParams);
posthog.capture(eventName, eventParams); //posthog.capture(eventName, eventParams);
} finally { } finally {
//If it fails, just keep going. //If it fails, just keep going.
} }

View File

@@ -1270,6 +1270,7 @@
"vehicle": "Vehicle" "vehicle": "Vehicle"
}, },
"labels": { "labels": {
"selected": "Selected",
"settings": "Settings", "settings": "Settings",
"actions": "Actions", "actions": "Actions",
"areyousure": "Are you sure?", "areyousure": "Are you sure?",
@@ -1491,7 +1492,8 @@
"assign_team": "Assign Team", "assign_team": "Assign Team",
"converttolabor": "Convert amount to Labor.", "converttolabor": "Convert amount to Labor.",
"dispatchparts": "Dispatch Parts ({{count}})", "dispatchparts": "Dispatch Parts ({{count}})",
"new": "New Line" "new": "New Line",
"updatelocation": "Update Location"
}, },
"errors": { "errors": {
"creating": "Error encountered while creating job line. {{message}}", "creating": "Error encountered while creating job line. {{message}}",
@@ -1572,7 +1574,8 @@
"ioucreated": "IOU", "ioucreated": "IOU",
"new": "New Line", "new": "New Line",
"nostatus": "No Status", "nostatus": "No Status",
"presets": "Jobline Presets" "presets": "Jobline Presets",
"bulk_location_help": "This will set the same location on all selected lines."
}, },
"successes": { "successes": {
"created": "Job line created successfully.", "created": "Job line created successfully.",

View File

@@ -1270,6 +1270,7 @@
"vehicle": "" "vehicle": ""
}, },
"labels": { "labels": {
"selected": "",
"actions": "Comportamiento", "actions": "Comportamiento",
"settings": "", "settings": "",
"areyousure": "", "areyousure": "",
@@ -1491,7 +1492,8 @@
"assign_team": "", "assign_team": "",
"converttolabor": "", "converttolabor": "",
"dispatchparts": "", "dispatchparts": "",
"new": "" "new": "",
"updatelocation": ""
}, },
"errors": { "errors": {
"creating": "", "creating": "",
@@ -1572,7 +1574,8 @@
"ioucreated": "", "ioucreated": "",
"new": "Nueva línea", "new": "Nueva línea",
"nostatus": "", "nostatus": "",
"presets": "" "presets": "",
"bulk_location_help": ""
}, },
"successes": { "successes": {
"created": "", "created": "",

View File

@@ -1270,6 +1270,7 @@
"vehicle": "" "vehicle": ""
}, },
"labels": { "labels": {
"selected": "",
"settings": "", "settings": "",
"actions": "actes", "actions": "actes",
"areyousure": "", "areyousure": "",
@@ -1491,7 +1492,8 @@
"assign_team": "", "assign_team": "",
"converttolabor": "", "converttolabor": "",
"dispatchparts": "", "dispatchparts": "",
"new": "" "new": "",
"updatelocation": ""
}, },
"errors": { "errors": {
"creating": "", "creating": "",
@@ -1572,7 +1574,8 @@
"ioucreated": "", "ioucreated": "",
"new": "Nouvelle ligne", "new": "Nouvelle ligne",
"nostatus": "", "nostatus": "",
"presets": "" "presets": "",
"bulk_location_help": ""
}, },
"successes": { "successes": {
"created": "", "created": "",

View File

@@ -31,7 +31,8 @@ if (!import.meta.env.DEV) {
"Module specifier, 'fs' does not start", "Module specifier, 'fs' does not start",
"Module specifier, 'zlib' does not start with", "Module specifier, 'zlib' does not start with",
"Messaging: This browser doesn't support the API's required to use the Firebase SDK.", "Messaging: This browser doesn't support the API's required to use the Firebase SDK.",
"Failed to update a ServiceWorker for scope" "Failed to update a ServiceWorker for scope",
"Network Error"
], ],
integrations: [ integrations: [
// See docs for support of different versions of variation of react router // See docs for support of different versions of variation of react router

View File

@@ -24,11 +24,13 @@ const lightningCssTargets = browserslistToTargets(
}) })
); );
const currentDatePST = new Date() const pstFormatter = new Intl.DateTimeFormat("en-CA", {
.toLocaleDateString("en-US", { timeZone: "America/Los_Angeles", year: "numeric", month: "2-digit", day: "2-digit" }) timeZone: "America/Los_Angeles",
.split("/") year: "numeric",
.reverse() month: "2-digit",
.join("-"); day: "2-digit"
});
const currentDatePST = pstFormatter.format(new Date());
const getFormattedTimestamp = () => const getFormattedTimestamp = () =>
new Date().toLocaleTimeString("en-US", { hour12: true }).replace("AM", "a.m.").replace("PM", "p.m."); new Date().toLocaleTimeString("en-US", { hour12: true }).replace("AM", "a.m.").replace("PM", "p.m.");

View File

@@ -0,0 +1,4 @@
-- Could not auto-generate a down migration.
-- Please write an appropriate down migration for the SQL below:
-- alter table "public"."jobs" add column "dms_id" text
-- null;

View File

@@ -0,0 +1,2 @@
alter table "public"."jobs" add column "dms_id" text
null;

View File

@@ -77,9 +77,8 @@ const generateResetLink = async (email) => {
*/ */
const ensureExternalIdUnique = async (externalId) => { const ensureExternalIdUnique = async (externalId) => {
const resp = await client.request(CHECK_EXTERNAL_SHOP_ID, { key: externalId }); const resp = await client.request(CHECK_EXTERNAL_SHOP_ID, { key: externalId });
if (resp.bodyshops.length) {
throw { status: 400, message: `external_shop_id '${externalId}' is already in use.` }; return !!resp.bodyshops.length;
}
}; };
/** /**
@@ -225,10 +224,25 @@ const patchPartsManagementProvisioning = async (req, res) => {
*/ */
const partsManagementProvisioning = async (req, res) => { const partsManagementProvisioning = async (req, res) => {
const { logger } = req; const { logger } = req;
const body = { ...req.body, userEmail: req.body.userEmail?.toLowerCase() };
// Trim and normalize email early
const body = {
...req.body,
userEmail: req.body.userEmail?.trim().toLowerCase()
};
const trim = (value) => (typeof value === "string" ? value.trim() : value);
const trimIfString = (value) =>
value !== null && value !== undefined && typeof value === "string" ? value.trim() : value;
try { try {
// Ensure email is present and trimmed before checking registration
if (!body.userEmail) {
throw { status: 400, message: "userEmail is required" };
}
await ensureEmailNotRegistered(body.userEmail); await ensureEmailNotRegistered(body.userEmail);
requireFields(body, [ requireFields(body, [
"external_shop_id", "external_shop_id",
"shopname", "shopname",
@@ -242,28 +256,68 @@ const partsManagementProvisioning = async (req, res) => {
"userEmail" "userEmail"
]); ]);
// TODO add in check for early access // Trim all top-level string fields
await ensureExternalIdUnique(body.external_shop_id); const trimmedBody = {
...body,
external_shop_id: trim(body.external_shop_id),
shopname: trim(body.shopname),
address1: trim(body.address1),
address2: trimIfString(body.address2),
city: trim(body.city),
state: trim(body.state),
zip_post: trim(body.zip_post),
country: trim(body.country),
email: trim(body.email),
phone: trim(body.phone),
timezone: trimIfString(body.timezone),
logoUrl: trimIfString(body.logoUrl),
userPassword: body.userPassword, // passwords should NOT be trimmed (preserves intentional spaces if any, though rare)
vendors: Array.isArray(body.vendors)
? body.vendors.map((v) => ({
name: trim(v.name),
street1: trimIfString(v.street1),
street2: trimIfString(v.street2),
city: trimIfString(v.city),
state: trimIfString(v.state),
zip: trimIfString(v.zip),
country: trimIfString(v.country),
email: trimIfString(v.email),
cost_center: trimIfString(v.cost_center),
phone: trimIfString(v.phone),
dmsid: trimIfString(v.dmsid),
discount: v.discount ?? 0,
due_date: v.due_date ?? null,
favorite: v.favorite ?? [],
active: v.active ?? true
}))
: []
};
logger.log("admin-create-shop-user", "debug", body.userEmail, null, { const duplicateCheck = await ensureExternalIdUnique(trimmedBody.external_shop_id);
if (duplicateCheck) {
throw { status: 400, message: `external_shop_id '${trimmedBody.external_shop_id}' is already in use.` };
}
logger.log("admin-create-shop-user", "debug", trimmedBody.userEmail, null, {
request: req.body, request: req.body,
ioadmin: true ioadmin: true
}); });
const shopInput = { const shopInput = {
shopname: body.shopname, shopname: trimmedBody.shopname,
address1: body.address1, address1: trimmedBody.address1,
address2: body.address2 || null, address2: trimmedBody.address2,
city: body.city, city: trimmedBody.city,
state: body.state, state: trimmedBody.state,
zip_post: body.zip_post, zip_post: trimmedBody.zip_post,
country: body.country, country: trimmedBody.country,
email: body.email, email: trimmedBody.email,
external_shop_id: body.external_shop_id, external_shop_id: trimmedBody.external_shop_id,
timezone: body.timezone || DefaultNewShop.timezone, timezone: trimmedBody.timezone || DefaultNewShop.timezone,
phone: body.phone, phone: trimmedBody.phone,
logo_img_path: { logo_img_path: {
src: body.logoUrl, src: trimmedBody.logoUrl || null, // allow empty logo
width: "", width: "",
height: "", height: "",
headerMargin: DefaultNewShop.logo_img_path.headerMargin headerMargin: DefaultNewShop.logo_img_path.headerMargin
@@ -288,35 +342,37 @@ const partsManagementProvisioning = async (req, res) => {
appt_alt_transport: DefaultNewShop.appt_alt_transport, appt_alt_transport: DefaultNewShop.appt_alt_transport,
md_jobline_presets: DefaultNewShop.md_jobline_presets, md_jobline_presets: DefaultNewShop.md_jobline_presets,
vendors: { vendors: {
data: body.vendors.map((v) => ({ data: trimmedBody.vendors.map((v) => ({
name: v.name, name: v.name,
street1: v.street1 || null, street1: v.street1,
street2: v.street2 || null, street2: v.street2,
city: v.city || null, city: v.city,
state: v.state || null, state: v.state,
zip: v.zip || null, zip: v.zip,
country: v.country || null, country: v.country,
email: v.email || null, email: v.email,
discount: v.discount ?? 0, discount: v.discount,
due_date: v.due_date ?? null, due_date: v.due_date,
cost_center: v.cost_center || null, cost_center: v.cost_center,
favorite: v.favorite ?? [], favorite: v.favorite,
phone: v.phone || null, phone: v.phone,
active: v.active ?? true, active: v.active,
dmsid: v.dmsid || null dmsid: v.dmsid
})) }))
} }
}; };
const newShopId = await insertBodyshop(shopInput); const newShopId = await insertBodyshop(shopInput);
const userRecord = await createFirebaseUser(body.userEmail, body.userPassword); const userRecord = await createFirebaseUser(trimmedBody.userEmail, trimmedBody.userPassword);
let resetLink = null; let resetLink = null;
if (!body.userPassword) resetLink = await generateResetLink(body.userEmail); if (!trimmedBody.userPassword) {
resetLink = await generateResetLink(trimmedBody.userEmail);
}
const createdUser = await insertUserAssociation(userRecord.uid, body.userEmail, newShopId); const createdUser = await insertUserAssociation(userRecord.uid, trimmedBody.userEmail, newShopId);
return res.status(200).json({ return res.status(200).json({
shop: { id: newShopId, shopname: body.shopname }, shop: { id: newShopId, shopname: trimmedBody.shopname },
user: { user: {
id: createdUser.id, id: createdUser.id,
email: createdUser.email, email: createdUser.email,
@@ -324,7 +380,7 @@ const partsManagementProvisioning = async (req, res) => {
} }
}); });
} catch (err) { } catch (err) {
logger.log("admin-create-shop-user-error", "error", body.userEmail, null, { logger.log("admin-create-shop-user-error", "error", body.userEmail || "unknown", null, {
message: err.message, message: err.message,
detail: err.detail || err detail: err.detail || err
}); });