Fortellis logic deduplication

server/fortellis/fortellis.js

@@ -189,7 +189,17 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
     let DMSCust;
     if (selectedCustomerId) {
       CreateFortellisLogEvent(socket, "DEBUG", `{3.1} Querying the Customer using Customer ID: ${selectedCustomerId}`);
-      DMSCust = await QueryDmsCustomerById({ socket, redisHelpers, JobData, CustomerId: selectedCustomerId }); //TODO: Optimize here - if selected ID, we already have the customer information. Prevent an extra call to Fortellis.
+
+      //Get cust list from Redis. Return the item
+      const DMSCustList = await getSessionTransactionData(
+        socket.id,
+        getTransactionType(jobid),
+        FortellisCacheEnums.DMSCustList
+      );
+      const existingCustomerInDMSCustList = DMSCustList.find((c) => c.customerId === selectedCustomerId);
+      DMSCust = existingCustomerInDMSCustList || {
+        customerId: selectedCustomerId //This is the fall back in case it is the generic customer. 
+      };
       await setSessionTransactionData(
         socket.id,
         getTransactionType(jobid),
@@ -197,6 +207,8 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
         DMSCust,
         defaultFortellisTTL
       );
+
+
     } else {
       CreateFortellisLogEvent(socket, "DEBUG", `{3.2} Creating new customer.`);
       const DMSCustomerInsertResponse = await InsertDmsCustomer({ socket, redisHelpers, JobData });
@@ -215,26 +227,32 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
       CreateFortellisLogEvent(socket, "DEBUG", `{4.1} Inserting new vehicle with ID: ID ${DMSVid.vehiclesVehId}`);
       DMSVeh = await InsertDmsVehicle({ socket, redisHelpers, JobData, txEnvelope, DMSVid, DMSCust });
     } else {
-      CreateFortellisLogEvent(socket, "DEBUG", `{4.2} Querying Existing Vehicle using ID ${DMSVid.vehiclesVehId}`);
-      DMSVeh = await QueryDmsVehicleById({ socket, redisHelpers, JobData, DMSVid });
-
-      CreateFortellisLogEvent(socket, "DEBUG", `{4.3} Updating Existing Vehicle to associate to owner.`);
-      DMSVeh = await UpdateDmsVehicle({
-        socket,
-        redisHelpers,
-        JobData,
-        DMSVeh,
-        DMSCust,
-        selectedCustomerId,
-        txEnvelope
-      });
-      await setSessionTransactionData(
+      DMSVeh = await getSessionTransactionData(
         socket.id,
         getTransactionType(jobid),
-        FortellisCacheEnums.DMSVeh,
-        DMSVeh,
-        defaultFortellisTTL
-      ); //TODO: This should be immutable probably.F
+        FortellisCacheEnums.DMSVeh
+      )
+      CreateFortellisLogEvent(socket, "DEBUG", `{4.3} Updating Existing Vehicle to associate to owner.`);
+
+      //Check to see if the vehicle needs to be updated - i.e. the owner is not the selected customer. 
+      if (!DMSVeh?.owners.find((o) => o.id.value === DMSCust.customerId && o.id.assigningPartyId === "CURRENT")) {
+        DMSVeh = await UpdateDmsVehicle({
+          socket,
+          redisHelpers,
+          JobData,
+          DMSVeh,
+          DMSCust,
+          selectedCustomerId,
+          txEnvelope
+        });
+        await setSessionTransactionData(
+          socket.id,
+          getTransactionType(jobid),
+          FortellisCacheEnums.DMSVeh,
+          DMSVeh,
+          defaultFortellisTTL
+        );
+      }
     }
     // const DMSVehHistory = await InsertServiceVehicleHistory({ socket, redisHelpers, JobData });
     // await setSessionTransactionData(socket.id, getTransactionType(jobid), FortellisCacheEnums.DMSVehHistory, DMSVehHistory, defaultFortellisTTL);
@@ -293,7 +311,6 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
         // //Get the error code
         CreateFortellisLogEvent(socket, "DEBUG", `{6.1} Getting errors for Transaction ID ${DMSTransHeader.transID}`);
 
-        await QueryDmsErrWip({ socket, redisHelpers, JobData });
 
         const DmsError = await QueryDmsErrWip({ socket, redisHelpers, JobData });
         //   //Delete the transaction
@@ -301,7 +318,7 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
 
         await DeleteDmsWip({ socket, redisHelpers, JobData });
 
-        DmsError.errLine.map(
+        DmsError.errMsg.map(
           (e) =>
             e !== null &&
             e !== "" &&
@@ -310,7 +327,7 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
         await InsertFailedExportLog({
           socket,
           JobData,
-          error: DmsError.errLine
+          error: DmsError.errMsg
         });
       }
     }
@@ -1027,7 +1044,6 @@ async function InsertDmsStartWip({ socket, redisHelpers, JobData }) {
         // userID: "partprgm",
         // userName: "PROGRAM, PARTNER"
       },
-      //overrideDepartmentId: "D100152198" //TODO: REMOVE AFTER TESTING
     });
     return result;
   } catch (error) {