diff --git a/server/accounting/qbxml/qbxml-payments.js b/server/accounting/qbxml/qbxml-payments.js index ec429aa86..7820f9a7e 100644 --- a/server/accounting/qbxml/qbxml-payments.js +++ b/server/accounting/qbxml/qbxml-payments.js @@ -111,18 +111,18 @@ const generatePayment = (payment, isThreeTier, twoTierPref) => { ReceivePaymentAddRq: { ReceivePaymentAdd: { CustomerRef: { - FullName: - payment.job.bodyshop.accountingconfig.tiers === 3 - ? `${generateSourceTier(payment.job)}:${generateOwnerTier( - payment.job, - isThreeTier, - twoTierPref - )}:${generateJobTier(payment.job)}` - : `${generateOwnerTier( - payment.job, - isThreeTier, - twoTierPref - )}:${generateJobTier(payment.job)}`, + FullName: (payment.job.bodyshop.accountingconfig.tiers === 3 + ? `${generateSourceTier(payment.job)}:${generateOwnerTier( + payment.job, + isThreeTier, + twoTierPref + )}:${generateJobTier(payment.job)}` + : `${generateOwnerTier( + payment.job, + isThreeTier, + twoTierPref + )}:${generateJobTier(payment.job)}` + ).trim(), }, ARAccountRef: { FullName: @@ -155,18 +155,18 @@ const generatePayment = (payment, isThreeTier, twoTierPref) => { CreditMemoAddRq: { CreditMemoAdd: { CustomerRef: { - FullName: - payment.job.bodyshop.accountingconfig.tiers === 3 - ? `${generateSourceTier(payment.job)}:${generateOwnerTier( - payment.job, - isThreeTier, - twoTierPref - )}:${generateJobTier(payment.job)}` - : `${generateOwnerTier( - payment.job, - isThreeTier, - twoTierPref - )}:${generateJobTier(payment.job)}`, + FullName: (payment.job.bodyshop.accountingconfig.tiers === 3 + ? `${generateSourceTier(payment.job)}:${generateOwnerTier( + payment.job, + isThreeTier, + twoTierPref + )}:${generateJobTier(payment.job)}` + : `${generateOwnerTier( + payment.job, + isThreeTier, + twoTierPref + )}:${generateJobTier(payment.job)}` + ).trim(), }, ARAccountRef: { FullName: diff --git a/server/accounting/qbxml/qbxml-receivables.js b/server/accounting/qbxml/qbxml-receivables.js index c683f45a9..3150a0349 100644 --- a/server/accounting/qbxml/qbxml-receivables.js +++ b/server/accounting/qbxml/qbxml-receivables.js @@ -122,7 +122,7 @@ const generateSourceCustomerQbxml = (jobs_by_pk, bodyshop) => { "@onError": "continueOnError", CustomerAddRq: { CustomerAdd: { - Name: jobs_by_pk.ins_co_nm, + Name: jobs_by_pk.ins_co_nm.trim(), // BillAddress: { // Addr1: jobs_by_pk.ownr_addr1, // Addr2: jobs_by_pk.ownr_addr2, @@ -238,16 +238,16 @@ const generateInvoiceQbxml = ( InvoiceAddRq: { InvoiceAdd: { CustomerRef: { - FullName: - bodyshop.accountingconfig.tiers === 3 - ? `${generateSourceTier(jobs_by_pk)}:${generateOwnerTier( - jobs_by_pk - )}:${generateJobTier(jobs_by_pk)}` - : `${generateOwnerTier( - jobs_by_pk, - isThreeTier, - twoTierPref - )}:${generateJobTier(jobs_by_pk)}`, + FullName: (bodyshop.accountingconfig.tiers === 3 + ? `${generateSourceTier(jobs_by_pk)}:${generateOwnerTier( + jobs_by_pk + )}:${generateJobTier(jobs_by_pk)}` + : `${generateOwnerTier( + jobs_by_pk, + isThreeTier, + twoTierPref + )}:${generateJobTier(jobs_by_pk)}` + ).trim(), }, ...(jobs_by_pk.class diff --git a/server/accounting/qbxml/qbxml-utils.js b/server/accounting/qbxml/qbxml-utils.js index b012c9baf..3cee63ca8 100644 --- a/server/accounting/qbxml/qbxml-utils.js +++ b/server/accounting/qbxml/qbxml-utils.js @@ -6,24 +6,25 @@ exports.addQbxmlHeader = addQbxmlHeader = (xml) => { }; exports.generateSourceTier = (jobs_by_pk) => { - return jobs_by_pk.ins_co_nm; + return jobs_by_pk.ins_co_nm && jobs_by_pk.ins_co_nm.trim(); }; exports.generateJobTier = (jobs_by_pk) => { - return jobs_by_pk.ro_number; + return jobs_by_pk.ro_number && jobs_by_pk.ro_number.trim(); }; exports.generateOwnerTier = (jobs_by_pk, isThreeTier, twotierpref) => { if (isThreeTier) { //It's always gonna be the owner now. Same as 2 tier by name - return jobs_by_pk.ownr_co_nm - ? `${jobs_by_pk.ownr_co_nm.substring(0, 30)} #${ - jobs_by_pk.owner.accountingid || "" - }` - : `${`${jobs_by_pk.ownr_ln || ""} ${jobs_by_pk.ownr_fn || ""}`.substring( - 0, - 30 - )} #${jobs_by_pk.owner.accountingid || ""}`; + return ( + jobs_by_pk.ownr_co_nm + ? `${jobs_by_pk.ownr_co_nm.substring(0, 30)} #${ + jobs_by_pk.owner.accountingid || "" + }` + : `${`${jobs_by_pk.ownr_ln || ""} ${ + jobs_by_pk.ownr_fn || "" + }`.substring(0, 30)} #${jobs_by_pk.owner.accountingid || ""}` + ).trim(); } else { //What's the 2 tier pref? if (twotierpref === "source") { @@ -31,13 +32,15 @@ exports.generateOwnerTier = (jobs_by_pk, isThreeTier, twotierpref) => { //It should be the insurance co. } else { //Same as 3 tier - return jobs_by_pk.ownr_co_nm - ? `${jobs_by_pk.ownr_co_nm.substring(0, 30)} #${ - jobs_by_pk.owner.accountingid || "" - }` - : `${`${jobs_by_pk.ownr_ln || ""} ${ - jobs_by_pk.ownr_fn || "" - }`.substring(0, 30)} #${jobs_by_pk.owner.accountingid || ""}`; + return ( + jobs_by_pk.ownr_co_nm + ? `${jobs_by_pk.ownr_co_nm.substring(0, 30)} #${ + jobs_by_pk.owner.accountingid || "" + }` + : `${`${jobs_by_pk.ownr_ln || ""} ${ + jobs_by_pk.ownr_fn || "" + }`.substring(0, 30)} #${jobs_by_pk.owner.accountingid || ""}` + ).trim(); } } };