admin/bodyshop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feature/IO-3255-simplified-parts-management - Checkpoint

Browse Source
This commit is contained in:
Dave
2025-08-28 14:24:35 -04:00
parent 67002b8443
commit f071a5cc9e
6 changed files with 173 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

219
server/integrations/partsManagement/endpoints/vehicleDamageEstimateAddRq.js
View File

@@ -14,7 +14,7 @@ const {
} = require("../partsManagement.queries");
// Defaults
const FALLBACK_DEFAULT_ORDER_STATUS = "Open";
const FALLBACK_DEFAULT_JOB_STATUS = "Open";
/**
* Fetches the default order status for a bodyshop.
@@ -22,13 +22,13 @@ const FALLBACK_DEFAULT_ORDER_STATUS = "Open";
* @param {object} logger - The logger instance.
* @returns {Promise<string>} The default status or fallback.
*/
const getDefaultOrderStatus = async (shopId, logger) => {
const getDefaultJobStatus = async (shopId, logger) => {
try {
const { bodyshop_by_pk } = await client.request(GET_BODYSHOP_STATUS, { id: shopId });
return bodyshop_by_pk?.md_order_statuses?.default_open || FALLBACK_DEFAULT_ORDER_STATUS; //I think this is intended to be called job status, not order status.
return bodyshop_by_pk?.md_ro_statuses?.default_imported || FALLBACK_DEFAULT_JOB_STATUS;
} catch (err) {
logger.log("parts-bodyshop-fetch-failed", "warn", shopId, null, { error: err });
return FALLBACK_DEFAULT_ORDER_STATUS;
return FALLBACK_DEFAULT_JOB_STATUS;
}
};
/**
@@ -66,6 +66,7 @@ const extractJobData = (rq) => {
return {
shopId: rq.ShopID || rq.shopId,
// status: ci.ClaimStatus || null, Proper, setting it default for now
refClaimNum: rq.RefClaimNum,
ciecaid: rq.RqUID || null,
// Pull Cieca_ttl from ClaimInfo per schema/sample
@@ -81,8 +82,6 @@ const extractJobData = (rq) => {
scheduled_in: ev.RepairEvent?.RequestedPickUpDateTime || null,
scheduled_completion: ev.RepairEvent?.TargetCompletionDateTime || null,
clm_no: ci.ClaimNum || null,
// status: ci.ClaimStatus || null, Proper, setting it default for now
status: FALLBACK_DEFAULT_ORDER_STATUS,
policy_no: ci.PolicyInfo?.PolicyInfo?.PolicyNum || ci.PolicyInfo?.PolicyNum || null,
ded_amt: parseFloat(ci.PolicyInfo?.CoverageInfo?.Coverage?.DeductibleInfo?.DeductibleAmt || 0)
};
@@ -101,17 +100,19 @@ const extractOwnerData = (rq, shopId) => {
const personName = personInfo.PersonName || {};
const address = personInfo.Communications?.Address || {};
let ownr_ph1, ownr_ph2, ownr_ea, ownr_alt_ph;
let ownr_ph1, ownr_ph2, ownr_ea;
const comms = Array.isArray(ownerOrClaimant.ContactInfo?.Communications)
? ownerOrClaimant.ContactInfo.Communications
: [ownerOrClaimant.ContactInfo?.Communications || {}];
for (const c of comms) {
if (c.CommQualifier === "CP") ownr_ph1 = c.CommPhone; //PF: Should document this logic. 1 and 2 don't typically indicate type in EMS. This makes sense, but good to document.
// TODO: Should document this logic. 1 and 2 don't
// typically indicate type in EMS. This makes sense, but good to document.
if (c.CommQualifier === "CP") ownr_ph1 = c.CommPhone;
if (c.CommQualifier === "WP") ownr_ph2 = c.CommPhone;
if (c.CommQualifier === "EM") ownr_ea = c.CommEmail;
if (c.CommQualifier === "AL") ownr_alt_ph = c.CommPhone;
// if (c.CommQualifier === "AL") ownr_alt_ph = c.CommPhone;
}
return {
@@ -127,8 +128,8 @@ const extractOwnerData = (rq, shopId) => {
ownr_ctry: address.Country || null,
ownr_ph1,
ownr_ph2,
ownr_ea,
ownr_alt_ph //PF: This is not in the DB, if this object is inserted in place, this will fail.
ownr_ea
// ownr_alt_ph
// ownr_id_qualifier: ownerOrClaimant.IDInfo?.IDQualifierCode || null // New
// ownr_id_num: ownerOrClaimant.IDInfo?.IDNum || null, // New
// ownr_preferred_contact: ownerOrClaimant.PreferredContactMethod || null // New
@@ -159,38 +160,40 @@ const extractEstimatorData = (rq) => {
* @param {object} rq - The VehicleDamageEstimateAddRq object.
* @returns {object} Adjuster data.
*/
const extractAdjusterData = (rq) => {
const adjParty = rq.AdminInfo?.Adjuster?.Party || {};
const adjComms = Array.isArray(adjParty.ContactInfo?.Communications)
? adjParty.ContactInfo.Communications
: [adjParty.ContactInfo?.Communications || {}];
return {
agt_ct_fn: adjParty.PersonInfo?.PersonName?.FirstName || null, //PF: I dont think we display agt_ct_* fields in app. Have they typically been sending data here?
agt_ct_ln: adjParty.PersonInfo?.PersonName?.LastName || null,
agt_ct_ph: adjComms.find((c) => c.CommQualifier === "CP")?.CommPhone || null,
agt_ea: adjComms.find((c) => c.CommQualifier === "EM")?.CommEmail || null
};
};
// const extractAdjusterData = (rq) => {
// const adjParty = rq.AdminInfo?.Adjuster?.Party || {};
// const adjComms = Array.isArray(adjParty.ContactInfo?.Communications)
// ? adjParty.ContactInfo.Communications
// : [adjParty.ContactInfo?.Communications || {}];
//
// return {
// //TODO: I dont think we display agt_ct_* fields in app. Have they typically been sending data here?
// agt_ct_fn: adjParty.PersonInfo?.PersonName?.FirstName || null,
// agt_ct_ln: adjParty.PersonInfo?.PersonName?.LastName || null,
// agt_ct_ph: adjComms.find((c) => c.CommQualifier === "CP")?.CommPhone || null,
// agt_ea: adjComms.find((c) => c.CommQualifier === "EM")?.CommEmail || null
// };
// };
/**
* Extracts repair facility data from the XML request.
* @param {object} rq - The VehicleDamageEstimateAddRq object.
* @returns {object} Repair facility data.
*/
const extractRepairFacilityData = (rq) => {
const rfParty = rq.AdminInfo?.RepairFacility?.Party || {};
const rfComms = Array.isArray(rfParty.ContactInfo?.Communications)
? rfParty.ContactInfo.Communications
: [rfParty.ContactInfo?.Communications || {}];
return {
servicing_dealer: rfParty.OrgInfo?.CompanyName || null, //PF: The servicing dealer fields are a relic from synergy for a few folks
//PF: I suspect RF data could be ignored since they are the RF.
servicing_dealer_contact:
rfComms.find((c) => c.CommQualifier === "WP" || c.CommQualifier === "FX")?.CommPhone || null
};
};
// const extractRepairFacilityData = (rq) => {
// const rfParty = rq.AdminInfo?.RepairFacility?.Party || {};
// const rfComms = Array.isArray(rfParty.ContactInfo?.Communications)
// ? rfParty.ContactInfo.Communications
// : [rfParty.ContactInfo?.Communications || {}];
//
// return {
// servicing_dealer: rfParty.OrgInfo?.CompanyName || null,
// // TODO: The servicing dealer fields are a relic from synergy for a few folks
// // TODO: I suspect RF data could be ignored since they are the RF.
// servicing_dealer_contact:
// rfComms.find((c) => c.CommQualifier === "WP" || c.CommQualifier === "FX")?.CommPhone || null
// };
// };
/**
* Extracts loss information from the XML request.
@@ -204,10 +207,12 @@ const extractLossInfo = (rq) => {
loss_date: loss.LossDateTime || null,
loss_type: custom.LossTypeCode || null,
loss_desc: custom.LossTypeDesc || null
// primary_poi: loss.PrimaryPOI?.POICode || null, //PF: These map back to area_of_impact.impact_#
// secondary_poi: loss.SecondaryPOI?.POICode || null,
// area_of_impact: {
// impact_1: loss.PrimaryPOI?.POICode || null,
// imact_2 :loss.SecondaryPOI?.POICode || null,
// },
// tlosind: rq.ClaimInfo?.LossInfo?.TotalLossInd || null,
// damage_memo: loss.DamageMemo || null, //(maybe ins_memo)
// total_loss_ind: rq.ClaimInfo?.LossInfo?.TotalLossInd || null // New //PF: tlosind i believe is our field.
};
};
@@ -289,9 +294,11 @@ const extractVehicleData = (rq, shopId) => {
v_color: exterior.Color?.ColorName || null,
v_bstyle: desc.BodyStyle || null,
v_engine: desc.EngineDesc || null,
v_options: desc.SubModelDesc || null, //PF: Need to confirm with exact data, but this is typically a list of options. Not used AFAIK.
// TODO Need to confirm with exact data, but this is typically a list of options. Not used AFAIK.
v_options: desc.SubModelDesc || null,
v_type: desc.FuelType || null,
v_cond: rq.VehicleInfo?.Condition?.DrivableInd, //PF: there is a separate driveable flag on the job.
// TODO there is a separate driveable flag on the job.
v_cond: rq.VehicleInfo?.Condition?.DrivableInd,
v_trimcode: desc.TrimCode || null,
v_tone: exterior.Tone || null,
v_stage: exterior.RefinishStage || rq.VehicleInfo?.Paint?.RefinishStage || null,
@@ -343,7 +350,8 @@ const extractJobLines = (rq) => {
line.ManualLineInd === true ||
line.ManualLineInd === 1 ||
line.ManualLineInd === "1" ||
(typeof line.ManualLineInd === "string" && line.ManualLineInd.toUpperCase() === "Y"); //PF: manual line tracks manual in IO or not, this woudl presumably always be false
// TODO: manual line tracks manual in IO or not, this woudl presumably always be false
(typeof line.ManualLineInd === "string" && line.ManualLineInd.toUpperCase() === "Y");
} else {
lineOut.manual_line = null;
}
@@ -356,8 +364,10 @@ const extractJobLines = (rq) => {
const price = parseFloat(partInfo.PartPrice || partInfo.ListPrice || 0);
lineOut.part_type = partInfo.PartType || null ? String(partInfo.PartType).toUpperCase() : null;
lineOut.part_qty = parseFloat(partInfo.Quantity || 0) || 1;
lineOut.oem_partno = partInfo.OEMPartNum || partInfo.PartNum || null; //PF: if aftermarket part, we have alt_part_no to capture.
lineOut.db_price = isNaN(price) ? 0 : price; //PF: the Db and act price often are different. These should map back to their EMS equivalents.
//TODO: if aftermarket part, we have alt_part_no to capture.
lineOut.oem_partno = partInfo.OEMPartNum || partInfo.PartNum || null;
//TODO: the Db and act price often are different. These should map back to their EMS equivalents.
lineOut.db_price = isNaN(price) ? 0 : price;
lineOut.act_price = isNaN(price) ? 0 : price;
// Tax flag from PartInfo.TaxableInd when provided
@@ -373,8 +383,11 @@ const extractJobLines = (rq) => {
partInfo.TaxableInd === "1" ||
(typeof partInfo.TaxableInd === "string" && partInfo.TaxableInd.toUpperCase() === "Y");
}
} else if (hasSublet) {
const amt = parseFloat(subletInfo.SubletAmount || 0); //PF: Some nuance here. Usually a part and sublet amount shouldnt be on the same line, but they theoretically could. May require additional discussion.
}
//TODO: Some nuance here. Usually a part and sublet amount shouldnt be on the same line, but they theoretically
// could.May require additional discussion.
else if (hasSublet) {
const amt = parseFloat(subletInfo.SubletAmount || 0);
lineOut.part_type = "PAS"; // Sublet as parts-as-service
lineOut.part_qty = 1;
lineOut.act_price = isNaN(amt) ? 0 : amt;
@@ -390,12 +403,14 @@ const extractJobLines = (rq) => {
if (hasLabor) {
lineOut.mod_lbr_ty = laborInfo.LaborType || null;
lineOut.mod_lb_hrs = isNaN(hrs) ? 0 : hrs;
lineOut.lbr_op = laborInfo.LaborOperation || null; //PF: can add lbr_op_desc according to mapping available in new partner.
//TODO: can add lbr_op_desc according to mapping available in new partner.
lineOut.lbr_op = laborInfo.LaborOperation || null;
lineOut.lbr_amt = isNaN(amt) ? 0 : amt;
}
//PF: what's the BMS logic for this? Body and refinish operations can often happen to the same part, but most systems output a second line for the refinish labor.
//PF: 2nd line may include a duplicate of the part price, but that can be removed. This is the case for CCC.
//TODO: what's the BMS logic for this? Body and refinish operations can often happen to the same part,
// but most systems output a second line for the refinish labor.
//TODO: 2nd line may include a duplicate of the part price, but that can be removed. This is the case for CCC.
// Refinish labor (if present) recorded on the same line using secondary labor fields
const rHrs = parseFloat(refinishInfo.LaborHours || 0);
const rAmt = parseFloat(refinishInfo.LaborAmt || 0);
@@ -406,9 +421,9 @@ const extractJobLines = (rq) => {
!isNaN(rAmt) ||
!!refinishInfo.LaborOperation);
if (hasRefinish) {
lineOut.lbr_typ_j = refinishInfo.LaborType || "LAR"; //PF: _j fields indicate judgement, and are bool type.
lineOut.lbr_hrs_j = isNaN(rHrs) ? 0 : rHrs;//PF: _j fields indicate judgement, and are bool type.
lineOut.lbr_op_j = refinishInfo.LaborOperation || null; //PF: _j fields indicate judgement, and are bool type.
lineOut.lbr_typ_j = refinishInfo.LaborType || "LAR"; //TODO: _j fields indicate judgement, and are bool type.
lineOut.lbr_hrs_j = isNaN(rHrs) ? 0 : rHrs; //TODO: _j fields indicate judgement, and are bool type.
lineOut.lbr_op_j = refinishInfo.LaborOperation || null; //TODO: _j fields indicate judgement, and are bool type.
// Aggregate refinish labor amount into the total labor amount for the line
if (!isNaN(rAmt)) {
lineOut.lbr_amt = (Number.isFinite(lineOut.lbr_amt) ? lineOut.lbr_amt : 0) + rAmt;
@@ -424,26 +439,26 @@ const extractJobLines = (rq) => {
};
// Helper to extract a GRAND TOTAL amount from RepairTotalsInfo
const extractGrandTotal = (rq) => {
const rti = rq.RepairTotalsInfo;
const groups = Array.isArray(rti) ? rti : rti ? [rti] : [];
for (const grp of groups) {
const sums = Array.isArray(grp.SummaryTotalsInfo)
? grp.SummaryTotalsInfo
: grp.SummaryTotalsInfo
? [grp.SummaryTotalsInfo]
: [];
for (const s of sums) {
const type = (s.TotalType || "").toString().toUpperCase();
const desc = (s.TotalTypeDesc || "").toString().toUpperCase();
if (type.includes("GRAND") || type === "TOTAL" || desc.includes("GRAND")) {
const amt = parseFloat(s.TotalAmt ?? "NaN");
if (!isNaN(amt)) return amt;
}
}
}
return null;
};
// const extractGrandTotal = (rq) => {
// const rti = rq.RepairTotalsInfo;
// const groups = Array.isArray(rti) ? rti : rti ? [rti] : [];
// for (const grp of groups) {
// const sums = Array.isArray(grp.SummaryTotalsInfo)
// ? grp.SummaryTotalsInfo
// : grp.SummaryTotalsInfo
// ? [grp.SummaryTotalsInfo]
// : [];
// for (const s of sums) {
// const type = (s.TotalType || "").toString().toUpperCase();
// const desc = (s.TotalTypeDesc || "").toString().toUpperCase();
// if (type.includes("GRAND") || type === "TOTAL" || desc.includes("GRAND")) {
// const amt = parseFloat(s.TotalAmt ?? "NaN");
// if (!isNaN(amt)) return amt;
// }
// }
// }
// return null;
// };
/**
* Inserts an owner and returns the owner ID.
@@ -462,24 +477,26 @@ const insertOwner = async (ownerInput, logger) => {
};
// Fallback: compute a naive total from joblines (parts + sublet + labor amounts)
const computeLinesTotal = (joblines = []) => {
let parts = 0;
let labor = 0;
for (const jl of joblines) {
if (jl?.part_type) {
const qty = Number.isFinite(jl.part_qty) ? jl.part_qty : 1;
const price = Number.isFinite(jl.act_price) ? jl.act_price : 0;
parts += price * (qty || 1);
} else if (!jl.part_type && Number.isFinite(jl.act_price)) {
parts += jl.act_price;
}
if (Number.isFinite(jl.lbr_amt)) {
labor += jl.lbr_amt;
}
}
const total = parts + labor; //PF: clm_total is the 100% full amount of the repair including deductible, betterment and taxes. Typically provided by the source system.
return Number.isFinite(total) && total > 0 ? total : 0;
};
// const computeLinesTotal = (joblines = []) => {
// let parts = 0;
// let labor = 0;
// for (const jl of joblines) {
// if (jl?.part_type) {
// const qty = Number.isFinite(jl.part_qty) ? jl.part_qty : 1;
// const price = Number.isFinite(jl.act_price) ? jl.act_price : 0;
// parts += price * (qty || 1);
// } else if (!jl.part_type && Number.isFinite(jl.act_price)) {
// parts += jl.act_price;
// }
// if (Number.isFinite(jl.lbr_amt)) {
// labor += jl.lbr_amt;
// }
// }
// const total = parts + labor;
//
// //TODO: clm_total is the 100% full amount of the repair including deductible, betterment and taxes. Typically provided by the source system.
// return Number.isFinite(total) && total > 0 ? total : 0;
// };
/**
* Handles the VehicleDamageEstimateAddRq XML request from parts management.
@@ -516,9 +533,9 @@ const vehicleDamageEstimateAddRq = async (req, res) => {
scheduled_in,
scheduled_completion,
clm_no,
status,
policy_no,
ded_amt
// status,
} = extractJobData(rq);
if (!shopId) {
@@ -526,22 +543,22 @@ const vehicleDamageEstimateAddRq = async (req, res) => {
}
// Get default status
const defaultStatus = await getDefaultOrderStatus(shopId, logger); //This likely should be get default job status, not order.
const defaultStatus = await getDefaultJobStatus(shopId, logger);
// Extract additional data
const parts_tax_rates = extractPartsTaxRates(rq.ProfileInfo);
const ownerData = extractOwnerData(rq, shopId);
const estimatorData = extractEstimatorData(rq);
const adjusterData = extractAdjusterData(rq);
const repairFacilityData = extractRepairFacilityData(rq);
// const adjusterData = extractAdjusterData(rq);
// const repairFacilityData = extractRepairFacilityData(rq);
const vehicleData = extractVehicleData(rq, shopId);
const lossInfo = extractLossInfo(rq);
const joblinesData = extractJobLines(rq);
const insuranceData = extractInsuranceData(rq);
// Derive clm_total: prefer RepairTotalsInfo SummaryTotals GRAND TOTAL; else sum from lines
const grandTotal = extractGrandTotal(rq);
const computedTotal = grandTotal ?? computeLinesTotal(joblinesData);
// const grandTotal = extractGrandTotal(rq);
// const computedTotal = grandTotal ?? computeLinesTotal(joblinesData);
// Find or create relationships
const ownerid = await insertOwner(ownerData, logger);
@@ -560,8 +577,8 @@ const vehicleDamageEstimateAddRq = async (req, res) => {
class: classType,
parts_tax_rates,
clm_no,
status: status || defaultStatus,
clm_total: computedTotal || null,
status: defaultStatus,
clm_total: 0, // computedTotal || null,
policy_no,
ded_amt,
comment,
@@ -576,8 +593,8 @@ const vehicleDamageEstimateAddRq = async (req, res) => {
...lossInfo,
...ownerData,
...estimatorData,
...adjusterData,
...repairFacilityData,
// ...adjusterData,
// ...repairFacilityData,
// Inline vehicle data
v_vin: vehicleData.v_vin,
v_model_yr: vehicleData.v_model_yr,