Replaced remaining parts of app to use Redux.

This commit is contained in:
Patrick Fic
2020-01-31 13:57:27 -08:00
parent 3060c16dd3
commit e2518a95ab
12 changed files with 104 additions and 168 deletions

View File

@@ -1,20 +1,16 @@
import { useApolloClient } from "@apollo/react-hooks";
import i18next from "i18next"; import i18next from "i18next";
import React, { lazy, Suspense, useEffect, useState } from "react"; import React, { lazy, Suspense, useEffect } from "react";
import { connect } from "react-redux";
import { Route, Switch } from "react-router-dom"; import { Route, Switch } from "react-router-dom";
import { createStructuredSelector } from "reselect";
import ErrorBoundary from "../components/error-boundary/error-boundary.component"; import ErrorBoundary from "../components/error-boundary/error-boundary.component";
//Component Imports //Component Imports
import LoadingSpinner from "../components/loading-spinner/loading-spinner.component"; import LoadingSpinner from "../components/loading-spinner/loading-spinner.component";
import { auth } from "../firebase/firebase.utils"; import { checkUserSession } from "../redux/user/user.actions";
import { UPSERT_USER } from "../graphql/user.queries"; import { selectCurrentUser } from "../redux/user/user.selectors";
import { connect } from "react-redux";
import { createStructuredSelector } from "reselect";
// import { QUERY_BODYSHOP } from "../graphql/bodyshop.queries"; // import { QUERY_BODYSHOP } from "../graphql/bodyshop.queries";
import PrivateRoute from "../utils/private-route"; import PrivateRoute from "../utils/private-route";
import "./App.css"; import "./App.css";
import { checkUserSession } from "../redux/user/user.actions";
import { selectCurrentUser } from "../redux/user/user.selectors";
const LandingPage = lazy(() => import("../pages/landing/landing.page")); const LandingPage = lazy(() => import("../pages/landing/landing.page"));
const ManagePage = lazy(() => import("../pages/manage/manage.page")); const ManagePage = lazy(() => import("../pages/manage/manage.page"));
@@ -26,11 +22,9 @@ const Unauthorized = lazy(() =>
const mapStateToProps = createStructuredSelector({ const mapStateToProps = createStructuredSelector({
currentUser: selectCurrentUser currentUser: selectCurrentUser
}); });
const mapDispatchToProps = dispatch => ({ const mapDispatchToProps = dispatch => ({
checkUserSession: () => dispatch(checkUserSession()) checkUserSession: () => dispatch(checkUserSession())
}); });
export default connect( export default connect(
mapStateToProps, mapStateToProps,
mapDispatchToProps mapDispatchToProps
@@ -40,42 +34,6 @@ export default connect(
return () => {}; return () => {};
}, [checkUserSession]); }, [checkUserSession]);
// useEffect(() => {
// //Run the auth code only on the first render.
// const unsubscribeFromAuth = auth.onAuthStateChanged(async user => {
// console.log("onAuthStateChanged: User:", user);
// if (user) {
// let token;
// token = await user.getIdToken();
// //add the bearer token to the headers.
// localStorage.setItem("token", token);
// const now = new Date();
// window.sessionStorage.setItem(`lastTokenRefreshTime`, now);
// //token = await user.getIdToken(true); //how to refresh the token.
// apolloClient
// .mutate({
// mutation: UPSERT_USER,
// variables: { authEmail: user.email, authToken: user.uid }
// })
// .then()
// .catch(error => {
// console.log("User login upsert error.", error);
// });
// } else {
// localStorage.removeItem("token");
// }
// setloaded(true);
// });
// return function cleanup() {
// unsubscribeFromAuth();
// };
// }, [apolloClient]);
if (false) if (false)
i18next.changeLanguage("en_US", (err, t) => { i18next.changeLanguage("en_US", (err, t) => {
if (err) if (err)

View File

@@ -1,4 +1,3 @@
import { useApolloClient } from "@apollo/react-hooks";
import { Avatar, Col, Dropdown, Icon, Menu, Row } from "antd"; import { Avatar, Col, Dropdown, Icon, Menu, Row } from "antd";
import i18next from "i18next"; import i18next from "i18next";
import React from "react"; import React from "react";
@@ -7,6 +6,7 @@ import { connect } from "react-redux";
import { Link } from "react-router-dom"; import { Link } from "react-router-dom";
import { createStructuredSelector } from "reselect"; import { createStructuredSelector } from "reselect";
import UserImage from "../../assets/User.svg"; import UserImage from "../../assets/User.svg";
import { setUserLanguage, signOutStart } from "../../redux/user/user.actions";
import { selectCurrentUser } from "../../redux/user/user.selectors"; import { selectCurrentUser } from "../../redux/user/user.selectors";
import SignOut from "../sign-out/sign-out.component"; import SignOut from "../sign-out/sign-out.component";
@@ -15,30 +15,30 @@ const mapStateToProps = createStructuredSelector({
}); });
const mapDispatchToProps = dispatch => ({ const mapDispatchToProps = dispatch => ({
// signOutStart: () => dispatch(signOutStart()) signOutStart: () => dispatch(signOutStart()),
setUserLanguage: language => dispatch(setUserLanguage(language))
}); });
export default connect( export default connect(
mapStateToProps, mapStateToProps,
mapDispatchToProps mapDispatchToProps
)(function CurrentUserDropdown({ currentUser }) { )(function CurrentUserDropdown({ currentUser, signOutStart, setUserLanguage }) {
const { t } = useTranslation(); const { t } = useTranslation();
const client = useApolloClient();
const handleMenuClick = e => { const handleMenuClick = e => {
if (e.item.props.actiontype === "lang-select") { if (e.item.props.actiontype === "lang-select") {
i18next.changeLanguage(e.key, (err, t) => { i18next.changeLanguage(e.key, (err, t) => {
if (err) if (err)
return console.log("Error encountered when changing languages.", err); return console.log("Error encountered when changing languages.", err);
client.writeData({ data: { language: e.key } }); setUserLanguage(e.key);
console.log("clicking");
}); });
} }
}; };
const menu = ( const menu = (
<Menu mode="vertical" onClick={handleMenuClick}> <Menu mode="vertical" onClick={handleMenuClick}>
<Menu.Item> <Menu.Item>
<SignOut /> <SignOut signOutStart={signOutStart} />
</Menu.Item> </Menu.Item>
<Menu.Item> <Menu.Item>
<Link to="/manage/profile"> {t("menus.currentuser.profile")}</Link> <Link to="/manage/profile"> {t("menus.currentuser.profile")}</Link>

View File

@@ -1,4 +1,3 @@
import { useApolloClient } from "@apollo/react-hooks";
import { Col, Icon, Menu, Row } from "antd"; import { Col, Icon, Menu, Row } from "antd";
import React from "react"; import React from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
@@ -7,21 +6,15 @@ import CurrentUserDropdown from "../current-user-dropdown/current-user-dropdown.
import GlobalSearch from "../global-search/global-search.component"; import GlobalSearch from "../global-search/global-search.component";
import ManageSignInButton from "../manage-sign-in-button/manage-sign-in-button.component"; import ManageSignInButton from "../manage-sign-in-button/manage-sign-in-button.component";
export default ({ landingHeader, navItems, selectedNavItem }) => { export default ({ landingHeader, selectedNavItem }) => {
const apolloClient = useApolloClient();
const { t } = useTranslation(); const { t } = useTranslation();
const handleClick = e => {
apolloClient.writeData({ data: { selectedNavItem: e.key } });
};
return ( return (
<Row type="flex" justify="space-around"> <Row type="flex" justify="space-around">
<Col span={16}> <Col span={16}>
<Menu <Menu
theme="dark" theme="dark"
className="header" className="header"
onClick={handleClick}
selectedKeys={selectedNavItem} selectedKeys={selectedNavItem}
mode="horizontal" mode="horizontal"
> >

View File

@@ -1,13 +1,22 @@
import React from "react"; import React from "react";
import { useQuery } from "react-apollo"; import { useQuery } from "react-apollo";
import { connect } from "react-redux";
import { createStructuredSelector } from "reselect";
import { QUERY_SHOP_ID } from "../../graphql/bodyshop.queries"; import { QUERY_SHOP_ID } from "../../graphql/bodyshop.queries";
import { GET_DOCUMENTS_BY_JOB } from "../../graphql/documents.queries"; import { GET_DOCUMENTS_BY_JOB } from "../../graphql/documents.queries";
import { selectCurrentUser } from "../../redux/user/user.selectors";
import AlertComponent from "../alert/alert.component"; import AlertComponent from "../alert/alert.component";
import LoadingSpinner from "../loading-spinner/loading-spinner.component"; import LoadingSpinner from "../loading-spinner/loading-spinner.component";
import JobDocuments from "./jobs-documents.component"; import JobDocuments from "./jobs-documents.component";
import { GET_CURRENT_USER } from "../../graphql/local.queries";
export default function JobsDocumentsContainer({ jobId }) { const mapStateToProps = createStructuredSelector({
currentUser: selectCurrentUser
});
export default connect(
mapStateToProps,
null
)(function JobsDocumentsContainer({ jobId, currentUser }) {
const { loading, error, data } = useQuery(GET_DOCUMENTS_BY_JOB, { const { loading, error, data } = useQuery(GET_DOCUMENTS_BY_JOB, {
variables: { jobId: jobId }, variables: { jobId: jobId },
fetchPolicy: "network-only" fetchPolicy: "network-only"
@@ -17,14 +26,12 @@ export default function JobsDocumentsContainer({ jobId }) {
fetchPolicy: "network-only" fetchPolicy: "network-only"
}); });
const user = useQuery(GET_CURRENT_USER); if (loading || shopData.loading) return <LoadingSpinner />;
if (error || shopData.error)
if (loading || shopData.loading || user.loading) return <LoadingSpinner />;
if (error || shopData.error || user.error)
return ( return (
<AlertComponent <AlertComponent
type='error' type="error"
message={error.message || shopData.error.message || user.error.message} message={error.message || shopData.error.message}
/> />
); );
@@ -32,7 +39,7 @@ export default function JobsDocumentsContainer({ jobId }) {
<JobDocuments <JobDocuments
data={data.documents} data={data.documents}
jobId={jobId} jobId={jobId}
currentUser={user.data.currentUser} currentUser={currentUser}
shopId={ shopId={
shopData.data?.bodyshops[0]?.id shopData.data?.bodyshops[0]?.id
? shopData.data?.bodyshops[0]?.id ? shopData.data?.bodyshops[0]?.id
@@ -40,4 +47,4 @@ export default function JobsDocumentsContainer({ jobId }) {
} }
/> />
); );
} });

View File

@@ -1,10 +1,7 @@
import React from "react";
import { useQuery } from "react-apollo";
import { Link } from "react-router-dom";
import { GET_CURRENT_USER } from "../../graphql/local.queries";
import { Icon } from "antd"; import { Icon } from "antd";
import LoadingSpinner from "../loading-spinner/loading-spinner.component"; import React from "react";
import { connect } from "react-redux"; import { connect } from "react-redux";
import { Link } from "react-router-dom";
import { createStructuredSelector } from "reselect"; import { createStructuredSelector } from "reselect";
import { selectCurrentUser } from "../../redux/user/user.selectors"; import { selectCurrentUser } from "../../redux/user/user.selectors";
@@ -12,28 +9,19 @@ const mapStateToProps = createStructuredSelector({
currentUser: selectCurrentUser currentUser: selectCurrentUser
}); });
const mapDispatchToProps = dispatch => ({
// signOutStart: () => dispatch(signOutStart())
});
export default connect( export default connect(
mapStateToProps, mapStateToProps,
mapDispatchToProps null
)(function ManageSignInButton({ currentUser }) { )(function ManageSignInButton({ currentUser }) {
return currentUser.isAuthorized ? ( return currentUser.authorized ? (
<div> <Link to="/manage">
{" "} <Icon type="build" />
<Link to="/manage"> Manage
<Icon type="build" /> </Link>
Manage
</Link>
</div>
) : ( ) : (
<div> <Link to="/signin">
<Link to="/signin"> <Icon type="login" />
<Icon type="login" /> Sign In
Sign In </Link>
</Link>
</div>
); );
}); });

View File

@@ -1,14 +1,13 @@
import { Button, Form, Icon, Input } from "antd"; import { Button, Form, Icon, Input } from "antd";
import React from "react"; import React from "react";
import { useApolloClient } from "react-apollo";
import { connect } from "react-redux"; import { connect } from "react-redux";
import { Redirect } from "react-router-dom";
import { createStructuredSelector } from "reselect"; import { createStructuredSelector } from "reselect";
import Logo from "../../assets/logo240.png"; import Logo from "../../assets/logo240.png";
import { UPSERT_USER } from "../../graphql/user.queries";
import { emailSignInStart } from "../../redux/user/user.actions"; import { emailSignInStart } from "../../redux/user/user.actions";
import { import { selectCurrentUser, selectSignInError } from "../../redux/user/user.selectors";
selectCurrentUser,
selectSignInError
} from "../../redux/user/user.selectors";
import { Redirect } from "react-router-dom";
const mapStateToProps = createStructuredSelector({ const mapStateToProps = createStructuredSelector({
currentUser: selectCurrentUser, currentUser: selectCurrentUser,
@@ -30,6 +29,8 @@ export default connect(
currentUser, currentUser,
signInError signInError
}) { }) {
const apolloClient = useApolloClient();
const handleSubmit = e => { const handleSubmit = e => {
e.preventDefault(); e.preventDefault();
form.validateFields(async (err, values) => { form.validateFields(async (err, values) => {
@@ -41,7 +42,21 @@ export default connect(
}); });
}; };
console.log("currentUser", currentUser); if (currentUser.authorized === true) {
apolloClient
.mutate({
mutation: UPSERT_USER,
variables: {
authEmail: currentUser.email,
authToken: currentUser.uid
}
})
.then()
.catch(error => {
console.log("User login upsert error.", error);
});
}
const { getFieldDecorator } = form; const { getFieldDecorator } = form;
return ( return (
<div> <div>

View File

@@ -1,20 +1,8 @@
import React from "react"; import React from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import firebase from "../../firebase/firebase.utils";
export default function SignoutComponent() {
const signOut = async () => {
try {
await firebase.auth().signOut();
// this.setState({
// redirect: true
// });
} catch (error) {
console.log(error);
}
};
export default function SignoutComponent({ signOutStart }) {
const { t } = useTranslation(); const { t } = useTranslation();
return <div onClick={signOut}>{t("user.actions.signout")}</div>; return <div onClick={signOutStart}>{t("user.actions.signout")}</div>;
} }

View File

@@ -1,25 +0,0 @@
import { gql } from "apollo-boost";
export const GET_CURRENT_USER = gql`
query GET_CURRENT_USER {
currentUser @client {
email
displayName
token
uid
photoUrl
}
}
`;
export const GET_CURRENT_SELECTED_NAV_ITEM = gql`
query GET_CURRENT_SELECTED_NAV_ITEM {
selectedNavItem @client
}
`;
export const GET_LANGUAGE = gql`
query GET_USER_LANGUAGE {
language @client
}
`;

View File

@@ -33,3 +33,8 @@ export const signOutFailure = error => ({
export const unauthorizedUser = () => ({ export const unauthorizedUser = () => ({
type: UserActionTypes.UNAUTHORIZED_USER type: UserActionTypes.UNAUTHORIZED_USER
}); });
export const setUserLanguage = language => ({
type: UserActionTypes.SET_USER_LANGUAGE,
payload: language
});

View File

@@ -2,7 +2,8 @@ import UserActionTypes from "./user.types";
const INITIAL_STATE = { const INITIAL_STATE = {
currentUser: { currentUser: {
authorized: null authorized: null,
language: "en_US"
}, },
error: null error: null
}; };
@@ -27,9 +28,15 @@ const userReducer = (state = INITIAL_STATE, action) => {
error: null, error: null,
currentUser: { authorized: false } currentUser: { authorized: false }
}; };
case UserActionTypes.SET_USER_LANGUAGE:
return {
...state,
language: action.payload
};
case UserActionTypes.SIGN_IN_FAILURE: case UserActionTypes.SIGN_IN_FAILURE:
case UserActionTypes.SIGN_OUT_FAILURE: case UserActionTypes.SIGN_OUT_FAILURE:
case UserActionTypes.EMAIL_SIGN_UP_FAILURE: case UserActionTypes.EMAIL_SIGN_UP_FAILURE:
console.log("Reduced getting called.");
return { return {
...state, ...state,
error: action.payload error: action.payload

View File

@@ -1,12 +1,6 @@
import { all, call, put, takeLatest } from "redux-saga/effects"; import { all, call, put, takeLatest } from "redux-saga/effects";
import { auth, getCurrentUser } from "../../firebase/firebase.utils"; import { auth, getCurrentUser } from "../../firebase/firebase.utils";
import { import { signInFailure, signInSuccess, signOutFailure, signOutSuccess, unauthorizedUser } from "./user.actions";
signInFailure,
signInSuccess,
signOutFailure,
signOutSuccess,
unauthorizedUser
} from "./user.actions";
import UserActionTypes from "./user.types"; import UserActionTypes from "./user.types";
// export function* getSnapshotFromUserAuth(userAuth) { // export function* getSnapshotFromUserAuth(userAuth) {
@@ -23,7 +17,7 @@ export function* signInWithEmail({ payload: { email, password } }) {
const { user } = yield auth.signInWithEmailAndPassword(email, password); const { user } = yield auth.signInWithEmailAndPassword(email, password);
yield put( yield put(
signInSuccess({ signInSuccess({
id: user.uid, uid: user.uid,
email: user.email, email: user.email,
displayName: user.displayName, displayName: user.displayName,
authorized: true authorized: true
@@ -45,9 +39,13 @@ export function* isUserAuthenticated() {
yield put(unauthorizedUser()); yield put(unauthorizedUser());
return; return;
} }
let token = yield user.getIdToken();
localStorage.setItem("token", token);
window.sessionStorage.setItem(`lastTokenRefreshTime`, new Date());
yield put( yield put(
signInSuccess({ signInSuccess({
id: user.uid, uid: user.uid,
email: user.email, email: user.email,
displayName: user.displayName, displayName: user.displayName,
authorized: true authorized: true
@@ -66,6 +64,7 @@ export function* signOutStart() {
try { try {
yield auth.signOut(); yield auth.signOut();
yield put(signOutSuccess()); yield put(signOutSuccess());
localStorage.removeItem("token");
} catch (error) { } catch (error) {
yield put(signOutFailure(error.message)); yield put(signOutFailure(error.message));
} }
@@ -75,12 +74,13 @@ export function* onSignOutStart() {
yield takeLatest(UserActionTypes.SIGN_OUT_START, signOutStart); yield takeLatest(UserActionTypes.SIGN_OUT_START, signOutStart);
} }
export function* userSagas() { export function* userSagas() {
yield all([ yield all([
// call(onGoogleSignInStart), // call(onGoogleSignInStart),
call(onEmailSignInStart), call(onEmailSignInStart),
call(onCheckUserSession), call(onCheckUserSession),
call(onSignOutStart) call(onSignOutStart),
// call(onEmailSignUpStart), // call(onEmailSignUpStart),
// call(onEmailSignUpSuccess) // call(onEmailSignUpSuccess)
]); ]);

View File

@@ -1,17 +1,17 @@
const UserActionTypes = { const UserActionTypes = {
SET_CURRENT_USER: "SET_CURRENT_USER", SET_CURRENT_USER: "SET_CURRENT_USER",
GOOGLE_SIGN_IN_START: "GOOGLE_SIGN_IN_START", GOOGLE_SIGN_IN_START: "GOOGLE_SIGN_IN_START",
SIGN_IN_SUCCESS: "SIGN_IN_SUCCESS", SIGN_IN_SUCCESS: "SIGN_IN_SUCCESS",
SIGN_IN_FAILURE: "SIGN_IN_FAILURE", SIGN_IN_FAILURE: "SIGN_IN_FAILURE",
EMAIL_SIGN_IN_START: "EMAIL_SIGN_IN_START", EMAIL_SIGN_IN_START: "EMAIL_SIGN_IN_START",
CHECK_USER_SESSION: "CHECK_USER_SESSION", CHECK_USER_SESSION: "CHECK_USER_SESSION",
SIGN_OUT_START: "SIGN_OUT_START", SIGN_OUT_START: "SIGN_OUT_START",
SIGN_OUT_SUCCESS: "SIGN_OUT_SUCCESS", SIGN_OUT_SUCCESS: "SIGN_OUT_SUCCESS",
SIGN_OUT_FAILURE: "SIGN_OUT_FAILURE", SIGN_OUT_FAILURE: "SIGN_OUT_FAILURE",
EMAIL_SIGN_UP_START: "EMAIL_SIGN_UP_START", EMAIL_SIGN_UP_START: "EMAIL_SIGN_UP_START",
EMAIL_SIGN_UP_SUCCESS: "EMAIL_SIGN_UP_SUCCESS", EMAIL_SIGN_UP_SUCCESS: "EMAIL_SIGN_UP_SUCCESS",
EMAIL_SIGN_UP_FAILURE: "EMAIL_SIGN_UP_FAILURE", EMAIL_SIGN_UP_FAILURE: "EMAIL_SIGN_UP_FAILURE",
UNAUTHORIZED_USER: "UNAUTHORIZED_USER" UNAUTHORIZED_USER: "UNAUTHORIZED_USER",
}; SET_USER_LANGUAGE: "SET_USER_LANGUAGE"
export default UserActionTypes; };
export default UserActionTypes;