- Merge Test-AIO

Signed-off-by: Dave Richer <dave@imexsystems.ca>

client/src/components/bill-detail-edit/bill-detail-edit-return.component.jsx

@@ -34,6 +34,7 @@ export function BillDetailEditReturn({ setPartsOrderContext, insertAuditTrail, b
       actions: {},
       context: {
         jobId: data.bills_by_pk.jobid,
+        job: data.bills_by_pk.job,
         vendorId: data.bills_by_pk.vendorid,
         returnFromBill: data.bills_by_pk.id,
         invoiceNumber: data.bills_by_pk.invoice_number,

client/src/components/bills-list-table/bills-list-table.component.jsx

@@ -76,7 +76,7 @@ export function BillsListTableComponent({
       </Button>
       <BillDeleteButton bill={record} jobid={job.id}/>
       <BillDetailEditReturnComponent
-        data={{bills_by_pk: {...record, jobid: job.id}}}
+        data={{ bills_by_pk: { ...record, jobid: job.id, job: job } }}
         disabled={record.is_credit_memo || record.vendorid === bodyshop.inhousevendorid || jobRO}
       />
 

client/src/components/job-search-select/job-search-select.component.jsx

@@ -1,5 +1,6 @@
-import {useLazyQuery} from "@apollo/client";
+import { LoadingOutlined } from "@ant-design/icons";
-import {Select, Space, Spin, Tag} from "antd";
+import { useLazyQuery } from "@apollo/client";
+import { Select, Space, Spin, Tag } from "antd";
 import _ from "lodash";
 import React, {forwardRef, useEffect, useState} from "react";
 import {useTranslation} from "react-i18next";
@@ -8,8 +9,7 @@ import {
   SEARCH_JOBS_FOR_AUTOCOMPLETE
 } from "../../graphql/jobs.queries";
 import AlertComponent from "../alert/alert.component";
-import {OwnerNameDisplayFunction} from "../owner-name-display/owner-name-display.component";
+import { OwnerNameDisplayFunction } from "../owner-name-display/owner-name-display.component";
-import {LoadingOutlined} from "@ant-design/icons";
 
 const {Option} = Select;
 
@@ -28,9 +28,14 @@ const JobSearchSelect = (
   const [theOptions, setTheOptions] = useState([]);
   const [callSearch, {loading, error, data}] = useLazyQuery(SEARCH_JOBS_FOR_AUTOCOMPLETE, {});
 
-  const [callIdSearch, {loading: idLoading, error: idError, data: idData}] = useLazyQuery(
+  const [
-    SEARCH_JOBS_BY_ID_FOR_AUTOCOMPLETE
+    callIdSearch,
-  );
+    {
+      //loading: idLoading,
+      error: idError,
+      data: idData
+    }
+  ] = useLazyQuery(SEARCH_JOBS_BY_ID_FOR_AUTOCOMPLETE);
 
   const executeSearch = (v) => {
     if (v && v.variables?.search !== "" && v.variables.search.length >= 2) callSearch(v);
@@ -95,9 +100,9 @@ const JobSearchSelect = (
                   <span>
                     {`${clm_no && o.clm_no ? `${o.clm_no} | ` : ""}${
                       o.ro_number || t("general.labels.na")
-                    } | ${OwnerNameDisplayFunction(o)} | ${
+                    } | ${OwnerNameDisplayFunction(o)} | ${o.v_model_yr || ""} ${o.v_make_desc || ""} ${
-                      o.v_model_yr || ""
+                      o.v_model_desc || ""
-                    } ${o.v_make_desc || ""} ${o.v_model_desc || ""}`}
+                    }`}
                   </span>
                 <Tag>
                   <strong>{o.status}</strong>

client/src/components/jobs-available-table/jobs-available-table.container.jsx

@@ -237,7 +237,7 @@ export function JobsAvailableContainer({ bodyshop, currentUser, insertAuditTrail
         executeFunction: true,
         rome: ResolveCCCLineIssues,
         promanager: ResolveCCCLineIssues,
-        args: [(supp, bodyshop)]
+        args: [supp, bodyshop]
       });
 
       await InstanceRenderManager({

client/src/components/payment-mark-export-button/payment-mark-export-button-component.jsx

@@ -7,17 +7,19 @@ import { createStructuredSelector } from "reselect";
 import { INSERT_EXPORT_LOG } from "../../graphql/accounting.queries";
 import { UPDATE_PAYMENT } from "../../graphql/payments.queries";
 import { setModalContext } from "../../redux/modals/modals.actions";
+import { selectPayment } from "../../redux/modals/modals.selectors";
 import { selectCurrentUser } from "../../redux/user/user.selectors";
 
 const mapStateToProps = createStructuredSelector({
-  currentUser: selectCurrentUser
+  currentUser: selectCurrentUser,
+  paymentModal: selectPayment
 });
 
 const mapDispatchToProps = (dispatch) => ({
   setPaymentContext: (context) => dispatch(setModalContext({ context: context, modal: "payment" }))
 });
 
-const PaymentMarkForExportButton = ({ bodyshop, payment, refetch, setPaymentContext, currentUser }) => {
+const PaymentMarkForExportButton = ({ bodyshop, payment, refetch, setPaymentContext, currentUser, paymentModal }) => {
   const { t } = useTranslation();
   const [insertExportLog, { loading: exportLogLoading }] = useMutation(INSERT_EXPORT_LOG);
   const [updatePayment, { loading: updatePaymentLoading }] = useMutation(UPDATE_PAYMENT);
@@ -56,17 +58,21 @@ const PaymentMarkForExportButton = ({ bodyshop, payment, refetch, setPaymentCont
           refetch
         },
         context: {
+          ...paymentModal.context,
+          ...paymentModal.context,
           ...payment,
           smartRefetch: true,
           exportedat: today
         }
       });
 
-      if (refetch)
+      if (refetch) {
-        refetch(
+        if (paymentModal.context.refetchRequiresContext) {
-          paymentUpdateResponse &&
+          refetch(paymentUpdateResponse && paymentUpdateResponse.data.update_payments.returning[0]);
-            paymentUpdateResponse.data.update_payments.returning[0]
+        } else {
-        );
+          refetch();
+        }
+      }
     } else {
       notification["error"]({
         message: t("payments.errors.exporting", {

client/src/components/payment-modal/payment-modal.container.jsx

@@ -32,7 +32,6 @@ function PaymentModalContainer({paymentModal, toggleModalVisible, bodyshop }) {
 
   const { t } = useTranslation();
   const { context, actions, open } = paymentModal;
-  const smartRefetch = context?.smartRefetch || false;
   const [loading, setLoading] = useState(false);
 
   const handleFinish = async (values) => {
@@ -82,15 +81,18 @@ function PaymentModalContainer({paymentModal, toggleModalVisible, bodyshop }) {
         });
 
         if (!!!updatedPayment.errors) {
-          notification["success"]({ message: t("payments.successes.payment") });
+          notification["success"]({ message: t("payments.successes.paymentupdate") });
         } else {
-          notification["error"]({ message: t("payments.errors.payment") });
+          notification["error"]({ message: t("payments.errors.paymentupdate") });
         }
       }
 
       if (actions.refetch) {
-        const updatedData = smartRefetch && updatedPayment ? updatedPayment.data.update_payments.returning[0] : undefined;
+        if (context.refetchRequiresContext) {
-        actions.refetch(updatedData);
+          actions.refetch(updatedPayment && updatedPayment.data.update_payments.returning[0]);
+        } else {
+          actions.refetch();
+        }
       }
 
       if (enterAgain) {
@@ -166,13 +168,7 @@ function PaymentModalContainer({paymentModal, toggleModalVisible, bodyshop }) {
         </Space>
       )}
 
-      <Form
+      <Form onFinish={handleFinish} autoComplete={"off"} form={form} layout="vertical" disabled={context?.exportedat}>
-        onFinish={handleFinish}
-        autoComplete={"off"}
-        form={form}
-        layout="vertical"
-        disabled={context?.exportedat}
-      >
         <PaymentForm form={form} />
       </Form>
     </Modal>

client/src/components/payment-reexport-button/payment-reexport-button.component.jsx

@@ -3,14 +3,20 @@ import { Button, notification } from "antd";
 import React from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
+import { createStructuredSelector } from "reselect";
 import { UPDATE_PAYMENT } from "../../graphql/payments.queries";
 import { setModalContext } from "../../redux/modals/modals.actions";
+import { selectPayment } from "../../redux/modals/modals.selectors";
+
+const mapStateToProps = createStructuredSelector({
+  paymentModal: selectPayment
+});
 
 const mapDispatchToProps = (dispatch) => ({
   setPaymentContext: (context) => dispatch(setModalContext({ context: context, modal: "payment" }))
 });
 
-const PaymentReexportButton = ({ payment, refetch, setPaymentContext }) => {
+const PaymentReexportButton = ({ paymentModal, payment, refetch, setPaymentContext }) => {
   const { t } = useTranslation();
   const [updatePayment, { loading }] = useMutation(UPDATE_PAYMENT);
 
@@ -34,16 +40,20 @@ const PaymentReexportButton = ({ payment, refetch, setPaymentContext }) => {
           refetch
         },
         context: {
-          smartRefetch: true,
+          ...paymentModal.context,
+          ...paymentModal.context,
           ...payment,
           exportedat: null
         }
       });
-      if (refetch)
+
-        refetch(
+      if (refetch) {
-          paymentUpdateResponse &&
+        if (paymentModal.context.refetchRequiresContext) {
-            paymentUpdateResponse.data.update_payments.returning[0]
+          refetch(paymentUpdateResponse && paymentUpdateResponse.data.update_payments.returning[0]);
-        );
+        } else {
+          refetch();
+        }
+      }
     } else {
       notification["error"]({
         message: t("payments.errors.exporting", {
@@ -60,4 +70,4 @@ const PaymentReexportButton = ({ payment, refetch, setPaymentContext }) => {
   );
 };
 
-export default connect(null, mapDispatchToProps)(PaymentReexportButton);
+export default connect(mapStateToProps, mapDispatchToProps)(PaymentReexportButton);

client/src/components/payments-list-paginated/payment-list-paginated.component.jsx

@@ -14,11 +14,11 @@ import { selectBodyshop } from "../../redux/user/user.selectors";
 import CurrencyFormatter from "../../utils/CurrencyFormatter";
 import { DateFormatter, DateTimeFormatter } from "../../utils/DateFormatter";
 import { TemplateList } from "../../utils/TemplateConstants";
+import { pageLimit } from "../../utils/config";
 import { alphaSort } from "../../utils/sorters";
 import CaBcEtfTableModalContainer from "../ca-bc-etf-table-modal/ca-bc-etf-table-modal.container";
 import OwnerNameDisplay from "../owner-name-display/owner-name-display.component";
 import PrintWrapperComponent from "../print-wrapper/print-wrapper.component";
-import { pageLimit } from "../../utils/config";
 
 const mapStateToProps = createStructuredSelector({
   //currentUser: selectCurrentUser
@@ -171,7 +171,7 @@ export function PaymentsListPaginated({
                       }
                     : refetch
                 },
-                context: apolloResults ? { smartRefetch: true, ...apolloResults} : {smartRefetch: true, ...record}
+                context: { ...(apolloResults ? apolloResults : record), refetchRequiresContext: true }
               });
             }}
           >

client/src/translations/en_us/common.json

@@ -2595,7 +2595,8 @@
         "markexported": "Payment(s) marked exported.",
         "markreexported": "Payment marked for re-export successfully",
         "payment": "Payment created successfully. ",
-        "stripe": "Credit card transaction charged successfully."
+        "paymentupdate": "Payment updated successfully. ",
+				"stripe": "Credit card transaction charged successfully."
       }
     },
     "phonebook": {

client/src/translations/es/common.json

@@ -2594,7 +2594,8 @@
         "markexported": "",
         "markreexported": "",
         "payment": "",
-        "stripe": ""
+        "paymentupdate": "",
+				"stripe": ""
       }
     },
     "phonebook": {

client/src/translations/fr/common.json

@@ -2594,7 +2594,8 @@
         "markexported": "",
         "markreexported": "",
         "payment": "",
-        "stripe": ""
+        "paymentupdate": "",
+				"stripe": ""
       }
     },
     "phonebook": {