diff --git a/client/src/components/jobs-change-status/jobs-change-status.component.jsx b/client/src/components/jobs-change-status/jobs-change-status.component.jsx index bdfcfca94..c9b2566d2 100644 --- a/client/src/components/jobs-change-status/jobs-change-status.component.jsx +++ b/client/src/components/jobs-change-status/jobs-change-status.component.jsx @@ -1,16 +1,16 @@ import { DownCircleFilled } from "@ant-design/icons"; import { useMutation } from "@apollo/client"; import { Button, Dropdown } from "antd"; -import React, { useEffect, useState } from "react"; +import { useEffect, useState } from "react"; import { useTranslation } from "react-i18next"; import { connect } from "react-redux"; import { createStructuredSelector } from "reselect"; +import { useNotification } from "../../contexts/Notifications/notificationContext.jsx"; import { UPDATE_JOB_STATUS } from "../../graphql/jobs.queries"; import { insertAuditTrail } from "../../redux/application/application.actions"; import { selectJobReadOnly } from "../../redux/application/application.selectors"; import { selectBodyshop } from "../../redux/user/user.selectors"; import AuditTrailMapping from "../../utils/AuditTrailMappings"; -import { useNotification } from "../../contexts/Notifications/notificationContext.jsx"; const mapStateToProps = createStructuredSelector({ bodyshop: selectBodyshop, @@ -24,7 +24,6 @@ export function JobsChangeStatus({ job, bodyshop, jobRO, insertAuditTrail }) { const { t } = useTranslation(); const [availableStatuses, setAvailableStatuses] = useState([]); - const [otherStages, setOtherStages] = useState([]); const [mutationUpdateJobstatus] = useMutation(UPDATE_JOB_STATUS); const notification = useNotification(); @@ -32,7 +31,7 @@ export function JobsChangeStatus({ job, bodyshop, jobRO, insertAuditTrail }) { mutationUpdateJobstatus({ variables: { jobId: job.id, status: status } }) - .then((r) => { + .then(() => { notification["success"]({ message: t("jobs.successes.save") }); insertAuditTrail({ jobid: job.id, @@ -41,7 +40,7 @@ export function JobsChangeStatus({ job, bodyshop, jobRO, insertAuditTrail }) { }); // refetch(); }) - .catch((error) => { + .catch(() => { notification["error"]({ message: t("jobs.errors.saving") }); }); }; @@ -51,19 +50,14 @@ export function JobsChangeStatus({ job, bodyshop, jobRO, insertAuditTrail }) { if (job && bodyshop) { if (bodyshop.md_ro_statuses.pre_production_statuses.includes(job.status)) { setAvailableStatuses(bodyshop.md_ro_statuses.pre_production_statuses); - if (bodyshop.md_ro_statuses.production_statuses[0]) - setOtherStages([bodyshop.md_ro_statuses.production_statuses[0]]); } else if (bodyshop.md_ro_statuses.production_statuses.includes(job.status)) { setAvailableStatuses(bodyshop.md_ro_statuses.production_statuses); - setOtherStages([bodyshop.md_ro_statuses.default_imported, bodyshop.md_ro_statuses.default_delivered]); } else if (bodyshop.md_ro_statuses.post_production_statuses.includes(job.status)) { setAvailableStatuses( bodyshop.md_ro_statuses.post_production_statuses.filter( (s) => s !== bodyshop.md_ro_statuses.default_invoiced && s !== bodyshop.md_ro_statuses.default_exported ) ); - if (bodyshop.md_ro_statuses.production_statuses[0]) - setOtherStages([bodyshop.md_ro_statuses.production_statuses[0]]); } else { console.log("Status didn't match any restrictions. Allowing all status changes."); setAvailableStatuses(bodyshop.md_ro_statuses.statuses); @@ -76,16 +70,7 @@ export function JobsChangeStatus({ job, bodyshop, jobRO, insertAuditTrail }) { ...availableStatuses.map((item) => ({ key: item, label: item - })), - ...(job.converted - ? [ - { type: "divider" }, - ...otherStages.map((item) => ({ - key: item, - label: item - })) - ] - : []) + })) ], onClick: (e) => updateJobStatus(e.key) };