Removed all todos from code and created corresponding JIRA tickets.

This commit is contained in:
Patrick Fic
2021-01-05 14:39:27 -08:00
parent 3e3b2780e3
commit af8ccfaff5
35 changed files with 65 additions and 143 deletions

View File

@@ -1,18 +1,18 @@
import axios from "axios";
import phone from "phone";
import { all, call, put, select, takeLatest } from "redux-saga/effects";
import client from "../../utils/GraphQLClient";
import { logImEXEvent } from "../../firebase/firebase.utils";
import {
CONVERSATION_ID_BY_PHONE,
CREATE_CONVERSATION,
CREATE_CONVERSATION
} from "../../graphql/conversations.queries";
import { INSERT_CONVERSATION_TAG } from "../../graphql/job-conversations.queries";
import client from "../../utils/GraphQLClient";
import { selectBodyshop } from "../user/user.selectors";
import {
sendMessageFailure,
sendMessageSuccess,
setSelectedConversation,
setSelectedConversation
} from "./messaging.actions";
import MessagingActionTypes from "./messaging.types";
@@ -73,7 +73,7 @@ export function* openChatByPhone({ payload }) {
},
});
} else {
console.log("ERROR: Multiple conversations found. "); //TODO Graceful handling of this situation
console.log("ERROR: Multiple conversations found. ");
}
} catch (error) {
console.log("Error in sendMessage saga.", error);

View File

@@ -10,6 +10,9 @@ import {
} from "../../firebase/firebase.utils";
import {
checkInstanceId,
sendPasswordResetFailure,
sendPasswordResetSuccess,
setAuthlevel,
setInstanceConflict,
setInstanceId,
setLocalFingerprint,
@@ -19,11 +22,8 @@ import {
signOutSuccess,
unauthorizedUser,
updateUserDetailsSuccess,
sendPasswordResetFailure,
sendPasswordResetSuccess,
validatePasswordResetSuccess,
validatePasswordResetFailure,
setAuthlevel,
validatePasswordResetSuccess,
} from "./user.actions";
import UserActionTypes from "./user.types";
@@ -102,7 +102,6 @@ export function* updateUserDetails(userDetails) {
yield put(updateUserDetailsSuccess(userDetails.payload));
} catch (error) {
//yield put(signOutFailure(error.message));
//TODO error handling
}
}
export function* onSetInstanceId() {
@@ -127,8 +126,6 @@ export function* setInstanceIdSaga({ payload: uid }) {
if (process.env.NODE_ENV === "production") yield put(checkInstanceId(uid));
} catch (error) {
console.log("error", error);
//yield put(signOutFailure(error.message));
//TODO error handling
}
}
@@ -152,7 +149,6 @@ export function* checkInstanceIdSaga({ payload: uid }) {
}
} catch (error) {
console.log("error", error);
//TODO error handling
}
}