IO-3515 resolve issues on search selects not updating, improve confidence scoring.

client/src/components/bill-form/bill-form.component.jsx

@@ -8,12 +8,15 @@ import { MdOpenInNew } from "react-icons/md";
 import { connect } from "react-redux";
 import { Link } from "react-router-dom";
 import { createStructuredSelector } from "reselect";
+import { useNotification } from "../../contexts/Notifications/notificationContext.jsx";
 import { CHECK_BILL_INVOICE_NUMBER } from "../../graphql/bills.queries";
 import { selectBodyshop } from "../../redux/user/user.selectors";
 import dayjs from "../../utils/day";
+import { bodyshopHasDmsKey } from "../../utils/dmsUtils.js";
 import InstanceRenderManager from "../../utils/instanceRenderMgr";
 import AlertComponent from "../alert/alert.component";
 import BillFormLinesExtended from "../bill-form-lines-extended/bill-form-lines-extended.component";
+import DateTimePicker from "../form-date-time-picker/form-date-time-picker.component.jsx";
 import FormFieldsChanged from "../form-fields-changed-alert/form-fields-changed-alert.component";
 import CurrencyInput from "../form-items-formatted/currency-form-item.component";
 import JobSearchSelect from "../job-search-select/job-search-select.component";
@@ -21,8 +24,6 @@ import LayoutFormRow from "../layout-form-row/layout-form-row.component";
 import VendorSearchSelect from "../vendor-search-select/vendor-search-select.component";
 import BillFormLines from "./bill-form.lines.component";
 import { CalculateBillTotal } from "./bill-form.totals.utility";
-import DateTimePicker from "../form-date-time-picker/form-date-time-picker.component.jsx";
-import { bodyshopHasDmsKey } from "../../utils/dmsUtils.js";
 
 const mapStateToProps = createStructuredSelector({
   bodyshop: selectBodyshop
@@ -49,6 +50,8 @@ export function BillFormComponent({
   const { t } = useTranslation();
   const client = useApolloClient();
   const [discount, setDiscount] = useState(0);
+  const notification = useNotification();
+  const jobIdFormWatch = Form.useWatch("jobid", form);
 
   const {
     treatments: { Extended_Bill_Posting, ClosingPeriod }
@@ -124,6 +127,23 @@ export function BillFormComponent({
     bodyshop.inhousevendorid
   ]);
 
+  useEffect(() => {
+    console.log("*** Form Watch - jobid changed:", jobIdFormWatch);
+    if (jobIdFormWatch !== null) {
+      if (form.getFieldValue("jobid") !== null && form.getFieldValue("jobid") !== undefined) {
+        loadLines({ variables: { id: form.getFieldValue("jobid") } });
+        if (form.getFieldValue("vendorid") !== null && form.getFieldValue("vendorid") !== undefined) {
+          loadOutstandingReturns({
+            variables: {
+              jobId: form.getFieldValue("jobid"),
+              vendorId: form.getFieldValue("vendorid")
+            }
+          });
+        }
+      }
+    }
+  }, [jobIdFormWatch, form]);
+
   return (
     <div>
       <FormFieldsChanged form={form} />
@@ -375,7 +395,15 @@ export function BillFormComponent({
             ]);
             let totals;
             if (!!values.total && !!values.billlines && values.billlines.length > 0) {
-              totals = CalculateBillTotal(values);
+              try {
+                totals = CalculateBillTotal(values);
+              } catch (error) {
+                notification.error({
+                  title: "Error calculating totals",
+                  message: error.message || "An error occurred while calculating bill totals.",
+                  key: "bill_totals_calculation_error"
+                });
+              }
             }
 
             if (totals) {

client/src/components/bill-form/bill-form.lines.component.jsx

@@ -154,10 +154,10 @@ export function BillEnterModalLinesComponent({
                 label: t("billlines.fields.confidence")
               }),
               formInput: (record) => {
-                const confidenceValue = getFieldValue(["billlines", record.name, "confidence"]);
+                const rowValue = getFieldValue(["billlines", record.name]);
                 return (
                   <div style={{ display: "flex", alignItems: "center", justifyContent: "center" }}>
-                    <ConfidenceDisplay value={confidenceValue} />
+                    <ConfidenceDisplay rowValue={rowValue} />
                   </div>
                 );
               }
@@ -276,7 +276,20 @@ export function BillEnterModalLinesComponent({
           key: `${field.name}actual_price`,
           name: [field.name, "actual_price"],
           label: t("billlines.fields.actual_price"),
-          rules: [{ required: true }]
+          rules: [
+            { required: true },
+            {
+              validator: (_, value) => {
+                if (Math.abs(parseFloat(value)) < 0.01) {
+                  return Promise.reject();
+                } else {
+                  return Promise.resolve();
+                }
+              },
+              warningOnly: true
+            }
+          ],
+          hasFeedback: true
         }),
         formInput: (record, index) => (
           <CurrencyInput

client/src/components/bill-form/bill-form.lines.confidence.component.jsx

@@ -1,4 +1,4 @@
-import { Progress, Tag, Tooltip } from "antd";
+import { Progress, Space, Tag, Tooltip } from "antd";
 import { useTranslation } from "react-i18next";
 const parseConfidence = (confidenceStr) => {
   if (!confidenceStr || typeof confidenceStr !== "string") return null;
@@ -20,10 +20,11 @@ const getConfidenceColor = (value) => {
   return "red";
 };
 
-const ConfidenceDisplay = ({ value }) => {
+const ConfidenceDisplay = ({ rowValue: { confidence, actual_price, actual_cost } }) => {
   const { t } = useTranslation();
-  const parsed = parseConfidence(value);
-
+  const parsed = parseConfidence(confidence);
+  const parsed_actual_price = parseFloat(actual_price);
+  const parsed_actual_cost = parseFloat(actual_cost);
   if (!parsed) {
     return <span style={{ color: "#999", fontSize: "0.85em" }}>N/A</span>;
   }
@@ -71,9 +72,16 @@ const ConfidenceDisplay = ({ value }) => {
         </div>
       }
     >
-      <Tag color={color} style={{ margin: 0, cursor: "help", userSelect: "none" }}>
-        {total.toFixed(0)}%
-      </Tag>
+      <Space size="small">
+        {!parsed_actual_cost || !parsed_actual_price || parsed_actual_cost === 0 || parsed_actual_price === 0 ? (
+          <Tag color="red" style={{ margin: 0, cursor: "help", userSelect: "none" }}>
+            {t("billlines.confidence.missing_data", { defaultValue: "Missing Data" })}
+          </Tag>
+        ) : null}
+        <Tag color={color} style={{ margin: 0, cursor: "help", userSelect: "none" }}>
+          {total.toFixed(0)}%
+        </Tag>
+      </Space>
     </Tooltip>
   );
 };