Merged in release/2021-11-26 (pull request #278)

release/2021-11-26

Approved-by: Patrick Fic

client/src/components/dms-customer-selector/dms-customer-selector.component.jsx

@@ -86,11 +86,13 @@ export function DmsCustomerSelector({ bodyshop }) {
       //dataIndex: ["name2", "fullName"],
       key: "address",
       render: (record, value) =>
-        `${record.address && record.address.addressLine[0]}, ${
+        `${
-          record.address && record.address.city
+          record.address &&
-        } ${record.address && record.address.stateOrProvince} ${
+          record.address.addressLine &&
-          record.address && record.address.postalCode
+          record.address.addressLine[0]
-        }`,
+        }, ${record.address && record.address.city} ${
+          record.address && record.address.stateOrProvince
+        } ${record.address && record.address.postalCode}`,
     },
   ];
 

server/cdk/cdk-job-export.js

@@ -54,18 +54,21 @@ exports.default = async function (socket, { txEnvelope, jobid }) {
 
       const DMSVehCustomer =
         socket.DMSVeh &&
+        socket.DMSVeh.owners &&
         socket.DMSVeh.owners.find((o) => o.id.assigningPartyId === "CURRENT");
 
-      CdkBase.createLogEvent(
+      if (DMSVehCustomer && DMSVehCustomer.id && DMSVehCustomer.id.value) {
-        socket,
+        CdkBase.createLogEvent(
-        "DEBUG",
+          socket,
-        `{2.2} Querying the Customer using the ID from DMSVeh: ${DMSVehCustomer.id.value}`
+          "DEBUG",
-      );
+          `{2.2} Querying the Customer using the ID from DMSVeh: ${DMSVehCustomer.id.value}`
-      socket.DMSVehCustomer = await QueryDmsCustomerById(
+        );
-        socket,
+        socket.DMSVehCustomer = await QueryDmsCustomerById(
-        JobData,
+          socket,
-        DMSVehCustomer.id.value
+          JobData,
-      );
+          DMSVehCustomer.id.value
+        );
+      }
     }
 
     CdkBase.createLogEvent(
@@ -771,26 +774,44 @@ async function UpdateDmsVehicle(socket) {
 
     let ids = [];
 
-    const existingOwnerinVeh = socket.DMSVeh.owners.filter(
+    const existingOwnerinVeh =
-      (o) => o.id.value === socket.DMSCust.id.value
+      socket.DMSVeh &&
-    );
+      socket.DMSVeh.owners &&
+      socket.DMSVeh.owners.find((o) => o.id.value === socket.DMSCust.id.value);
 
     if (existingOwnerinVeh) {
-      ids = socket.DMSVeh.owners.filter(
+      ids = socket.DMSVeh.owners.map((o) => {
-        (o) => o.id.value === socket.DMSCust.id.value
+        return {
-      );
+          id: {
+            assigningPartyId:
+              o.id.value === socket.dmsCust.id.value ? "CURRENT" : "PREVIOUS",
+            value: o.id.value,
+          },
+        };
+      });
     } else {
+      const oldOwner =
+        socket.DMSVeh &&
+        socket.DMSVeh.owners &&
+        socket.DMSVeh.owners.find((o) => o.id.assigningPartyId === "CURRENT");
+
       ids = [
         {
-          assigningPartyId: "CURRENT",
+          id: {
-          value: socket.DMSCust.id.value,
+            assigningPartyId: "CURRENT",
+            value: socket.DMSCust.id.value,
+          },
         },
-        ...socket.DMSVeh.owners.map((o) => {
+        ...(oldOwner
-          return {
+          ? [
-            assigningPartyId: "PREVIOUS",
+              {
-            value: o.id.value,
+                id: {
-          };
+                  assigningPartyId: "PREVIOUS",
-        }),
+                  value: oldOwner.id.value,
+                },
+              },
+            ]
+          : []),
       ];
     }
 
@@ -812,7 +833,7 @@ async function UpdateDmsVehicle(socket) {
               socket.DMSVeh.vehicle.deliveryDate
             ).toISOString(),
           },
-          owners: { ids: ids },
+          owners: ids,
         },
         arg3: "VEHICLES",
       });