Merged in release/2023-06-02 (pull request #828)

Release/2023 06 02

client/src/components/jobs-detail-header-actions/jobs-detail-header-actions.component.jsx

@@ -29,6 +29,7 @@ import AddToProduction from "./jobs-detail-header-actions.addtoproduction.util";
 import JobsDetaiLheaderCsi from "./jobs-detail-header-actions.csi.component";
 import DuplicateJob from "./jobs-detail-header-actions.duplicate.util";
 import JobsDetailHeaderActionsExportcustdataComponent from "./jobs-detail-header-actions.exportcustdata.component";
+import RbacWrapper from "../rbac-wrapper/rbac-wrapper.component";
 
 const mapStateToProps = createStructuredSelector({
   bodyshop: selectBodyshop,
@@ -461,6 +462,7 @@ export function JobsDetailHeaderActions({
       )}
       <JobsDetailHeaderActionsAddevent jobid={job.id} />
       {!jobRO && job.converted && (
+        <RbacWrapper action="jobs:void" noauth>
           <Menu.Item>
             <Popconfirm
               title={t("jobs.labels.voidjob")}
@@ -509,6 +511,7 @@ export function JobsDetailHeaderActions({
               {t("menus.jobsactions.void")}
             </Popconfirm>
           </Menu.Item>
+        </RbacWrapper>
       )}
     </Menu>
   );

client/src/components/rbac-wrapper/rbac-defaults.js

@@ -26,6 +26,8 @@ const ret = {
   "jobs:partsqueue": 4,
   "jobs:checklist-view": 2,
   "jobs:list-ready": 1,
+  "jobs:void": 5,
+
   "bills:enter": 2,
   "bills:view": 2,
   "bills:list": 2,

client/src/components/shop-info/shop-info.rbac.component.jsx

@@ -1,12 +1,12 @@
+import { useTreatments } from "@splitsoftware/splitio-react";
 import { Form, InputNumber } from "antd";
 import React from "react";
 import { useTranslation } from "react-i18next";
-import LayoutFormRow from "../layout-form-row/layout-form-row.component";
-import RbacWrapper from "../rbac-wrapper/rbac-wrapper.component";
-import { useTreatments } from "@splitsoftware/splitio-react";
 import { connect } from "react-redux";
 import { createStructuredSelector } from "reselect";
 import { selectBodyshop } from "../../redux/user/user.selectors";
+import LayoutFormRow from "../layout-form-row/layout-form-row.component";
+import RbacWrapper from "../rbac-wrapper/rbac-wrapper.component";
 const mapStateToProps = createStructuredSelector({
   bodyshop: selectBodyshop,
 });
@@ -316,6 +316,18 @@ export function ShopInfoRbacComponent({ form, bodyshop }) {
         >
           <InputNumber />
         </Form.Item>
+        <Form.Item
+          label={t("bodyshop.fields.rbac.jobs.void")}
+          rules={[
+            {
+              required: true,
+              //message: t("general.validation.required"),
+            },
+          ]}
+          name={["md_rbac", "jobs:void"]}
+        >
+          <InputNumber />
+        </Form.Item>
         <Form.Item
           label={t("bodyshop.fields.rbac.bills.enter")}
           rules={[

client/src/translations/en_us/common.json

@@ -405,7 +405,8 @@
 						"list-active": "Jobs -> List Active",
 						"list-all": "Jobs -> List All",
 						"list-ready": "Jobs -> List Ready",
-						"partsqueue": "Jobs -> Parts Queue"
+						"partsqueue": "Jobs -> Parts Queue",
+						"void": "Jobs -> Void"
 					},
 					"owners": {
 						"detail": "Owners -> Detail",

client/src/translations/es/common.json

@@ -405,7 +405,8 @@
 						"list-active": "",
 						"list-all": "",
 						"list-ready": "",
-						"partsqueue": ""
+						"partsqueue": "",
+						"void": ""
 					},
 					"owners": {
 						"detail": "",

client/src/translations/fr/common.json

@@ -405,7 +405,8 @@
 						"list-active": "",
 						"list-all": "",
 						"list-ready": "",
-						"partsqueue": ""
+						"partsqueue": "",
+						"void": ""
 					},
 					"owners": {
 						"detail": "",

server/cdk/cdk-job-export.js

@@ -729,7 +729,13 @@ async function InsertDmsVehicle(socket) {
             deliveryDate: moment()
               // .tz(socket.JobData.bodyshop.timezone)
               .format("YYYYMMDD"),
-            licensePlateNo: String(socket.JobData.plate_no)
+            licensePlateNo:
+              socket.JobData.plate_no === null
+                ? null
+                : String(socket.JobData.plate_no).replace(/([^\w]|_)/g, "")
+                    .length === 0
+                ? null
+                : String(socket.JobData.plate_no)
                     .replace(/([^\w]|_)/g, "")
                     .toUpperCase(),
             make: socket.txEnvelope.dms_make,