feature/IO-3182-Phone-Number-Consent - Checkpoint

server/sms/receive.js

@@ -8,65 +8,27 @@ const {
 } = require("../graphql-client/queries");
 const { phone } = require("phone");
 const { admin } = require("../firebase/firebase-handler");
-const logger = require("../utils/logger");
 const InstanceManager = require("../utils/instanceMgr").default;
 
 /**
- * Generate an array of media URLs from the request body
- * @param body
- * @returns {null|*[]}
- */
-const generateMediaArray = (body) => {
-  const { NumMedia } = body;
-  if (parseInt(NumMedia) > 0) {
-    const ret = [];
-    for (let i = 0; i < parseInt(NumMedia); i++) {
-      ret.push(body[`MediaUrl${i}`]);
-    }
-    return ret;
-  } else {
-    return null;
-  }
-};
-
-/**
- * Handle errors during the message receiving process
- * @param req
- * @param error
- * @param res
- * @param context
- */
-const handleError = (req, error, res, context) => {
-  logger.log("sms-inbound-error", "ERROR", "api", null, {
-    msid: req.body.SmsMessageSid,
-    text: req.body.Body,
-    image: !!req.body.MediaUrl0,
-    image_path: generateMediaArray(req.body),
-    messagingServiceSid: req.body.MessagingServiceSid,
-    context,
-    error
-  });
-
-  res.status(500).json({ error: error.message || "Internal Server Error" });
-};
-
-/**
- * Receive an inbound SMS message
+ * Receive SMS messages from Twilio and process them
  * @param req
  * @param res
  * @returns {Promise<*>}
  */
 const receive = async (req, res) => {
   const {
+    logger,
     ioRedis,
-    ioHelpers: { getBodyshopRoom, getBodyshopConversationRoom }
+    ioHelpers: { getBodyshopRoom, getBodyshopConversationRoom },
+    sessionUtils: { getBodyshopFromRedis }
   } = req;
 
   const loggerData = {
     msid: req.body.SmsMessageSid,
     text: req.body.Body,
     image: !!req.body.MediaUrl0,
-    image_path: generateMediaArray(req.body)
+    image_path: generateMediaArray(req.body, logger)
   };
 
   logger.log("sms-inbound", "DEBUG", "api", null, loggerData);
@@ -92,30 +54,36 @@ const receive = async (req, res) => {
 
     const bodyshop = response.bodyshops[0];
 
-    // Step 2: Handle consent
-    const normalizedPhone = phone(req.body.From, "CA").phoneNumber.replace(/^\+1/, "");
-    const isStop = req.body.Body.toUpperCase().includes("STOP");
-    const consentStatus = isStop ? false : true;
-    const reason = isStop ? "Customer texted STOP" : "Inbound message received";
+    // Step 2: Check enforce_sms_consent
+    const bodyShopData = await getBodyshopFromRedis(bodyshopid);
+    const enforceConsent = bodyShopData?.enforce_sms_consent ?? false;
 
-    const consentResponse = await client.request(SET_PHONE_NUMBER_CONSENT, {
-      bodyshopid: bodyshop.id,
-      phone_number: normalizedPhone,
-      consent_status: consentStatus,
-      reason,
-      changed_by: "system"
-    });
+    // Step 3: Handle consent only if enforce_sms_consent is true
+    if (enforceConsent) {
+      const normalizedPhone = phone(req.body.From, "CA").phoneNumber.replace(/^\+1/, "");
+      const isStop = req.body.Body.toUpperCase().includes("STOP");
+      const consentStatus = isStop ? false : true;
+      const reason = isStop ? "Customer texted STOP" : "Inbound message received";
 
-    // Emit WebSocket event for consent change
-    const broadcastRoom = getBodyshopRoom(bodyshop.id);
-    ioRedis.to(broadcastRoom).emit("consent-changed", {
-      bodyshopId: bodyshop.id,
-      phone_number: normalizedPhone,
-      consent_status: consentStatus,
-      reason
-    });
+      const consentResponse = await client.request(SET_PHONE_NUMBER_CONSENT, {
+        bodyshopid: bodyshop.id,
+        phone_number: normalizedPhone,
+        consent_status: consentStatus,
+        reason,
+        changed_by: "system"
+      });
 
-    // Step 3: Process conversation
+      // Emit WebSocket event for consent change
+      const broadcastRoom = getBodyshopRoom(bodyshop.id);
+      ioRedis.to(broadcastRoom).emit("consent-changed", {
+        bodyshopId: bodyshop.id,
+        phone_number: normalizedPhone,
+        consent_status: consentStatus,
+        reason
+      });
+    }
+
+    // Step 4: Process conversation
     const sortedConversations = bodyshop.conversations.sort((a, b) => new Date(a.created_at) - new Date(b.created_at));
     const existingConversation = sortedConversations.length
       ? sortedConversations[sortedConversations.length - 1]
@@ -126,7 +94,7 @@ const receive = async (req, res) => {
       msid: req.body.SmsMessageSid,
       text: req.body.Body,
       image: !!req.body.MediaUrl0,
-      image_path: generateMediaArray(req.body),
+      image_path: generateMediaArray(req.body, logger),
       isoutbound: false,
       userid: null
     };
@@ -143,7 +111,7 @@ const receive = async (req, res) => {
       const newConversationResponse = await client.request(CREATE_CONVERSATION, {
         conversation: {
           bodyshopid: bodyshop.id,
-          phone_num: normalizedPhone,
+          phone_num: phone(req.body.From).phoneNumber,
           archived: false
         }
       });
@@ -153,7 +121,7 @@ const receive = async (req, res) => {
 
     newMessage.conversationid = conversationid;
 
-    // Step 4: Insert the message
+    // Step 5: Insert the message
     const insertresp = await client.request(INSERT_MESSAGE, {
       msg: newMessage,
       conversationid
@@ -166,7 +134,7 @@ const receive = async (req, res) => {
       throw new Error("Conversation data is missing from the response.");
     }
 
-    // Step 5: Notify clients
+    // Step 6: Notify clients
     const conversationRoom = getBodyshopConversationRoom({
       bodyshopId: conversation.bodyshop.id,
       conversationId: conversation.id
@@ -179,6 +147,7 @@ const receive = async (req, res) => {
       msid: message.sid
     };
 
+    const broadcastRoom = getBodyshopRoom(conversation.bodyshop.id);
     ioRedis.to(broadcastRoom).emit("new-message-summary", {
       ...commonPayload,
       existingConversation: !!existingConversation,
@@ -194,7 +163,7 @@ const receive = async (req, res) => {
       summary: false
     });
 
-    // Step 6: Send FCM notification
+    // Step 7: Send FCM notification
     const fcmresp = await admin.messaging().send({
       topic: `${message.conversation.bodyshop.imexshopid}-messaging`,
       notification: {
@@ -220,10 +189,51 @@ const receive = async (req, res) => {
 
     res.status(200).send("");
   } catch (e) {
-    handleError(req, e, res, "RECEIVE_MESSAGE");
+    handleError(req, e, res, "RECEIVE_MESSAGE", logger);
   }
 };
 
+/**
+ * Generate media array from the request body
+ * @param body
+ * @param logger
+ * @returns {null|*[]}
+ */
+const generateMediaArray = (body, logger) => {
+  const { NumMedia } = body;
+  if (parseInt(NumMedia) > 0) {
+    const ret = [];
+    for (let i = 0; i < parseInt(NumMedia); i++) {
+      ret.push(body[`MediaUrl${i}`]);
+    }
+    return ret;
+  } else {
+    return null;
+  }
+};
+
+/**
+ * Handle error logging and response
+ * @param req
+ * @param error
+ * @param res
+ * @param context
+ * @param logger
+ */
+const handleError = (req, error, res, context, logger) => {
+  logger.log("sms-inbound-error", "ERROR", "api", null, {
+    msid: req.body.SmsMessageSid,
+    text: req.body.Body,
+    image: !!req.body.MediaUrl0,
+    image_path: generateMediaArray(req.body, logger),
+    messagingServiceSid: req.body.MessagingServiceSid,
+    context,
+    error
+  });
+
+  res.status(500).json({ error: error.message || "Internal Server Error" });
+};
+
 module.exports = {
   receive
 };