From 5e19d53b29ea25bb77c8ff9b53b3bd52ac5b56de Mon Sep 17 00:00:00 2001
From: Patrick Fic <pfic@outlook.com>
Date: Thu, 16 Jan 2020 10:41:42 -0800
Subject: [PATCH] Fixed conversion enabled logic.

---
 _business_logic/documents.md                              | 8 ++++++++
 .../components/job-tombstone/job-tombstone.component.jsx  | 6 ++++--
 s3upload.js                                               | 2 +-
 3 files changed, 13 insertions(+), 3 deletions(-)
 create mode 100644 _business_logic/documents.md

diff --git a/_business_logic/documents.md b/_business_logic/documents.md
new file mode 100644
index 000000000..7291c0a58
--- /dev/null
+++ b/_business_logic/documents.md
@@ -0,0 +1,8 @@
+**S3 Folder Structure**
+/{shopID}/{jobID}/imagename.ext
+
+**Logic**
+1. Get a presigned URL by hitting our own express server with a unique key. 
+2. Use this presigned URL to upload an individual file. 
+3. Store the key + the bucket name to the documents record. 
+4. ???Figure out how to add thumbnails.
\ No newline at end of file
diff --git a/client/src/components/job-tombstone/job-tombstone.component.jsx b/client/src/components/job-tombstone/job-tombstone.component.jsx
index 0f56000e9..102b8f120 100644
--- a/client/src/components/job-tombstone/job-tombstone.component.jsx
+++ b/client/src/components/job-tombstone/job-tombstone.component.jsx
@@ -75,7 +75,9 @@ function JobTombstone({ job, ...otherProps }) {
   const tombstoneTitle = (
     <div>
       <Avatar size='large' alt='Vehicle Image' src={CarImage} />
-      {t("jobs.fields.ro_number") + " " + jobContext.ro_number ?? "0"}
+      {`${t("jobs.fields.ro_number")} ${
+        jobContext.ro_number ? jobContext.ro_number : t("general.labels.na")
+      }`}
     </div>
   );
 
@@ -99,7 +101,7 @@ function JobTombstone({ job, ...otherProps }) {
             <Button
               key='convert'
               type='dashed'
-              disabled={!jobContext.converted}
+              disabled={jobContext.converted}
               onClick={() => {
                 mutationConvertJob({
                   variables: { jobId: jobContext.id }
diff --git a/s3upload.js b/s3upload.js
index 263f781f3..2198196b7 100644
--- a/s3upload.js
+++ b/s3upload.js
@@ -11,7 +11,7 @@ const S3_BUCKET = process.env.bucket;
 // Now lets export this function so we can call it from somewhere else
 
 exports.sign_s3 = (req, res) => {
-  console.log("Hitting bucket:  " + S3_BUCKET);
+  console.log("Get S3 Signed Put for bucket: " + S3_BUCKET);
   const s3 = new aws.S3(); // Create a new instance of S3
   // if (!req.body.fileName || req.body.fileType) {
   //   console.log('req.body.fileName', req.body.fileName)