admin/bodyshop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IO-3255 Review comments.

Browse Source
This commit is contained in:
Patrick Fic
2025-08-27 11:50:00 -07:00
parent 5b400dce4f
commit 553c154e46
5 changed files with 38 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
server/integrations/partsManagement/endpoints/vehicleDamageEstimateChgRq.js
View File

@@ -38,7 +38,7 @@ const findJob = async (shopId, jobId, logger) => {
const extractUpdatedJobData = (rq) => {
const doc = rq.DocumentInfo || {};
const claim = rq.ClaimInfo || {};
//PF: In the full BMS world, much more can change.
const policyNo = claim.PolicyInfo?.PolicyInfo?.PolicyNum || claim.PolicyInfo?.PolicyNum || null;
const out = {
@@ -239,6 +239,7 @@ const partsManagementVehicleDamageEstimateChgRq = async (req, res) => {
}
}
// --- End fetch current notes ---
//PF: These are several different calls that can be pulled together to make the operation faster.
const updatedJobData = extractUpdatedJobData(rq);
const updatedLines = extractUpdatedJobLines(rq.AddsChgs, job.id, currentJobLineNotes);
@@ -246,10 +247,12 @@ const partsManagementVehicleDamageEstimateChgRq = async (req, res) => {
await client.request(UPDATE_JOB_BY_ID, { id: job.id, job: updatedJobData });
//PF: for changed lines, are they deleted and then reinserted?
//PF: Updated lines should get an upsert to update things like desc, price, etc.
if (deletedLineIds?.length || updatedSeqs?.length) {
const allToDelete = Array.from(new Set([...(deletedLineIds || []), ...(updatedSeqs || [])]));
if (allToDelete.length) {
await client.request(SOFT_DELETE_JOBLINES_BY_IDS, { jobid: job.id, unqSeqs: allToDelete });
await client.request(SOFT_DELETE_JOBLINES_BY_IDS, { jobid: job.id, unqSeqs: allToDelete }); //PF: appears to soft delete updated lines as well.
}
}