From 82c4320f0c9cba90ad0259760328210a3d130c48 Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Tue, 28 Jun 2022 16:04:34 -0700 Subject: [PATCH 1/7] Add paint mix data logging. --- server/mixdata/mixdata.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/mixdata/mixdata.js b/server/mixdata/mixdata.js index dd538ddd9..68ae77119 100644 --- a/server/mixdata/mixdata.js +++ b/server/mixdata/mixdata.js @@ -32,6 +32,8 @@ exports.mixdataUpload = async (req, res) => { explicitArray: false, }); + logger.log("job-mixdata-parse", "DEBUG", req.user.email, inboundRequest); + const ScaleType = DetermineScaleType(inboundRequest); const RoNumbersFromInboundRequest = GetListOfRos( inboundRequest, From f704fd5f56339a85636897d25b0d10ca2815c3df Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Tue, 28 Jun 2022 16:14:13 -0700 Subject: [PATCH 2/7] Added mix data logging. --- server/mixdata/mixdata.js | 1 + 1 file changed, 1 insertion(+) diff --git a/server/mixdata/mixdata.js b/server/mixdata/mixdata.js index 68ae77119..5d52f4e5b 100644 --- a/server/mixdata/mixdata.js +++ b/server/mixdata/mixdata.js @@ -78,6 +78,7 @@ exports.mixdataUpload = async (req, res) => { res.status(500).JSON(error); logger.log("job-mixdata-upload-error", "ERROR", null, null, { error: error.message, + ...error, }); } }; From 1d80153da1e81bcdef0f4fb578b52dbef85684f6 Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Tue, 28 Jun 2022 16:14:26 -0700 Subject: [PATCH 3/7] Added placeholder for paint codes on prod board. --- .../production-list-columns.data.js | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/client/src/components/production-list-columns/production-list-columns.data.js b/client/src/components/production-list-columns/production-list-columns.data.js index e09e98775..203dd9c46 100644 --- a/client/src/components/production-list-columns/production-list-columns.data.js +++ b/client/src/components/production-list-columns/production-list-columns.data.js @@ -1,5 +1,5 @@ import { PauseCircleOutlined } from "@ant-design/icons"; -import { Space } from "antd"; +import { Space, Tag } from "antd"; import i18n from "i18next"; import moment from "moment"; import React from "react"; @@ -530,6 +530,27 @@ const r = ({ technician, state, activeStatuses, bodyshop }) => { ), }, + //Added as a place holder for St Claude. Not implemented as it requires another join for a field used by only 1 client. + // { + // title: i18n.t("vehicles.fields.v_paint_codes", { number: "" }), + // dataIndex: "v_paint_codes", + // key: "v_paint_codes", + // render: (text, record) => + // record.vehicle?.v_paint_codes ? ( + // + // {Object.keys(record.vehicle.v_paint_codes) + // .filter( + // (key) => + // record.vehicle.v_paint_codes[key] !== "" && + // record.vehicle.v_paint_codes[key] !== null && + // record.vehicle.v_paint_codes[key] !== undefined + // ) + // .map((key, idx) => ( + // {record.vehicle.v_paint_codes[key]} + // ))} + // + // ) : null, + // }, ]; }; export default r; From d45f84afbd6b2951ef5183df7d1057122acd7367 Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Tue, 28 Jun 2022 16:24:49 -0700 Subject: [PATCH 4/7] Change firebase handler rejection logging. --- .../production-list-columns.data.js | 3 +-- server/firebase/firebase-handler.js | 8 +++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/client/src/components/production-list-columns/production-list-columns.data.js b/client/src/components/production-list-columns/production-list-columns.data.js index 203dd9c46..c3f8ecf88 100644 --- a/client/src/components/production-list-columns/production-list-columns.data.js +++ b/client/src/components/production-list-columns/production-list-columns.data.js @@ -1,8 +1,7 @@ import { PauseCircleOutlined } from "@ant-design/icons"; -import { Space, Tag } from "antd"; +import { Space } from "antd"; import i18n from "i18next"; import moment from "moment"; -import React from "react"; import { Link } from "react-router-dom"; import CurrencyFormatter from "../../utils/CurrencyFormatter"; import { TimeFormatter } from "../../utils/DateFormatter"; diff --git a/server/firebase/firebase-handler.js b/server/firebase/firebase-handler.js index 8fae9d96a..7221649ec 100644 --- a/server/firebase/firebase-handler.js +++ b/server/firebase/firebase-handler.js @@ -257,12 +257,14 @@ exports.validateFirebaseIdToken = async (req, res, next) => { return; } catch (error) { logger.log("api-unauthorized-call", "WARN", null, null, { - req, + path: req.path, + body: req.body, + type: "unauthroized", - error, + ...error, }); - res.status(403).send("Unauthorized"); + res.status(401).send("Unauthorized"); return; } }; From fb4b12233a497d41899acce468f8936385ecdb51 Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Wed, 29 Jun 2022 09:48:26 -0700 Subject: [PATCH 5/7] Update autohouse error logging. --- server/data/autohouse.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/data/autohouse.js b/server/data/autohouse.js index 92851602c..08fcc9815 100644 --- a/server/data/autohouse.js +++ b/server/data/autohouse.js @@ -198,7 +198,7 @@ const CreateRepairOrderTag = (job, errorCallback) => { if (!job.job_totals) { errorCallback({ - jobid: jobid, + jobid: job.id, ro_number: job.ro_number, error: { toString: () => "No job totals for RO." }, }); @@ -674,7 +674,7 @@ const CreateRepairOrderTag = (job, errorCallback) => { error, }); - errorCallback({ jobid: jobid, ro_number: job.ro_number, error }); + errorCallback({ jobid: job.id, ro_number: job.ro_number, error }); } }; From 037ff4c2a18b209d35ff9d7023d4a7573e17d7a5 Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Wed, 29 Jun 2022 10:54:19 -0700 Subject: [PATCH 6/7] Resolve email rendering issue with JSR Update. --- .../email-documents/email-documents.component.jsx | 6 ------ client/src/utils/RenderTemplate.js | 9 ++++----- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/client/src/components/email-documents/email-documents.component.jsx b/client/src/components/email-documents/email-documents.component.jsx index 7b3f393ae..7607e23e4 100644 --- a/client/src/components/email-documents/email-documents.component.jsx +++ b/client/src/components/email-documents/email-documents.component.jsx @@ -38,12 +38,6 @@ export function EmailDocumentsComponent({ nextFetchPolicy: "network-only", }); - console.log( - selectedMedia && - selectedMedia - .filter((s) => s.isSelected) - .reduce((acc, val) => (acc = acc + val.size), 0) - ); return (
{loading && } diff --git a/client/src/utils/RenderTemplate.js b/client/src/utils/RenderTemplate.js index c6d4a0ea9..acdfe1bf2 100644 --- a/client/src/utils/RenderTemplate.js +++ b/client/src/utils/RenderTemplate.js @@ -111,15 +111,16 @@ export default async function RenderTemplate( }; const pdfRender = await jsreport.render(pdfRequest); - pdf = pdfRender.toDataURI(); + pdf = await pdfRender.toDataURI(); } + const html = await render.toString(); return new Promise((resolve, reject) => { resolve({ pdf, filename: Templates[templateObject.name] && Templates[templateObject.name].title, - html: render.toString(), + html, }); }); } @@ -255,9 +256,7 @@ export async function RenderTemplates( if (!renderAsHtml) { render.download("Speed Print"); } else { - return new Promise((resolve, reject) => { - resolve(render.toString()); - }); + return render.toString(); } } catch (error) { notification["error"]({ message: JSON.stringify(error) }); From 39dbf40a49ca0a9c0d1c7cc446c8c31cb5c87ba8 Mon Sep 17 00:00:00 2001 From: Patrick Fic <> Date: Wed, 29 Jun 2022 15:05:03 -0700 Subject: [PATCH 7/7] IO-1967 Convert dollar amount to labor. --- bodyshop_translations.babel | 65 ++++- .../job-detail-lines/job-lines.component.jsx | 10 +- .../job-line-convert-to-labor.component.jsx | 244 ++++++++++++++++++ .../jobs-close-lines.component.jsx | 39 ++- client/src/graphql/jobs-lines.queries.js | 1 + client/src/graphql/jobs.queries.js | 2 + client/src/translations/en_us/common.json | 3 + client/src/translations/es/common.json | 3 + client/src/translations/fr/common.json | 3 + hasura/metadata/tables.yaml | 3 + .../down.sql | 4 + .../up.sql | 2 + 12 files changed, 365 insertions(+), 14 deletions(-) create mode 100644 client/src/components/job-line-convert-to-labor/job-line-convert-to-labor.component.jsx create mode 100644 hasura/migrations/1656527284493_alter_table_public_joblines_add_column_convertedtolbr/down.sql create mode 100644 hasura/migrations/1656527284493_alter_table_public_joblines_add_column_convertedtolbr/up.sql diff --git a/bodyshop_translations.babel b/bodyshop_translations.babel index 132e51f2b..0a0bddd67 100644 --- a/bodyshop_translations.babel +++ b/bodyshop_translations.babel @@ -1,4 +1,4 @@ - +