From 42427c456976a5551af310468b734f70a5b3c650 Mon Sep 17 00:00:00 2001 From: Dave Date: Fri, 17 Oct 2025 14:56:21 -0400 Subject: [PATCH] release/2025-10-17 - Refine Job Totals Logging (switch from error to warn for USA key issues, normalize case on logging level) --- server/job/job-totals-USA.js | 20 ++++++++++---------- server/job/job-totals.js | 14 +++++++------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/server/job/job-totals-USA.js b/server/job/job-totals-USA.js index dab44bf56..f875c3551 100644 --- a/server/job/job-totals-USA.js +++ b/server/job/job-totals-USA.js @@ -24,7 +24,7 @@ exports.totalsSsu = async function (req, res) { const BearerToken = req.BearerToken; const client = req.userGraphQLClient; - logger.log("job-totals-ssu-USA", "DEBUG", req?.user?.email, id); + logger.log("job-totals-ssu-USA", "debug", req?.user?.email, id); try { const job = await client.setHeaders({ Authorization: BearerToken }).request(queries.GET_JOB_BY_PK, { @@ -49,7 +49,7 @@ exports.totalsSsu = async function (req, res) { res.status(200).send(); } catch (error) { - logger.log("job-totals-ssu-USA-error", "ERROR", req?.user?.email, id, { + logger.log("job-totals-ssu-USA-error", "error", req?.user?.email, id, { jobid: id, error: error.message, stack: error.stack @@ -95,7 +95,7 @@ async function TotalsServerSide(req, res) { ret.totals.subtotal = ret.totals.subtotal.add(ret.totals.ttl_adjustment); ret.totals.total_repairs = ret.totals.total_repairs.add(ret.totals.ttl_adjustment); ret.totals.net_repairs = ret.totals.net_repairs.add(ret.totals.ttl_adjustment); - logger.log("job-totals-USA-ttl-adj", "DEBUG", null, job.id, { + logger.log("job-totals-USA-ttl-adj", "debug", null, job.id, { adjAmount: ttlDifference }); } @@ -116,7 +116,7 @@ async function TotalsServerSide(req, res) { ret.totals.ttl_tax_adjustment = Dinero({ amount: Math.round(ttlTaxDifference * 100) }); ret.totals.total_repairs = ret.totals.total_repairs.add(ret.totals.ttl_tax_adjustment); ret.totals.net_repairs = ret.totals.net_repairs.add(ret.totals.ttl_tax_adjustment); - logger.log("job-totals-USA-ttl-tax-adj", "DEBUG", null, job.id, { + logger.log("job-totals-USA-ttl-tax-adj", "debug", null, job.id, { adjAmount: ttlTaxDifference }); } @@ -124,7 +124,7 @@ async function TotalsServerSide(req, res) { return ret; } catch (error) { - logger.log("job-totals-ssu-USA-error", "ERROR", req.user?.email, job.id, { + logger.log("job-totals-ssu-USA-error", "error", req.user?.email, job.id, { jobid: job.id, error: error.message, stack: error.stack @@ -142,7 +142,7 @@ async function Totals(req, res) { const logger = req.logger; const client = req.userGraphQLClient; - logger.log("job-totals-ssu-USA", "DEBUG", req.user.email, job.id, { + logger.log("job-totals-ssu-USA", "debug", req.user.email, job.id, { jobid: job.id, id: id }); @@ -159,7 +159,7 @@ async function Totals(req, res) { res.status(200).json(ret); } catch (error) { - logger.log("job-totals-ssu-USA-error", "ERROR", req.user.email, job.id, { + logger.log("job-totals-ssu-USA-error", "error", req.user.email, job.id, { jobid: job.id, error: error.message, stack: error.stack @@ -240,7 +240,7 @@ async function AtsAdjustmentsIfRequired({ job, client, user }) { job.joblines.push(newAtsLine); } } catch (error) { - logger.log("job-totals-ssu-ats-error", "ERROR", user?.email, job.id, { + logger.log("job-totals-ssu-ats-error", "error", user?.email, job.id, { jobid: job.id, error: error.message, stack: error.stack @@ -258,7 +258,7 @@ async function AtsAdjustmentsIfRequired({ job, client, user }) { job.joblines[atsLineIndex].act_price = atsAmount; } } catch (error) { - logger.log("job-totals-ssu-ats-error", "ERROR", user?.email, job.id, { + logger.log("job-totals-ssu-ats-error", "error", user?.email, job.id, { jobid: job.id, atsLineIndex: atsLineIndex, atsAmount: atsAmount, @@ -1055,7 +1055,7 @@ function CalculateTaxesTotals(job, otherTotals) { } } } catch (error) { - logger.log("job-totals-USA Key with issue", "error", null, job.id, { + logger.log("job-totals-USA Key with issue", "warn", null, job.id, { key: key, error: error.message, stack: error.stack diff --git a/server/job/job-totals.js b/server/job/job-totals.js index 5f28ac067..b6617b18c 100644 --- a/server/job/job-totals.js +++ b/server/job/job-totals.js @@ -23,7 +23,7 @@ exports.totalsSsu = async function (req, res) { const BearerToken = req.BearerToken; const client = req.userGraphQLClient; - logger.log("job-totals-ssu", "DEBUG", req.user.email, id, null); + logger.log("job-totals-ssu", "debug", req.user.email, id, null); try { const job = await client.setHeaders({ Authorization: BearerToken }).request(queries.GET_JOB_BY_PK, { @@ -49,7 +49,7 @@ exports.totalsSsu = async function (req, res) { res.status(200).send(); } catch (error) { - logger.log("job-totals-ssu-error", "ERROR", req.user.email, id, { + logger.log("job-totals-ssu-error", "error", req.user.email, id, { jobid: id, error: error.message, stack: error.stack @@ -73,7 +73,7 @@ async function TotalsServerSide(req, res) { return ret; } catch (error) { - logger.log("job-totals-ssu-error", "ERROR", req?.user?.email, job.id, { + logger.log("job-totals-ssu-error", "error", req?.user?.email, job.id, { jobid: job.id, error: error.message, stack: error.stack @@ -91,7 +91,7 @@ async function Totals(req, res) { const logger = req.logger; const client = req.userGraphQLClient; - logger.log("job-totals-ssu", "DEBUG", req.user.email, job.id, { + logger.log("job-totals-ssu", "debug", req.user.email, job.id, { jobid: job.id, id: id }); @@ -108,7 +108,7 @@ async function Totals(req, res) { res.status(200).json(ret); } catch (error) { - logger.log("job-totals-ssu-error", "ERROR", req.user.email, job.id, { + logger.log("job-totals-ssu-error", "error", req.user.email, job.id, { jobid: job.id, error: error.message, stack: error.stack @@ -189,7 +189,7 @@ async function AtsAdjustmentsIfRequired({ job, client, user }) { job.joblines.push(newAtsLine); } } catch (error) { - logger.log("job-totals-ssu-ats-error", "ERROR", user?.email, job.id, { + logger.log("job-totals-ssu-ats-error", "error", user?.email, job.id, { jobid: job.id, error: error.message, stack: error.stack @@ -207,7 +207,7 @@ async function AtsAdjustmentsIfRequired({ job, client, user }) { job.joblines[atsLineIndex].act_price = atsAmount; } } catch (error) { - logger.log("job-totals-ssu-ats-error", "ERROR", user?.email, job.id, { + logger.log("job-totals-ssu-ats-error", "error", user?.email, job.id, { jobid: job.id, atsLineIndex: atsLineIndex, atsAmount: atsAmount,