Lint all the things

server/sms/receive.js

@@ -291,7 +291,13 @@ const receive = async (req, res) => {
 
     res.status(200).send("");
   } catch (e) {
-    handleError(req, e, res, "RECEIVE_MESSAGE", logger);
+    handleError({
+      req,
+      res,
+      logger,
+      error: e,
+      context: "RECEIVE_MESSAGE"
+    });
   }
 };
 
@@ -301,11 +307,11 @@ const receive = async (req, res) => {
  * @param logger
  * @returns {null|*[]}
  */
-const generateMediaArray = (body, logger) => {
+const generateMediaArray = (body) => {
   const { NumMedia } = body;
-  if (parseInt(NumMedia) > 0) {
+  if (parseInt(NumMedia, 10) > 0) {
     const ret = [];
-    for (let i = 0; i < parseInt(NumMedia); i++) {
+    for (let i = 0; i < parseInt(NumMedia, 10); i++) {
       ret.push(body[`MediaUrl${i}`]);
     }
     return ret;
@@ -322,7 +328,7 @@ const generateMediaArray = (body, logger) => {
  * @param context
  * @param logger
  */
-const handleError = (req, error, res, context, logger) => {
+const handleError = ({ req, error, res, context, logger }) => {
   logger.log("sms-inbound-error", "ERROR", "api", null, {
     msid: req.body.SmsMessageSid,
     text: req.body.Body,

server/sms/send.js

@@ -11,7 +11,7 @@ const gqlClient = require("../graphql-client/graphql-client").client;
  * @returns {Promise<void>}
  */
 const send = async (req, res) => {
-  const { to, messagingServiceSid, body, conversationid, selectedMedia, imexshopid } = req.body;
+  const { to, messagingServiceSid, body, conversationid, selectedMedia } = req.body;
   const {
     ioRedis,
     logger,

server/sms/status.js

@@ -139,7 +139,7 @@ const status = async (req, res) => {
 const markConversationRead = async (req, res) => {
   const {
     ioRedis,
-    ioHelpers: { getBodyshopRoom, getBodyshopConversationRoom }
+    ioHelpers: { getBodyshopRoom }
   } = req;
   const { conversation, imexshopid, bodyshopid } = req.body;