Lint all the things

server/accounting/qbo/qbo-payables.js

@@ -19,7 +19,7 @@ exports.default = async (req, res) => {
     clientId: process.env.QBO_CLIENT_ID,
     clientSecret: process.env.QBO_SECRET,
     environment: process.env.NODE_ENV === "production" ? "production" : "sandbox",
-    redirectUri: process.env.QBO_REDIRECT_URI,
+    redirectUri: process.env.QBO_REDIRECT_URI
   });
 
   try {
@@ -65,36 +65,34 @@ exports.default = async (req, res) => {
           vendorRecord = await InsertVendorRecord(oauthClient, qbo_realmId, req, bill);
         }
 
-        const insertResults = await InsertBill(oauthClient, qbo_realmId, req, bill, vendorRecord, bodyshop);
+        await InsertBill(oauthClient, qbo_realmId, req, bill, vendorRecord, bodyshop);
 
         // //No error. Mark the job exported & insert export log.
         if (elgen) {
-          const result = await client
-            .setHeaders({ Authorization: BearerToken })
-            .request(queries.QBO_MARK_BILL_EXPORTED, {
-              billId: bill.id,
-              bill: {
-                exported: true,
-                exported_at: moment().tz(bodyshop.timezone)
-              },
-              logs: [
-                {
-                  bodyshopid: bodyshop.id,
-                  billid: bill.id,
-                  successful: true,
-                  useremail: req.user.email
-                }
-              ]
-            });
+          await client.setHeaders({ Authorization: BearerToken }).request(queries.QBO_MARK_BILL_EXPORTED, {
+            billId: bill.id,
+            bill: {
+              exported: true,
+              exported_at: moment().tz(bodyshop.timezone)
+            },
+            logs: [
+              {
+                bodyshopid: bodyshop.id,
+                billid: bill.id,
+                successful: true,
+                useremail: req.user.email
+              }
+            ]
+          });
         }
 
         ret.push({ billid: bill.id, success: true });
       } catch (error) {
         logger.log("qbo-paybles-create-error", "ERROR", req.user.email, null, {
           error:
-            (error && error.authResponse && error.authResponse.body) ||
+            (error?.authResponse && error.authResponse.body) ||
             error.response?.data?.Fault?.Error.map((e) => e.Detail).join(", ") ||
-            (error && error.message)
+            error?.message
         });
         ret.push({
           billid: bill.id,
@@ -107,7 +105,7 @@ exports.default = async (req, res) => {
 
         //Add the export log error.
         if (elgen) {
-          const result = await client.setHeaders({ Authorization: BearerToken }).request(queries.INSERT_EXPORT_LOG, {
+          await client.setHeaders({ Authorization: BearerToken }).request(queries.INSERT_EXPORT_LOG, {
             logs: [
               {
                 bodyshopid: bodyshop.id,
@@ -141,7 +139,9 @@ async function QueryVendorRecord(oauthClient, qbo_realmId, req, bill) {
       url: urlBuilder(
         qbo_realmId,
         "query",
-        `select * From vendor where DisplayName = '${StandardizeName(bill.vendor.name)}'`
+        `select *
+         From vendor
+         where DisplayName = '${StandardizeName(bill.vendor.name)}'`
       ),
       method: "POST",
       headers: {
@@ -156,7 +156,7 @@ async function QueryVendorRecord(oauthClient, qbo_realmId, req, bill) {
       status: result.response?.status,
       bodyshopid: bill.job.shopid,
       email: req.user.email
-    })
+    });
     setNewRefreshToken(req.user.email, result);
     return (
       result.json &&
@@ -194,7 +194,7 @@ async function InsertVendorRecord(oauthClient, qbo_realmId, req, bill) {
       status: result.response?.status,
       bodyshopid: bill.job.shopid,
       email: req.user.email
-    })
+    });
     setNewRefreshToken(req.user.email, result);
     return result && result.json && result.json.Vendor;
   } catch (error) {
@@ -263,11 +263,11 @@ async function InsertBill(oauthClient, qbo_realmId, req, bill, vendor, bodyshop)
       .format("YYYY-MM-DD"),
     ...(!bill.is_credit_memo &&
       bill.vendor.due_date && {
-      DueDate: moment(bill.date)
-        //.tz(bill.job.bodyshop.timezone)
-        .add(bill.vendor.due_date, "days")
-        .format("YYYY-MM-DD")
-    }),
+        DueDate: moment(bill.date)
+          //.tz(bill.job.bodyshop.timezone)
+          .add(bill.vendor.due_date, "days")
+          .format("YYYY-MM-DD")
+      }),
     DocNumber: bill.invoice_number,
     //...(bill.job.class ? { ClassRef: { Id: classes[bill.job.class] } } : {}),
     ...(!(
@@ -280,8 +280,8 @@ async function InsertBill(oauthClient, qbo_realmId, req, bill, vendor, bodyshop)
       : {}),
     ...(bodyshop.accountingconfig.qbo_departmentid &&
       bodyshop.accountingconfig.qbo_departmentid.trim() !== "" && {
-      DepartmentRef: { value: bodyshop.accountingconfig.qbo_departmentid }
-    }),
+        DepartmentRef: { value: bodyshop.accountingconfig.qbo_departmentid }
+      }),
     PrivateNote: `RO ${bill.job.ro_number || ""}`,
     Line: lines
   };
@@ -305,7 +305,7 @@ async function InsertBill(oauthClient, qbo_realmId, req, bill, vendor, bodyshop)
       status: result.response?.status,
       bodyshopid: bill.job.shopid,
       email: req.user.email
-    })
+    });
     setNewRefreshToken(req.user.email, result);
     return result && result.json && result.json.Bill;
   } catch (error) {
@@ -353,8 +353,8 @@ const generateBillLine = (
         accountingconfig.qbo && accountingconfig.qbo_usa && region_config.includes("CA_")
           ? {}
           : {
-            value: taxCodes[findTaxCode(billLine.applicable_taxes, ioSalesTaxCodes)]
-          },
+              value: taxCodes[findTaxCode(billLine.applicable_taxes, ioSalesTaxCodes)]
+            },
       AccountRef: {
         value: accounts[account.accountname]
       }
@@ -373,7 +373,9 @@ async function QueryMetaData(oauthClient, qbo_realmId, req, bodyshopid) {
     url: urlBuilder(
       qbo_realmId,
       "query",
-      `select * From Account where AccountType in ('Cost of Goods Sold', 'Other Current Liability')`
+      `select *
+       From Account
+       where AccountType in ('Cost of Goods Sold', 'Other Current Liability')`
     ),
     method: "POST",
     headers: {
@@ -387,10 +389,15 @@ async function QueryMetaData(oauthClient, qbo_realmId, req, bodyshopid) {
     status: accounts.response?.status,
     bodyshopid,
     email: req.user.email
-  })
+  });
   setNewRefreshToken(req.user.email, accounts);
   const taxCodes = await oauthClient.makeApiCall({
-    url: urlBuilder(qbo_realmId, "query", `select * From TaxCode`),
+    url: urlBuilder(
+      qbo_realmId,
+      "query",
+      `select *
+                                           From TaxCode`
+    ),
     method: "POST",
     headers: {
       "Content-Type": "application/json"
@@ -403,9 +410,14 @@ async function QueryMetaData(oauthClient, qbo_realmId, req, bodyshopid) {
     status: taxCodes.status,
     bodyshopid,
     email: req.user.email
-  })
+  });
   const classes = await oauthClient.makeApiCall({
-    url: urlBuilder(qbo_realmId, "query", `select * From Class`),
+    url: urlBuilder(
+      qbo_realmId,
+      "query",
+      `select *
+                                           From Class`
+    ),
     method: "POST",
     headers: {
       "Content-Type": "application/json"
@@ -418,7 +430,7 @@ async function QueryMetaData(oauthClient, qbo_realmId, req, bodyshopid) {
     status: classes.status,
     bodyshopid,
     email: req.user.email
-  })
+  });
   const taxCodeMapping = {};
 
   taxCodes.json &&