Lint all the things

client/src/components/job-totals-table/job-totals-table.component.jsx

@@ -1,7 +1,4 @@
 import { Card, Col, Collapse, Result, Row } from "antd";
-//import { JsonEditor as Editor } from "jsoneditor-react";
-//import "jsoneditor-react/es/editor.min.css";
-import React from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
 import { createStructuredSelector } from "reselect";
@@ -27,7 +24,7 @@ const colSpan = {
 export function JobsTotalsTableComponent({ jobRO, currentUser, job }) {
   const { t } = useTranslation();
 
-  if (!!!job.job_totals) {
+  if (!job.job_totals) {
     return (
       <Card>
         <Result title={t("jobs.errors.nofinancial")} extra={<JobCalculateTotals job={job} disabled={jobRO} />} />
@@ -74,8 +71,8 @@ export function JobsTotalsTableComponent({ jobRO, currentUser, job }) {
                         <pre>
                           {JSON.stringify(
                             {
-                              CIECA: job.cieca_ttl && job.cieca_ttl.data,
-                              CIECASTL: job.cieca_stl && job.cieca_stl.data,
+                              CIECA: job.cieca_ttl?.data,
+                              CIECASTL: job.cieca_stl?.data,
                               ImEXCalc: job.job_totals
                             },
                             null,

client/src/components/job-totals-table/job-totals.table.labor.component.jsx

@@ -1,6 +1,6 @@
 import { Space, Table } from "antd";
 import Dinero from "dinero.js";
-import React, { useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
 import CurrencyFormatter from "../../utils/CurrencyFormatter";
 import InstanceRenderManager from "../../utils/instanceRenderMgr";
@@ -142,16 +142,14 @@ export default function JobTotalsTableLabor({ job }) {
                 {t("jobs.labels.mapa")}
                 {InstanceRenderManager({
                   imex:
-                    job.materials &&
-                    job.materials.mapa &&
+                    job.materials?.mapa &&
                     job.materials.mapa.cal_maxdlr &&
                     job.materials.mapa.cal_maxdlr > 0 &&
                     t("jobs.labels.threshhold", {
                       amount: job.materials.mapa.cal_maxdlr
                     }),
                   rome:
-                    job.materials &&
-                    job.materials.MAPA &&
+                    job.materials?.MAPA &&
                     job.materials.MAPA.cal_maxdlr !== undefined &&
                     t("jobs.labels.threshhold", {
                       amount: job.materials.MAPA.cal_maxdlr
@@ -165,11 +163,9 @@ export default function JobTotalsTableLabor({ job }) {
             <Table.Summary.Cell>{job.job_totals.rates.mapa.hours.toFixed(1)}</Table.Summary.Cell>
             {InstanceRenderManager({
               imex: (
-                <>
-                  <Table.Summary.Cell align="right">
-                    {Dinero(job.job_totals.rates.mapa.total).toFormat()}
-                  </Table.Summary.Cell>
-                </>
+                <Table.Summary.Cell align="right">
+                  {Dinero(job.job_totals.rates.mapa.total).toFormat()}
+                </Table.Summary.Cell>
               ),
               rome: (
                 <>
@@ -192,16 +188,14 @@ export default function JobTotalsTableLabor({ job }) {
                 {t("jobs.labels.mash")}
                 {InstanceRenderManager({
                   imex:
-                    job.materials &&
-                    job.materials.mash &&
+                    job.materials?.mash &&
                     job.materials.mash.cal_maxdlr &&
                     job.materials.mash.cal_maxdlr > 0 &&
                     t("jobs.labels.threshhold", {
                       amount: job.materials.mash.cal_maxdlr
                     }),
                   rome:
-                    job.materials &&
-                    job.materials.MASH &&
+                    job.materials?.MASH &&
                     job.materials.MASH.cal_maxdlr !== undefined &&
                     t("jobs.labels.threshhold", {
                       amount: job.materials.MASH.cal_maxdlr
@@ -215,11 +209,9 @@ export default function JobTotalsTableLabor({ job }) {
             <Table.Summary.Cell>{job.job_totals.rates.mash.hours.toFixed(1)}</Table.Summary.Cell>
             {InstanceRenderManager({
               imex: (
-                <>
-                  <Table.Summary.Cell align="right">
-                    {Dinero(job.job_totals.rates.mash.total).toFormat()}
-                  </Table.Summary.Cell>
-                </>
+                <Table.Summary.Cell align="right">
+                  {Dinero(job.job_totals.rates.mash.total).toFormat()}
+                </Table.Summary.Cell>
               ),
               rome: (
                 <>

client/src/components/job-totals-table/job-totals.table.other.component.jsx

@@ -1,6 +1,6 @@
 import { Table } from "antd";
 import Dinero from "dinero.js";
-import React, { useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { alphaSort } from "../../utils/sorters";
 

client/src/components/job-totals-table/job-totals.table.parts.component.jsx

@@ -1,6 +1,6 @@
 import { Table } from "antd";
 import Dinero from "dinero.js";
-import React, { useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { alphaSort } from "../../utils/sorters";
 

client/src/components/job-totals-table/job-totals.table.totals.component.jsx

@@ -1,6 +1,6 @@
 import { Table } from "antd";
 import Dinero from "dinero.js";
-import React, { useMemo } from "react";
+import { useMemo } from "react";
 import { useTranslation } from "react-i18next";
 
 import { connect } from "react-redux";
@@ -13,7 +13,7 @@ const mapStateToProps = createStructuredSelector({
   //currentUser: selectCurrentUser
   bodyshop: selectBodyshop
 });
-const mapDispatchToProps = (dispatch) => ({
+const mapDispatchToProps = () => ({
   //setUserLanguage: language => dispatch(setUserLanguage(language))
 });
 export default connect(mapStateToProps, mapDispatchToProps)(JobTotalsTableTotals);
@@ -181,7 +181,7 @@ export function JobTotalsTableTotals({ bodyshop, job }) {
             total: job.job_totals.totals.custPayable.federal_tax
           }
         ],
-        rome: [],
+        rome: []
       }),
       {
         key: t("jobs.fields.other_amount_payable"),
@@ -219,7 +219,6 @@ export function JobTotalsTableTotals({ bodyshop, job }) {
       }
     ];
     // TODO: was removed by Patrick during a CI bug fix.
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [job.job_totals, job.cieca_pft, t, bodyshop.md_responsibility_centers]);
 
   const columns = [
@@ -228,7 +227,7 @@ export function JobTotalsTableTotals({ bodyshop, job }) {
       dataIndex: "key",
       key: "key",
       width: "80%",
-      onCell: (record, rowIndex) => {
+      onCell: (record) => {
         return { style: { fontWeight: record.bold && "bold" } };
       }
     },
@@ -239,7 +238,7 @@ export function JobTotalsTableTotals({ bodyshop, job }) {
       align: "right",
       render: (text, record) => (record.render ? record.render : Dinero(record.total).toFormat()),
       width: "20%",
-      onCell: (record, rowIndex) => {
+      onCell: (record) => {
         return { style: { fontWeight: record.bold && "bold" } };
       }
     }

client/src/components/job-totals-table/jobs-totals.cash-discount-display.component.jsx

@@ -1,7 +1,7 @@
 import { Spin } from "antd";
 import axios from "axios";
 import Dinero from "dinero.js";
-import React, { useCallback, useEffect, useState } from "react";
+import { useCallback, useEffect, useState } from "react";
 
 import { connect } from "react-redux";
 import { createStructuredSelector } from "reselect";
@@ -11,7 +11,7 @@ import { useNotification } from "../../contexts/Notifications/notificationContex
 const mapStateToProps = createStructuredSelector({
   bodyshop: selectBodyshop
 });
-const mapDispatchToProps = (dispatch) => ({});
+const mapDispatchToProps = () => ({});
 export default connect(mapStateToProps, mapDispatchToProps)(JobTotalsCashDiscount);
 
 export function JobTotalsCashDiscount({ bodyshop, amountDinero }) {