Lint all the things

2025-08-19 16:23:29 -04:00
parent f6d6b548be
commit 33fb60ca1a
640 changed files with 2129 additions and 3927 deletions
--- a/client/src/components/bill-form/bill-form.component.jsx
+++ b/client/src/components/bill-form/bill-form.component.jsx
@@ -2,7 +2,7 @@ import Icon, { UploadOutlined } from "@ant-design/icons";
 import { useApolloClient } from "@apollo/client";
 import { useSplitTreatments } from "@splitsoftware/splitio-react";
 import { Alert, Divider, Form, Input, Select, Space, Statistic, Switch, Upload } from "antd";
-import React, { useEffect, useState } from "react";
+import { useEffect, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { MdOpenInNew } from "react-icons/md";
 import { connect } from "react-redux";
@@ -26,7 +26,7 @@ import DateTimePicker from "../form-date-time-picker/form-date-time-picker.compo
 const mapStateToProps = createStructuredSelector({
  bodyshop: selectBodyshop
 });
-const mapDispatchToProps = (dispatch) => ({});
+const mapDispatchToProps = () => ({});

 export function BillFormComponent({
  bodyshop,
@@ -254,7 +254,7 @@ export function BillFormComponent({
              required: true
              //message: t("general.validation.required"),
            },
-            ({ getFieldValue }) => ({
+            () => ({
              validator(rule, value) {
                if (ClosingPeriod.treatment === "on" && bodyshop.accountingconfig.ClosingPeriod) {
                  if (
@@ -374,8 +374,10 @@ export function BillFormComponent({
            let totals;
            if (!!values.total && !!values.billlines && values.billlines.length > 0)
              totals = CalculateBillTotal(values);
-            if (!!totals)
+            if (totals)
              return (
+                // TODO: Align is not correct
+                // eslint-disable-next-line react/no-unknown-property
                <div align="right">
                  <Space size="large" wrap>
                    <Statistic title={t("bills.labels.subtotal")} value={totals.subtotal.toFormat()} precision={2} />
@@ -458,7 +460,7 @@ export function BillFormComponent({
          if (Array.isArray(e)) {
            return e;
          }
-          return e && e.fileList;
+          return e?.fileList;
        }}
      >
        <Upload.Dragger multiple={true} name="logo" beforeUpload={() => false} listType="picture">
--- a/client/src/components/bill-form/bill-form.container.jsx
+++ b/client/src/components/bill-form/bill-form.container.jsx
@@ -1,6 +1,5 @@
 import { useLazyQuery, useQuery } from "@apollo/client";
 import { useSplitTreatments } from "@splitsoftware/splitio-react";
-import React from "react";
 import { connect } from "react-redux";
 import { createStructuredSelector } from "reselect";
 import { QUERY_OUTSTANDING_INVENTORY } from "../../graphql/inventory.queries";
--- a/client/src/components/bill-form/bill-form.lines.component.jsx
+++ b/client/src/components/bill-form/bill-form.lines.component.jsx
@@ -1,7 +1,6 @@
 import { DeleteFilled, DollarCircleFilled } from "@ant-design/icons";
 import { useSplitTreatments } from "@splitsoftware/splitio-react";
 import { Button, Checkbox, Form, Input, InputNumber, Select, Space, Switch, Table, Tooltip } from "antd";
-import React from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
 import { createStructuredSelector } from "reselect";
@@ -16,7 +15,7 @@ const mapStateToProps = createStructuredSelector({
  //currentUser: selectCurrentUser
  bodyshop: selectBodyshop
 });
-const mapDispatchToProps = (dispatch) => ({
+const mapDispatchToProps = () => ({
  //setUserLanguage: language => dispatch(setUserLanguage(language))
 });

@@ -27,8 +26,7 @@ export function BillEnterModalLinesComponent({
  discount,
  form,
  responsibilityCenters,
-  billEdit,
-  billid
+  billEdit
 }) {
  const { t } = useTranslation();
  const { setFieldsValue, getFieldsValue, getFieldValue } = form;
@@ -126,7 +124,7 @@ export function BillEnterModalLinesComponent({
            ]
          };
        },
-        formInput: (record, index) => <Input.TextArea disabled={disabled} autoSize />
+        formInput: () => <Input.TextArea disabled={disabled} autoSize />
      },
      {
        title: t("billlines.fields.quantity"),
@@ -158,7 +156,7 @@ export function BillEnterModalLinesComponent({
            ]
          };
        },
-        formInput: (record, index) => <InputNumber precision={0} min={1} disabled={disabled} />
+        formInput: () => <InputNumber precision={0} min={1} disabled={disabled} />
      },
      {
        title: t("billlines.fields.actual_price"),
@@ -188,7 +186,7 @@ export function BillEnterModalLinesComponent({
                  if (idx === index) {
                    return {
                      ...item,
-                      actual_cost: !!item.actual_cost
+                      actual_cost: item.actual_cost
                        ? item.actual_cost
                        : Math.round((parseFloat(e.target.value) * (1 - discount) + Number.EPSILON) * 100) / 100
                    };
@@ -258,7 +256,7 @@ export function BillEnterModalLinesComponent({
              <Form.Item shouldUpdate noStyle>
                {() => {
                  const line = getFieldsValue(["billlines"]).billlines[index];
-                  if (!!!line) return null;
+                  if (!line) return null;
                  let lineDiscount = 1 - line.actual_cost / line.actual_price;
                  if (isNaN(lineDiscount)) lineDiscount = 0;
                  return (
@@ -322,7 +320,7 @@ export function BillEnterModalLinesComponent({
            ]
          };
        },
-        formInput: (record, index) => (
+        formInput: () => (
          <Select showSearch style={{ minWidth: "3rem" }} disabled={disabled}>
            {bodyshop.cdk_dealerid || bodyshop.pbs_serialnumber
              ? CiecaSelect(true, false)
@@ -344,7 +342,7 @@ export function BillEnterModalLinesComponent({
                  name: [field.name, "location"]
                };
              },
-              formInput: (record, index) => (
+              formInput: () => (
                <Select disabled={disabled}>
                  {bodyshop.md_parts_locations.map((loc, idx) => (
                    <Select.Option key={idx} value={loc}>
@@ -366,7 +364,7 @@ export function BillEnterModalLinesComponent({
            name: [field.name, "deductedfromlbr"]
          };
        },
-        formInput: (record, index) => <Switch disabled={disabled} />,
+        formInput: () => <Switch disabled={disabled} />,
        additional: (record, index) => (
          <Form.Item shouldUpdate noStyle style={{ display: "inline-block" }}>
            {() => {
@@ -478,7 +476,7 @@ export function BillEnterModalLinesComponent({
                name: [field.name, "applicable_taxes", "federal"]
              };
            },
-            formInput: (record, index) => <Switch disabled={disabled} />
+            formInput: () => <Switch disabled={disabled} />
          }
        ]
      }),
@@ -495,7 +493,7 @@ export function BillEnterModalLinesComponent({
            name: [field.name, "applicable_taxes", "state"]
          };
        },
-        formInput: (record, index) => <Switch disabled={disabled} />
+        formInput: () => <Switch disabled={disabled} />
      },

      ...InstanceRenderManager({
@@ -513,7 +511,7 @@ export function BillEnterModalLinesComponent({
                name: [field.name, "applicable_taxes", "local"]
              };
            },
-            formInput: (record, index) => <Switch disabled={disabled} />
+            formInput: () => <Switch disabled={disabled} />
          }
        ]
      }),
@@ -575,7 +573,7 @@ export function BillEnterModalLinesComponent({
        }
      ]}
    >
-      {(fields, { add, remove, move }) => {
+      {(fields, { add, remove }) => {
        return (
          <>
            <Table
@@ -612,19 +610,7 @@ export function BillEnterModalLinesComponent({

 export default connect(mapStateToProps, mapDispatchToProps)(BillEnterModalLinesComponent);

-const EditableCell = ({
-  dataIndex,
-  title,
-  inputType,
-  record,
-  index,
-  children,
-  formInput,
-  formItemProps,
-  additional,
-  wrapper,
-  ...restProps
-}) => {
+const EditableCell = ({ dataIndex, record, children, formInput, formItemProps, additional, wrapper, ...restProps }) => {
  const propsFinal = formItemProps && formItemProps(record);
  if (propsFinal && "key" in propsFinal) {
    delete propsFinal.key;
--- a/client/src/components/bill-form/bill-form.totals.utility.js
+++ b/client/src/components/bill-form/bill-form.totals.utility.js
@@ -9,10 +9,10 @@ export const CalculateBillTotal = (invoice) => {
  let stateTax = Dinero({ amount: 0 });
  let localTax = Dinero({ amount: 0 });

-  if (!!!billlines) return null;
+  if (!billlines) return null;

  billlines.forEach((i) => {
-    if (!!i) {
+    if (i) {
      const itemTotal = Dinero({
        amount: Math.round((i.actual_cost || 0) * 100)
      }).multiply(i.quantity || 1);