Lint all the things

client/src/components/bill-detail-edit/bill-detail-edit-component.jsx

@@ -2,7 +2,7 @@ import { PageHeader } from "@ant-design/pro-layout";
 import { useMutation, useQuery } from "@apollo/client";
 import { Button, Divider, Form, Popconfirm, Space } from "antd";
 import queryString from "query-string";
-import React, { useState } from "react";
+import { useState } from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
 import { useLocation } from "react-router-dom";
@@ -10,7 +10,6 @@ import { createStructuredSelector } from "reselect";
 import { DELETE_BILL_LINE, INSERT_NEW_BILL_LINES, UPDATE_BILL_LINE } from "../../graphql/bill-lines.queries";
 import { QUERY_BILL_BY_PK, UPDATE_BILL } from "../../graphql/bills.queries";
 import { insertAuditTrail } from "../../redux/application/application.actions";
-import { setModalContext } from "../../redux/modals/modals.actions";
 import { selectBodyshop } from "../../redux/user/user.selectors";
 import AuditTrailMapping from "../../utils/AuditTrailMappings";
 import dayjs from "../../utils/day";
@@ -28,13 +27,12 @@ const mapStateToProps = createStructuredSelector({
   bodyshop: selectBodyshop
 });
 const mapDispatchToProps = (dispatch) => ({
-  setPartsOrderContext: (context) => dispatch(setModalContext({ context: context, modal: "partsOrder" })),
   insertAuditTrail: ({ jobid, operation, type }) => dispatch(insertAuditTrail({ jobid, operation, type }))
 });
 
 export default connect(mapStateToProps, mapDispatchToProps)(BillDetailEditcontainer);
 
-export function BillDetailEditcontainer({ setPartsOrderContext, insertAuditTrail, bodyshop }) {
+export function BillDetailEditcontainer({ insertAuditTrail, bodyshop }) {
   const search = queryString.parse(useLocation().search);
 
   const { t } = useTranslation();
@@ -48,7 +46,7 @@ export function BillDetailEditcontainer({ setPartsOrderContext, insertAuditTrail
 
   const { loading, error, data, refetch } = useQuery(QUERY_BILL_BY_PK, {
     variables: { billid: search.billid },
-    skip: !!!search.billid,
+    skip: !search.billid,
     fetchPolicy: "network-only",
     nextFetchPolicy: "network-only"
   });
@@ -71,7 +69,7 @@ export function BillDetailEditcontainer({ setPartsOrderContext, insertAuditTrail
     setUpdateLoading(true);
     //let adjustmentsToInsert = {};
 
-    const { billlines, upload, ...bill } = values;
+    const { billlines, ...bill } = values;
     const updates = [];
     updates.push(
       update_bill({
@@ -98,6 +96,7 @@ export function BillDetailEditcontainer({ setPartsOrderContext, insertAuditTrail
     });
 
     billlines.forEach((billline) => {
+      // eslint-disable-next-line no-unused-vars
       const { deductedfromlbr, inventories, jobline, original_actual_price, create_ppc, ...il } = billline;
       delete il.__typename;
 
@@ -152,8 +151,8 @@ export function BillDetailEditcontainer({ setPartsOrderContext, insertAuditTrail
   if (error) return <AlertComponent message={error.message} type="error" />;
   if (!search.billid) return <></>; //<div>{t("bills.labels.noneselected")}</div>;
 
-  const exported = data && data.bills_by_pk && data.bills_by_pk.exported;
-  const isinhouse = data && data.bills_by_pk && data.bills_by_pk.isinhouse;
+  const exported = data?.bills_by_pk && data.bills_by_pk.exported;
+  const isinhouse = data?.bills_by_pk && data.bills_by_pk.isinhouse;
 
   return (
     <>
@@ -183,8 +182,8 @@ export function BillDetailEditcontainer({ setPartsOrderContext, insertAuditTrail
                     {t("general.actions.save")}
                   </Button>
                 </Popconfirm>
-                <BillReeportButtonComponent bill={data && data.bills_by_pk} />
-                <BillMarkExportedButton bill={data && data.bills_by_pk} />
+                <BillReeportButtonComponent bill={data?.bills_by_pk} />
+                <BillMarkExportedButton bill={data?.bills_by_pk} />
               </Space>
             }
           />
@@ -220,11 +219,11 @@ const transformData = (data) => {
         billlines: data.bills_by_pk.billlines.map((i) => {
           return {
             ...i,
-            joblineid: !!i.joblineid ? i.joblineid : "noline",
+            joblineid: i.joblineid ? i.joblineid : "noline",
             applicable_taxes: {
-              federal: (i.applicable_taxes && i.applicable_taxes.federal) || false,
-              state: (i.applicable_taxes && i.applicable_taxes.state) || false,
-              local: (i.applicable_taxes && i.applicable_taxes.local) || false
+              federal: i.applicable_taxes?.federal || false,
+              state: i.applicable_taxes?.state || false,
+              local: i.applicable_taxes?.local || false
             }
           };
         }),

client/src/components/bill-detail-edit/bill-detail-edit-return.component.jsx

@@ -1,18 +1,15 @@
 import { Button, Checkbox, Form, Modal } from "antd";
 import queryString from "query-string";
-import React, { useEffect, useState } from "react";
+import { useEffect, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
 import { useLocation, useNavigate } from "react-router-dom";
 import { createStructuredSelector } from "reselect";
-import { insertAuditTrail } from "../../redux/application/application.actions";
 import { setModalContext } from "../../redux/modals/modals.actions";
-import { selectBodyshop } from "../../redux/user/user.selectors";
 import ReadOnlyFormItemComponent from "../form-items-formatted/read-only-form-item.component";
 
-const mapStateToProps = createStructuredSelector({
-  bodyshop: selectBodyshop
-});
+const mapStateToProps = createStructuredSelector({});
+
 const mapDispatchToProps = (dispatch) => ({
   setPartsOrderContext: (context) =>
     dispatch(
@@ -20,20 +17,12 @@ const mapDispatchToProps = (dispatch) => ({
         context: context,
         modal: "partsOrder"
       })
-    ),
-  insertAuditTrail: ({ jobid, operation, type }) =>
-    dispatch(
-      insertAuditTrail({
-        jobid,
-        operation,
-        type
-      })
     )
 });
 
 export default connect(mapStateToProps, mapDispatchToProps)(BillDetailEditReturn);
 
-export function BillDetailEditReturn({ setPartsOrderContext, insertAuditTrail, bodyshop, data, disabled }) {
+export function BillDetailEditReturn({ setPartsOrderContext, data, disabled }) {
   const search = queryString.parse(useLocation().search);
   const history = useNavigate();
   const { t } = useTranslation();
@@ -86,9 +75,9 @@ export function BillDetailEditReturn({ setPartsOrderContext, insertAuditTrail, b
         title={t("bills.actions.return")}
         onOk={() => form.submit()}
       >
-        <Form initialValues={data && data.bills_by_pk} onFinish={handleFinish} form={form}>
+        <Form initialValues={data?.bills_by_pk} onFinish={handleFinish} form={form}>
           <Form.List name={["billlines"]}>
-            {(fields, { add, remove, move }) => {
+            {(fields) => {
               return (
                 <table style={{ tableLayout: "auto", width: "100%" }}>
                   <thead>

client/src/components/bill-detail-edit/bill-detail-edit.container.jsx

@@ -1,6 +1,5 @@
 import { Drawer, Grid } from "antd";
 import queryString from "query-string";
-import React from "react";
 import { useLocation, useNavigate } from "react-router-dom";
 import BillDetailEditComponent from "./bill-detail-edit-component";