feature/IO-3586-Socket-Reconnect-Issues - Fix

server/fortellis/fortellis.js

@@ -180,22 +180,52 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
     getTransactionType(jobid),
     FortellisCacheEnums.txEnvelope
   );
-  const DMSVid = await redisHelpers.getSessionTransactionData(
-    socket.id,
-    getTransactionType(JobData.id),
-    FortellisCacheEnums.DMSVid
-  );
+  if (!JobData || !txEnvelope) {
+    const friendlyMessage =
+      "Fortellis export context was lost after reconnect. Click Post again to restart the Fortellis flow.";
+    CreateFortellisLogEvent(socket, "WARN", friendlyMessage, {
+      jobid,
+      hasJobData: !!JobData,
+      hasTxEnvelope: !!txEnvelope
+    });
+    socket.emit("export-failed", {
+      title: "Fortellis",
+      severity: "warning",
+      errorCode: "FORTELLIS_CONTEXT_MISSING",
+      friendlyMessage
+    });
+    return;
+  }
+
   try {
+    const DMSVid = await redisHelpers.getSessionTransactionData(
+      socket.id,
+      getTransactionType(JobData.id),
+      FortellisCacheEnums.DMSVid
+    );
+    if (!DMSVid) {
+      const friendlyMessage =
+        "Fortellis vehicle context is missing after reconnect. Click Post again to restart the Fortellis flow.";
+      CreateFortellisLogEvent(socket, "WARN", friendlyMessage, {
+        jobid,
+        hasDMSVid: !!DMSVid
+      });
+      socket.emit("export-failed", {
+        title: "Fortellis",
+        severity: "warning",
+        errorCode: "FORTELLIS_CONTEXT_MISSING",
+        friendlyMessage
+      });
+      return;
+    }
+
     let DMSCust;
     if (selectedCustomerId) {
       CreateFortellisLogEvent(socket, "DEBUG", `{3.1} Querying the Customer using Customer ID: ${selectedCustomerId}`);
 
       //Get cust list from Redis. Return the item
-      const DMSCustList = await getSessionTransactionData(
-        socket.id,
-        getTransactionType(jobid),
-        FortellisCacheEnums.DMSCustList
-      );
+      const DMSCustList =
+        (await getSessionTransactionData(socket.id, getTransactionType(jobid), FortellisCacheEnums.DMSCustList)) || [];
       const existingCustomerInDMSCustList = DMSCustList.find((c) => c.customerId === selectedCustomerId);
       DMSCust = existingCustomerInDMSCustList || {
         customerId: selectedCustomerId //This is the fall back in case it is the generic customer.
@@ -306,7 +336,7 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
           //There was something wrong. Throw an error to trigger clean up.
           //throw new Error("Error posting DMS Batch Transaction");
         }
-      } catch (error) {
+      } catch {
         //Clean up the transaction and insert a faild error code
         // //Get the error code
         CreateFortellisLogEvent(socket, "DEBUG", `{6.1} Getting errors for Transaction ID ${DMSTransHeader.transID}`);
@@ -336,6 +366,12 @@ async function FortellisSelectedCustomer({ socket, redisHelpers, selectedCustome
       stack: error.stack,
       data: error.errorData
     });
+    socket.emit("export-failed", {
+      title: "Fortellis",
+      severity: "error",
+      error: error.message,
+      friendlyMessage: "Fortellis export failed. Please click Post again to retry."
+    });
     await InsertFailedExportLog({
       socket,
       JobData,