feature/IO-3586-Socket-Reconnect-Issues - Fix

server/fortellis/fortellis-helpers.js

@@ -86,6 +86,9 @@ async function FetchSubscriptions({ redisHelpers, socket, jobid, SubscriptionObj
         logRequest: false
       });
       const SubscriptionMeta = subscriptions.data.subscriptions.find((s) => s.subscriptionId === SubscriptionID);
+      if (!SubscriptionMeta) {
+        throw new Error(`Subscription metadata not found for SubscriptionID: ${SubscriptionID}`);
+      }
       if (setSessionTransactionData) {
         await setSessionTransactionData(
           socket.id,
@@ -102,11 +105,15 @@ async function FetchSubscriptions({ redisHelpers, socket, jobid, SubscriptionObj
       error: error.message,
       stack: error.stack
     });
+    throw error;
   }
 }
 
 async function GetDepartmentId({ apiName, debug = false, SubscriptionMeta, overrideDepartmentId }) {
   if (!apiName) throw new Error("apiName not provided. Unable to get department without apiName.");
+  if (!SubscriptionMeta || !Array.isArray(SubscriptionMeta.apiDmsInfo)) {
+    throw new Error("Subscription metadata missing apiDmsInfo.");
+  }
   if (debug) {
     console.log("API Names & Departments ");
     console.log("===========");
@@ -118,9 +125,8 @@ async function GetDepartmentId({ apiName, debug = false, SubscriptionMeta, overr
     .find((info) => info.name === apiName)?.departments; //Departments are categorized by API name and have an array of departments.
 
   if (overrideDepartmentId) {
-    return departmentIds && departmentIds.find(d => d.id === overrideDepartmentId)?.id
+    return departmentIds && departmentIds.find((d) => d.id === overrideDepartmentId)?.id;
   } else {
-
     return departmentIds && departmentIds[0] && departmentIds[0].id; //TODO: This makes the assumption that there is only 1 department.
   }
 }