feature/IO-3357-Reynolds-and-Reynolds-DMS-API-Integration -Insert Export Log

server/rr/rr-register-socket-events.js

@@ -7,6 +7,9 @@ const { createRRCustomer } = require("./rr-customers");
 const { ensureRRServiceVehicle } = require("./rr-service-vehicles");
 const { classifyRRVendorError } = require("./rr-errors");
 
+// NEW: export logs (success/failure) parity with Fortellis/PBS
+const { markRRExportSuccess, insertRRFailedExportLog } = require("./rr-export-logs");
+
 const {
   makeVehicleSearchPayloadFromJob,
   ownersFromVinBlocks,
@@ -385,6 +388,9 @@ function registerRREvents({ socket, redisHelpers }) {
   // 2) Selection (or create) -> ensure vehicle -> export
   socket.on("rr-selected-customer", async ({ jobid, jobId, selectedCustomerId, custNo, create } = {}, ack) => {
     const rid = resolveJobId(jobid || jobId, { jobid, jobId }, null);
+    let bodyshop = null;
+    let job = null;
+
     try {
       if (!rid) throw new Error("jobid required");
       CreateRRLogEvent(socket, "DEBUG", `{3} rr-selected-customer`, {
@@ -400,12 +406,12 @@ function registerRREvents({ socket, redisHelpers }) {
         (selectedCustomerId && String(selectedCustomerId)) ||
         (await redisHelpers.getSessionTransactionData(socket.id, ns, RRCacheEnums.SelectedCustomer));
 
-      const job = await redisHelpers.getSessionTransactionData(socket.id, ns, RRCacheEnums.JobData);
+      job = await redisHelpers.getSessionTransactionData(socket.id, ns, RRCacheEnums.JobData);
       const txEnvelope = (await redisHelpers.getSessionTransactionData(socket.id, ns, RRCacheEnums.txEnvelope)) || {};
       if (!job) throw new Error("Staged JobData not found (run rr-export-job first).");
 
       const { bodyshopId } = await getSessionOrSocket(redisHelpers, socket);
-      const bodyshop = await getBodyshopForSocket({ bodyshopId, socket });
+      bodyshop = await getBodyshopForSocket({ bodyshopId, socket });
 
       // Create customer (if requested or none chosen)
       if (create === true || !selectedCustNo) {
@@ -526,6 +532,15 @@ function registerRREvents({ socket, redisHelpers }) {
       const advisorNo = readAdvisorNo({ txEnvelope }, cachedAdvisor);
       if (!advisorNo) {
         CreateRRLogEvent(socket, "ERROR", `Advisor is required (advisorNo)`);
+        // Failure log (no advisor)
+        await insertRRFailedExportLog({
+          socket,
+          jobId: rid,
+          job,
+          bodyshop,
+          error: new Error("Advisor is required (advisorNo)."),
+          classification: { errorCode: "RR_MISSING_ADVISOR", friendlyMessage: "Advisor is required." }
+        });
         socket.emit("export-failed", { vendor: "rr", jobId: rid, error: "Advisor is required (advisorNo)." });
         return ack?.({ ok: false, error: "Advisor is required (advisorNo)." });
       }
@@ -550,6 +565,16 @@ function registerRREvents({ socket, redisHelpers }) {
 
       if (result?.success) {
         CreateRRLogEvent(socket, "DEBUG", `{5} Export success`, { roStatus: result.roStatus });
+
+        // ✅ Mark exported + success log (with metadata)
+        await markRRExportSuccess({
+          socket,
+          jobId: rid,
+          job,
+          bodyshop,
+          result
+        });
+
         socket.emit("export-success", { vendor: "rr", jobId: rid, roStatus: result.roStatus });
         ack?.({ ok: true, result });
       } else {
@@ -567,10 +592,21 @@ function registerRREvents({ socket, redisHelpers }) {
           classification: cls
         });
 
+        // ❌ Failure log (with classification + bits of response)
+        await insertRRFailedExportLog({
+          socket,
+          jobId: rid,
+          job,
+          bodyshop,
+          error: new Error(cls.friendlyMessage || result?.error || "RR export failed"),
+          classification: cls,
+          result
+        });
+
         socket.emit("export-failed", {
           vendor: "rr",
           jobId: rid,
-          error: result?.error || cls.friendlyMessage || "RR export failed",
+          error: cls?.friendlyMessage || result?.error || "RR export failed",
           ...cls
         });
         // Optional: a user-focused channel if you want to show inline banners
@@ -591,7 +627,7 @@ function registerRREvents({ socket, redisHelpers }) {
         result || {},
         defaultRRTTL
       );
-      socket.emit("rr-export-job:result", { jobId: rid, bodyshopId, result });
+      socket.emit("rr-export-job:result", { jobId: rid, bodyshopId: bodyshop?.id, result });
     } catch (error) {
       const cls = classifyRRVendorError(error);
 
@@ -604,6 +640,29 @@ function registerRREvents({ socket, redisHelpers }) {
         jobid: rid
       });
 
+      // ❌ Failure log for thrown error path
+      try {
+        // Load bodyshop/job if not loaded yet (best-effort)
+        if (!bodyshop || !job) {
+          const { bodyshopId } = await getSessionOrSocket(redisHelpers, socket);
+          bodyshop = bodyshop || (await getBodyshopForSocket({ bodyshopId, socket }));
+          job =
+            job ||
+            (await redisHelpers.getSessionTransactionData(socket.id, getTransactionType(rid), RRCacheEnums.JobData));
+        }
+      } catch {
+        // ignore
+      }
+
+      await insertRRFailedExportLog({
+        socket,
+        jobId: rid,
+        job,
+        bodyshop,
+        error,
+        classification: cls
+      });
+
       try {
         socket.emit("export-failed", {
           vendor: "rr",