feature/IO-3096-GlobalNotifications - Code Review Part 5

server/notifications/scenarioMapper.js

@@ -71,6 +71,7 @@ const notificationScenarios = [
     key: "job-added-to-production",
     table: "jobs",
     fields: ["inproduction"],
+    onlyTruthyValues: ["inproduction"],
     builder: jobsAddedToProductionBuilder
   },
   {
@@ -129,6 +130,19 @@ const notificationScenarios = [
   }
 ];
 
+/**
+ * Returns an array of scenarios that match the given event data.
+ *
+ * @param {Object} eventData - The parsed event data.
+ *   Expected properties:
+ *     - table: an object with a `name` property (e.g. { name: "tasks", schema: "public" })
+ *     - changedFieldNames: an array of changed field names (e.g. [ "description", "updated_at" ])
+ *     - isNew: boolean indicating whether the record is new or updated
+ *     - data: the new data object (used to check field values)
+ *     - (other properties may be added such as jobWatchers, bodyShopId, etc.)
+ *
+ * @returns {Array<Object>} An array of matching scenario objects.
+ */
 /**
  * Returns an array of scenarios that match the given event data.
  *
@@ -181,6 +195,36 @@ const getMatchingScenarios = (eventData) =>
       }
     }
 
+    // OnlyTruthyValues logic:
+    // If onlyTruthyValues is defined, check that the new values of specified fields (or all changed fields if true)
+    // are truthy. If an array, only check the listed fields, which must be in scenario.fields.
+    if (Object.prototype.hasOwnProperty.call(scenario, "onlyTruthyValues")) {
+      let fieldsToCheck;
+
+      if (scenario.onlyTruthyValues === true) {
+        // If true, check all fields in the scenario that changed
+        fieldsToCheck = scenario.fields.filter((field) => eventData.changedFieldNames.includes(field));
+      } else if (Array.isArray(scenario.onlyTruthyValues) && scenario.onlyTruthyValues.length > 0) {
+        // If an array, check only the specified fields, ensuring they are in scenario.fields
+        fieldsToCheck = scenario.onlyTruthyValues.filter(
+          (field) => scenario.fields.includes(field) && eventData.changedFieldNames.includes(field)
+        );
+        // If no fields in onlyTruthyValues match the scenario’s fields or changed fields, skip this scenario
+        if (fieldsToCheck.length === 0) {
+          return false;
+        }
+      } else {
+        // Invalid onlyTruthyValues (not true or a non-empty array), skip this scenario
+        return false;
+      }
+
+      // Ensure all fields to check have truthy new values
+      const allTruthy = fieldsToCheck.every((field) => Boolean(eventData.data[field]));
+      if (!allTruthy) {
+        return false;
+      }
+    }
+
     return true;
   });