From 171b61b92fead6a2279c8b6acb673b221a65169a Mon Sep 17 00:00:00 2001 From: Patrick Fic Date: Wed, 19 Apr 2023 14:08:57 -0700 Subject: [PATCH 1/3] Included a limit on global search query to limit performance impact. --- client/src/graphql/jobs.queries.js | 2 +- client/src/graphql/search.queries.js | 12 +++++------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/client/src/graphql/jobs.queries.js b/client/src/graphql/jobs.queries.js index a6273edc4..50225795f 100644 --- a/client/src/graphql/jobs.queries.js +++ b/client/src/graphql/jobs.queries.js @@ -1278,7 +1278,7 @@ export const SEARCH_JOBS_BY_ID_FOR_AUTOCOMPLETE = gql` export const SEARCH_FOR_JOBS = gql` query SEARCH_FOR_JOBS($search: String!) { - search_jobs(args: { search: $search }) { + search_jobs(args: { search: $search }, limit: 25) { id ro_number ownr_fn diff --git a/client/src/graphql/search.queries.js b/client/src/graphql/search.queries.js index a4d8339f9..b972a239b 100644 --- a/client/src/graphql/search.queries.js +++ b/client/src/graphql/search.queries.js @@ -2,22 +2,20 @@ import { gql } from "@apollo/client"; export const GLOBAL_SEARCH_QUERY = gql` query GLOBAL_SEARCH_QUERY($search: String) { - search_jobs(args: { search: $search }) { + search_jobs(args: { search: $search }, limit: 25) { id ro_number status - clm_no v_model_yr v_model_desc v_make_desc v_color - ownr_fn ownr_ln ownr_co_nm } - search_owners(args: { search: $search }) { + search_owners(args: { search: $search }, limit: 25) { id ownr_fn ownr_ln @@ -34,7 +32,7 @@ export const GLOBAL_SEARCH_QUERY = gql` v_vin plate_no } - search_payments(args: { search: $search }) { + search_payments(args: { search: $search }, limit: 25) { id amount paymentnum @@ -45,7 +43,7 @@ export const GLOBAL_SEARCH_QUERY = gql` memo transactionid } - search_bills(args: { search: $search }) { + search_bills(args: { search: $search }, limit: 25) { id date invoice_number @@ -54,7 +52,7 @@ export const GLOBAL_SEARCH_QUERY = gql` name } } - search_phonebook(args: { search: $search }) { + search_phonebook(args: { search: $search }, limit: 25) { id firstname lastname From f5758706856be0d9aee5bc414a082a6caae2d1bd Mon Sep 17 00:00:00 2001 From: Patrick Fic Date: Wed, 19 Apr 2023 14:10:33 -0700 Subject: [PATCH 2/3] Added missed limit on global search. --- client/src/graphql/search.queries.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/graphql/search.queries.js b/client/src/graphql/search.queries.js index b972a239b..1c1943e30 100644 --- a/client/src/graphql/search.queries.js +++ b/client/src/graphql/search.queries.js @@ -23,7 +23,7 @@ export const GLOBAL_SEARCH_QUERY = gql` ownr_ph1 ownr_ph2 } - search_vehicles(args: { search: $search }) { + search_vehicles(args: { search: $search }, limit: 25) { id v_model_yr v_model_desc From a7cf36d5f8338ee325679ec5b04be55f29d84fea Mon Sep 17 00:00:00 2001 From: Patrick Fic Date: Wed, 19 Apr 2023 14:26:12 -0700 Subject: [PATCH 3/3] Disable job status transition tracking. --- server/job/job-status-transition.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/job/job-status-transition.js b/server/job/job-status-transition.js index c63fcb566..4b6a7db76 100644 --- a/server/job/job-status-transition.js +++ b/server/job/job-status-transition.js @@ -20,7 +20,8 @@ async function StatusTransition(req, res) { res.status(403).send("Unauthorized"); return; } - + res.sendStatus(200); + return; const { id: jobid, status: value,