admin/bodyshop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in feature/IO-3255-simplified-part-management (pull request #2552)

Browse Source 
feature/IO-3255-simplified-parts-management -Extra checks
This commit is contained in:
Dave Richer
2025-09-11 15:24:38 +00:00
parent 23dd8fc9de 268b57c38a
commit 0e7531dc54
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/integrations/partsManagement/endpoints/partsManagementDeprovisioning.js
View File

@@ -88,7 +88,7 @@ const partsManagementDeprovisioning = async (req, res) => {
const { logger } = req; const { logger } = req;
const { shopId } = req.body; const { shopId } = req.body;
if (process.env.NODE_ENV === "production") { if (process.env.NODE_ENV === "production" || process.env.HOSTNAME?.endsWith("compute.internal")) {
return res.status(403).json({ error: "Deprovisioning not allowed in production environment." }); return res.status(403).json({ error: "Deprovisioning not allowed in production environment." });
} }

10
server/routes/intergrationRoutes.js
View File

@@ -1,5 +1,6 @@
const express = require("express"); const express = require("express");
const router = express.Router(); const router = express.Router();
const logger = require("../../server/utils/logger");
// Pull secrets from env // Pull secrets from env
const { VSSTA_INTEGRATION_SECRET, PARTS_MANAGEMENT_INTEGRATION_SECRET } = process.env; const { VSSTA_INTEGRATION_SECRET, PARTS_MANAGEMENT_INTEGRATION_SECRET } = process.env;
@@ -11,7 +12,7 @@ if (typeof VSSTA_INTEGRATION_SECRET === "string" && VSSTA_INTEGRATION_SECRET.len
router.post("/vssta", vsstaMiddleware, vsstaIntegration); router.post("/vssta", vsstaMiddleware, vsstaIntegration);
} else { } else {
console.warn("VSSTA_INTEGRATION_SECRET is not set — skipping /vssta integration route"); logger.logger.warn("VSSTA_INTEGRATION_SECRET is not set — skipping /vssta integration route");
} }
// Only load Parts Management routes if that secret is set // Only load Parts Management routes if that secret is set
@@ -45,14 +46,17 @@ if (typeof PARTS_MANAGEMENT_INTEGRATION_SECRET === "string" && PARTS_MANAGEMENT_
); );
// Deprovisioning route // Deprovisioning route
router.post("/parts-management/deprovision", partsManagementIntegrationMiddleware, partsManagementDeprovisioning); if (process.env.NODE_ENV !== "production" && !process.env.HOSTNAME?.endsWith("compute.internal")) {
logger.logger.warn("Parts Management Deprovisioning route has been loaded.");
router.post("/parts-management/deprovision", partsManagementIntegrationMiddleware, partsManagementDeprovisioning);
}
/** /**
* Route to handle Parts Management Provisioning * Route to handle Parts Management Provisioning
*/ */
router.post("/parts-management/provision", partsManagementIntegrationMiddleware, partsManagementProvisioning); router.post("/parts-management/provision", partsManagementIntegrationMiddleware, partsManagementProvisioning);
} else { } else {
console.warn("PARTS_MANAGEMENT_INTEGRATION_SECRET is not set — skipping /parts-management/provision route"); logger.logger.warn("PARTS_MANAGEMENT_INTEGRATION_SECRET is not set — skipping /parts-management/provision route");
} }
module.exports = router; module.exports = router;